kevinweber

Hi @jrgong, the error message is gone. However, I found out what causes the link to open in a new window: An “onclick” attribute is being added to the video link that forces the link to open in a new tab. You must be using a plugin that causes this change, or your theme does this.

See: https://ibb.co/DVfVZVs

• This reply was modified 3 years, 9 months ago by kevinweber.
• This reply was modified 3 years, 9 months ago by kevinweber.

@jrgong Your page is throwing a JS error in a portion of the code that’s not related to the video plugin: “Uncaught ReferenceError: wp is not defined”

You can check out the error using DevTools in the browser. It seems to be related to the “generate-offside-js-extra” script where it runs “wp.i18n.setLocaleData( localeData, domain );”. The script might not be added to the page properly.

This plugin doesn’t support custom iframe tags, only WordPress oEmbed-supported video links, which is what you get by using the embed block.

Why can’t you use the embed block? What feature would be missing if you were to use the embed block instead?

What’s the video URL that you added to your blog post? (I’m referring to the actual URL that you pasted, not the “expected” URL or embed code that you’re seeing in the published blog post.)

@aaron13223 What happens if you open the post URL in an incognito window? My guess is that you need to clear your browser cache to get the latest JavaScript code for your website.

I just published version 2.15.1. Please let me know if this fixes the issue.
Best regards,
Kevin

Hi,
thanks for reaching out and sharing the screenshots. I’ve tried to reproduce the issue without success and therefore I have to assume that the issue is specific to a conflict between your theme or some other plugin and my plugin. In particular, I’m seeing on the page that you shared that the iframe is surrounded by elements with class names “responsive-video-wrap clr” and “fluid-width-video-wrapper”. The one element has a custom style “padding-top: 56.25%;”. Those styles could be conflicting with the Lazy Load for Videos styling and there might be a solution to solve this with some custom CSS changes. Hopefully that helps and you can ask some web developer to figure out what CSS to change.
Best regards,
Kevin

Hi, I just checked the code of your video on the linked page and it has a CSS class “lyte-wrapper”. This is not from my plugin; I think you’re using some other plugin and reached out to the wrong forum. Is it possible that you’re using “WP YouTube Lyte” instead of my plugin “Lazy Load for Videos”?

Hi, are you using any other video plugin on your site? How are you adding the video to your post? Are you using the official Youtube block for adding the video or are you manually pasting an embed code or some other kind of HTML?

Hi Aaron, thanks for reporting this and providing such helpful details about the issue! This should be relatively to fix; I’ll take a look at it on the weekend.

@mpmchugh PR in the context of open source development stands for Pull Request, a way to contribute code. All of the plugin’s code is on Github where contributions can be made: https://github.com/kevinweber/lazy-load-for-videos/pulls

• This reply was modified 3 years, 11 months ago by kevinweber.

This plugin should already be ignored on AMP pages (see code here), falling back to whatever WordPress does by default for video embeds. I don’t plan to make further changes but you’re happy to contribute on Github if you can implement a better solution that works for everyone.

This was a relatively recent change and you might have to click on the “Update Posts” button on the admin panel to update all already published posts.

• This reply was modified 3 years, 11 months ago by kevinweber.

Hi, that’s odd. “KW_LLV_Styles 2doesn’t seem like a common name. Can you search for “class KW_LLV_Styles” in your plugin and theme folders? There must be some file other than “static-styles.php” that also uses this name.

Hi, I’m sorry to hear that. Can you provide more details? Did you insert the video URL on its own line without any whitespace and characters around it?

Those are all good ideas. I’m definitely open to make a change within the video plugin; it would just be extremely helpful if those builder/theme developers can make a PR with solution – for the reasons mentioned. Let’s come back to this once you’ve heard from them.