kontur

@proreclame Were you able to resolve this issue?

Any update on this?

Hey,

it looks like another html tag is not closed properly, so this declaration by Fontsampler gets rendered visibly in a spot where it should not. If I have a look at the source code of the link, I see this:

<div <script="">var fontsamplerBaseUrl = '/wp-content/plugins/fontsampler/'; 
		 class="tm-description"><p>&nbsp;Dit is hulpvoorbeeld om u even te helpen met een keuze ...

The <div> with the class tm-description seems to not be properly closed (missing “>”) before the Fontsampler shortcode. Have a look on your page if you can find where this tag remained open and close it before including the Fontsampler shortcode. If you cannot find anything, could you post a screenshot of the spot where you are including the Fontsampler shortcode?

Cheers,
Johannes

Sorry, wrong plugin :O

What the code above does is read in a file and send it to the browser to be downloaded. The content length is gotten from the file that is to be sent, so the browser knows when “all of it” has been transmitted.

This download code can be called on any kind of page, so let’s assume I have a special URL that is not supposed to actually output anything, since the above headers just tell it to download a file. Visiting that page would result in an empty browser window, sending a POST request from a given page to that URL does not update the current browser page at all – it opens a download dialog, downloads, then closes the dialog.

The way this code is hooked up to WordPress is via WP’s init hook. In it, it checks if a particular POST parameter is set, and if so, initiates the download and then exit()‘s, staying on the current page.

How Minify interferes with it is that presumably already by the time the init hook is reached, or in a hook before that, the plugin “catches” all output, which would later on be minified and output. Even though the page that receives the POST parameter does not actually output anything (the exit() after the download code preventing the page form getting anywhere near WP’s output), Minify already started caching that page. Since PHP ends, it probably just dumps the buffered html up to that point – thus interfering with the content output of my download script, which should only be the file content.

In a nutshell I’d need a way to disable the plugin for particular URLs or REQUEST parameters. What hook does the plugin use to do business – it is hacky but should be possible for me to just “unregister” the plugin activation like that?

Superb! Thank you for the quick feedback and the ever quicker implementation. Using the Ajax response now in my project to give the user more detailed feedback.

Oh! I did not realise the imported files stay linked to the import location, and also get updated by simply (keeping and) updating the files in that same spot.

Ah, great, thank you again! ??

Thanks for pointing that out. For anybody finding this topic, the correct syntax to use is this, with the options only after the type and name of the field:

[checkbox licensee use_label_element exclusive "Person" "Company"]

*facepalm* Thanks, solved ??

Very nice plugin, thank you for the work!

Hey,
glad to hear the font upload now works without problems.

If styling does not seem to be affected by your changes there is a chance your cache is not updating/invalidating when you make changes, and thus serves old files. On my sites I’ve used a different caching plugin, so I can’t exactly give you instructions on how to refresh your cache, but the plugin should have options for that. The one I use, for example, doesn’t generate new cache files for logged in users (admins) unless to specifically enable it to do so. Also, if you are using an external CDN cache like Cloudflare or the like then their remote cache also needs to retrieve new files from your site for caching, after they have updated on your server.

Fontsampler is not very restrictive in its own styling, meaning where sensible it will inherit values from your site, like font color, family, styling of general level elements like html tags etc. If you find something in particular that seems off let me know or provide a screenshot or link so I can do some more investigating.

Hey,

I’ll look into it. the [add_to_cart id=”xx”] shortcode is relating to woocommerce, no? Since Fontsampler itself is included as a shortcode, I doubt that a shortcode in the output generated by Fontsampler can be processed, but I’ll have to check how WordPress handles this, and if there is something that would enable this kind of nested shortcode.
By default the buy and specimen buttons expect a link, and will generate a link element with a href of the passed in value. It would require some kind of alteration to allow for passing in another shortcode instead.

I am wondering if it would be easier to pass in javascript code to trigger the desired event. I don’t the exact specifics of Woocommerce, but if it exposes some add to cart -method you could call this from the buy link, giving it a value of “javascript:addToCart(‘xx’);return false;” or something like that, assuming there is a “addToCart” method of Woocommerce.

I’ll try to have a look at this within the next week and get back to you. Let me know if you find anything out about this javascript approach I suggested.

Yes, that will do the same trick ?? Glad it works for you now.

This should be fixed in version 0.2.6 which I just published. It might take up to a couple of hours until the update is visible on all WP installations. Once you have upgraded, let me know if this fixes this issue.

Roger. I’ll try to point this out more clearly in the plugin website FAQ and readme files, as well as provide a work around for those users affected.

Out of curiosity, what version of WordPress are you running that requires you to add those mime types to the functions.php?