Dmytro Shteflyuk
Forum Replies Created
-
Forum: Plugins
In reply to: [CodeColorer] How to correct create_function() is deprecated errorThis has been addressed in 0.10.0
Forum: Plugins
In reply to: [CodeColorer] Dedicated Gutenberg blockSweet, I will take look, thank you!
Forum: Plugins
In reply to: [CodeColorer] Dedicated Gutenberg blockHi Andrew,
I have started working on Gutenberg integration a while ago, but there is no release date I can promise [yet]. The change is pretty big, as it requires a lot more client-side changes, and I am still learning the ropes to make it work. Options are the easiest part, but the layout/formatting/editing part is pretty tricky.
Good catch on the highlight numbers! Will make sure it is fixed as well.
Thank you
Forum: Plugins
In reply to: [CodeColorer] Gutenberg editorYeah, I see them now. Will investigate!
Forum: Plugins
In reply to: [CodeColorer] Gutenberg editorThe easiest way at to make it work at the moment is to use “shortcode” block, and insert the value in form:
[cc lang="php"] $x = "10"; [/cc]
Forum: Plugins
In reply to: [CodeColorer] Gutenberg editorI am still investigating. There are reports of some issues, and I am in the progress of investigating.
Forum: Plugins
In reply to: [Gutenberg] Paragraph(Other) Blocks Stripping Tag AttributesCodeColorer author’s here. Interesting, I will check the Gutenberg editor and see what I can do in terms of compatibility. Thank you for reporting!
- This reply was modified 6 years, 3 months ago by Dmytro Shteflyuk.
Forum: Plugins
In reply to: [Simple Download Monitor] Issue with CodeColorer plugin@mra13 sorry for kind of unrelated comment, but I have noticed the graphics on the plugin page for the Simple Download Monitor is a little bit blurry for Simple Download Monitor. Turns out, you only have non-retina assets in https://plugins.trac.www.ads-software.com/browser/simple-download-monitor/assets
If you add banner-1544×500.png it will significantly improve the quality of the plugin page on retina displays ?? Same thing with the icon.
https://developer.www.ads-software.com/plugins/wordpress-org/plugin-assets/
Forum: Plugins
In reply to: [Simple Download Monitor] Issue with CodeColorer pluginThank you, I have updated CodeColorer with necessary changes to properly integrate with Simple Download Monitor.
Forum: Plugins
In reply to: [CodeColorer] Using CodeColerer with Simple Download MonitorJust released version 0.9.16 with a fix for this, and also couple other bug fixes (especially iOS related formatting improvements).
Please check if it resolves your issue.
Thank you!
Forum: Plugins
In reply to: [CodeColorer] Is this plugin GDPR Compliant?Yes, the plugin is GDPR compliant. Added this to the FAQ section, thank you
https://github.com/kpumuk/codecolorer/commit/4eb17fae7bb9651153ec6e263c3b72f9dd33bd33
Forum: Plugins
In reply to: [CodeColorer] Can’t define default code block width in % or emThank you for your feedback! This will be fixed in the upcoming release.
https://github.com/kpumuk/codecolorer/commit/c61b3d977d6ecf7dd3574845d568efde289ee773
Forum: Plugins
In reply to: [Simple Download Monitor] Issue with CodeColorer pluginSorry, I also meant to add reference links, but forgot:
Forum: Plugins
In reply to: [CodeColorer] Using CodeColerer with Simple Download MonitorHi. Let’s move this to the thread for “Simple Download Monitor” plugin, as the is a missing integration point, and we will need to make a change in that plugin first:
https://www.ads-software.com/support/topic/issue-with-codecolorer-plugin/
I will keep this thread open since there will be a change to CodeColorer after (if?) Simple Download Monitor is updated.
(sorry, I think I missed your email)
Forum: Plugins
In reply to: [Simple Download Monitor] Issue with CodeColorer pluginAlright, I figured out the issue. The problem is that CodeColorer generates HTML tags in the first step of the Simple Download description processing (sdm_get_item_description_output function). In order to do that I need to call my function before and after sdm_get_item_description_output, which I can’t do since there are no callbacks provided.
If “Simple Download Monitor” is willing to make a change to switch from direct WP functions invocations to a more proper way of doing that – filters, we can fix the issue (and provide a way for other plugins to integrate).
Here is the proposed change to Simple Download Monitor:
In wp-content/plugins/simple-download-monitor/sdm-post-type-content-handler.php add this:
add_filter('sdm_downloads_description', 'do_shortcode' ); add_filter('sdm_downloads_description', 'wptexturize' ); add_filter('sdm_downloads_description', 'convert_smilies' ); add_filter('sdm_downloads_description', 'convert_chars' ); add_filter('sdm_downloads_description', 'wpautop' ); add_filter('sdm_downloads_description', 'shortcode_unautop' ); add_filter('sdm_downloads_description', 'prepend_attachment');
In wp-content/plugins/sim
ple-download-monitor/includes/sdm-utility-functions.php change sdm_get_item_description_output to:function sdm_get_item_description_output($id) { $item_description = get_post_meta($id, 'sdm_description', true); $isset_item_description = isset($item_description) && !empty($item_description) ? $item_description : ''; return apply_filters('sdm_downloads_description', $isset_item_description); }
The behavior of the plugin will not change, but this will allow me and other plugin authors to integrate with Simple Download Monitor, e.g. add extract processing. For example, this will allow me to fix CodeColorer by adding two filters:
add_filter('sdm_downloads_description', array('CodeColorerLoader', 'callBeforeHighlightCodeBlock'), -1000); add_filter('sdm_downloads_description', array('CodeColorerLoader', 'callAfterHighlightCodeBlock'), 1000);
@mbrsolution, what do you think?
- This reply was modified 6 years, 4 months ago by Dmytro Shteflyuk.