kwisatz

The error in question here is that $data passed to save_admin() contains a property settings that has already been coerced into a string but should be an array.

This happens in admin/save.php when esc_html() is run indiscriminately over all $_POST values (error_log call is mine):

foreach ( $_POST as $key => $val ) {
        if ( substr($key, 0, 1) != '_') {
                $data_array[$key] = esc_html($val);
                error_log(sprintf('NF POST val before: %s, val after: %s', print_r($val, true), print_r($data_array[$key], true)));
        }
}

The result being:

[10-Mar-2020 09:17:38 UTC] NF POST val before: Array
(
    [name] => Redirect
    [type] => redirect
    [from_name] => 
    [from_address] => 
    [to] => 
    [email_subject] => 
    [email_message] => 
    [attach_csv] => 0
    [email_format] => html
    [reply_to] => 
    [cc] => 
    [bcc] => 
    [redirect_url] => https://domain.com
    [success_msg] => 
)
, val after: Array

• This reply was modified 4 years, 8 months ago by kwisatz.
• This reply was modified 4 years, 8 months ago by kwisatz. Reason: Style
• This reply was modified 4 years, 8 months ago by kwisatz. Reason: remove medium sensitive information

Oh my, I don’t remember which site it was.

It’s just weird though, how could CF7 complain that a deprecated function was used if it didn’t supply wpcf7_add_form_tag yet? That wouldn’t make any sense IMHO.

Thanks.

We’re using the tags to build docker images of the WordPress development environment for specific versions that match the production environment.

I’ll see if we can switch to cloning from GitHub or using releases instead then, but that’s not exactly the same thing.

But I’d still be interested in knowing how to recreate the js dist directory on a tagged branch.

No, object cache is disabled since we had problems with that before. And we also stumbled on the php-apc bug that would crash our web-server. (long-standing bug in Debian an derivatives)

We have browser, page and database cache enabled.

There’s a related thread on the UserVoice forums if you want to jump there directly.

The maintainer of the WordPress package is currently working on getting phpmailer backported in the correct version to match the upstream version.

You can follow the progress on the Debian backports mailing list.

Anyone interested in following this up, here’s a link to the jessie-backports mailing list where this bug report ended up: https://www.eenyhelp.com/answer/bug-818758-wordpress-plugins-depending-libphp-phpmailer-5-2-10-help-215986354.html

Simply to follow up for anyone else stumbling on this issue too:
WordPress in Debian uses the libphp-phpmailer package, which is indeed still version 5.2.9 on Jessie, although WP is available in 4.4.2.

libphp-phpmailer:
  Installed: 5.2.9+dfsg-2+deb8u1
  Candidate: 5.2.9+dfsg-2+deb8u1
  Version table:
 *** 5.2.9+dfsg-2+deb8u1 0
        500 https://debian.mirror.root.lu/debian/ jessie/main i386 Packages
        500 https://security.debian.org/ jessie/updates/main i386 Packages
        100 /var/lib/dpkg/status

I will file a bug report with Debian later today.

Oh, sorry, I hadn’t thought of checking the sources on WP’s Trac.

Would it be possible that Debian ships a WordPress in version 4.4.1 with PHPMailer 5.2.9 for some reason or another?

I just checked again an I definitely have version 5.2.9 in a WordPress installation that has 4.4.1 written all over it:

class PHPMailer
{
    /**
     * The PHPMailer Version number.
     * @type string
     */
    public $Version = '5.2.9';

I just upgraded to 4.4.2 and it still ships with phpmailer 5.2.9. But I guess this is a fight I will need to take up with Debian Maintainers in this case then. Thanks for your quick response!

Did someone notify the author of the Contact Form 7 about this problem? Could it be a method removed from PHPMailer in a recent version deployed with a wordpress update?

OK, PHPMailer::getCustomHeaders() is available in PHPMailer since 5.2.10.
But WP 4.4.1 ships with 5.2.9 which doesn’t have that function yet.

Reported here https://www.ads-software.com/support/topic/broken-with-wp-441-which-ships-with-phpmailer-529?replies=1#post-8170756

I’m sorry, I didn’t mean the comment to sound harsh. I will test it again in a few days and review my rating then, giving more detailed explanations on where some problems are.

Adam, can you open an issue on https://www.ads-software.com/support/plugin/ge-rss-reader and provide any details such as

* the WP version you’re using,
* the PHP version, and
* any info you get when you set WP_DEBUG to true in your wp-config.php and then try activating it again?

I’ll need that information in order to attempt to reproduce the issue. On my development setup it activated without a hitch.

Adam, not sure what you mean. There’s already a possibility to display and shorten item descriptions.

The plugin is now also in wordpress svn and available from https://www.ads-software.com/plugins/ge-rss-reader/

Yes, I have. I also requested and got svn access for the fork, but I’ve not committed any code yet. Currently it’s on github.

But I’ll try and commit the code today. (Thanks for the reminder ;))