KZeni

Sounds good. It came to mind & thought it might be worth mentioning. Totally understand if there’s reasons against it.

*Sorry for the double post. Forums are acting strange for me (showed it didn’t post… goes to forum listing when trying to edit/view… posts disappear/appear on refresh… hmm)

I appreciate you looking into it for the next release!

UPDATE. I want to point out that the old way the wr2x_srcset_rewrite function was set up was creating a second problem. I have a site using HTML5 tags (<header>, <footer>, etc.), and using the srcset rewrite method had the plugin adding a second set of doctype (loose html4) & opening html/head tags within wp_head and closing body/html tags within wp_footer.

This seems like an important fix as it was butchering the site’s markup, and it’s no good having the most forward-looking method use a DOM parser that breaks when given HTML5 tags. My suggested fix for allowing Google Site Search to work (above) also makes it so sites using HTML5 markup work as well.

Here’s a link the fix again: https://gist.github.com/KZeni/7205026 (just swap out that whole function found in wp-retina-2x.php)

That appears to be introducing more overhead than I’d like when I’d prefer to be able to grant them this one capability (or the import capability as that’s more accurate to the action) instead of having to grant them manage_options & then revoke all of the things that come with that [which change as plugins are added, etc.])

Ok, I was able to rewrite the wr2x_srcset_rewrite function to address this issue. Here’s a link to the code that’s the updated function (really, just swapped out some code once a potential retina is found & then changed it to return the modified buffer… but it’s simpler to just show the updated function as a whole).

https://gist.github.com/KZeni/7205026

This now works after I swapped out this function with the code found in the link above.

Now, I’m not sure of the reasoning behind why things were coded as they were so you might find that there’s a better way to do this, but as it is… this fixes an issue where this was otherwise breaking my site’s Google-powered search.

I’d like to see this (or an equivalent fix) included in a future update to this plugin. I love this plugin, but I need Google search to work. Thanks!

It seems like the only sites I’m having this issue on (and isn’t solved by simply deactivating & reactivating) are those running IIS on a Windows server. Sites running a LAMP setup appear to be working fine. Wonder if this is similar for others.

Deactivating & re-activating the plugin worked for me. Shows as “WP Security” in the bottom group in the site admin menu.

Deactivating & re-activating the plugin worked for me. Shows as “WP Security” in the bottom group in the site admin menu.

Seems there’s a bug in the duplication process where only one of the variants was being stored as a term relationship. I’ve found a fix to this and have submitted a pull request via their GitHub repository: https://github.com/wp-e-commerce/WP-e-Commerce/pull/644

Here’s a link to the (really simple!) patch: https://github.com/KZeni/WP-e-Commerce/commit/0ca11450b85858d791b18c8a2aa5e3ec9227a0a2

Essentially, you just need to go into wpsc-admin/admin.php, find where it calls wpsc_duplicate_children() within the wpsc_duplicate_product_process() function, and move that to be before wpsc_duplicate_taxonomies() and wpsc_duplicate_product_meta(). Turns out the duplicate children process messes it up.

That’s it! The terms will be duplicated properly, and that means the variants should be shown.

Alright, it appears I got the fix I was hoping to find! I’ve proposed the simple fix via GitHub: https://github.com/mikejolley/download-monitor/pull/73

Great! Thanks again, Marco!

https://codex.www.ads-software.com/Changing_File_Permissions shows WordPress’ defaults being 755 for folders and 644 for files.

Great! Thanks Marco!

@bmex63’s edit gets the file to download, but (as Devin Walker mentioned above) it’s downloading a 0 byte CSV when trying to export the 404 log for me. I should mention that exporting the WordPress log works fine (not sure why that might be).