Lee Collings

Forum Replies Created

Viewing 11 replies - 16 through 26 (of 26 total)
  • Thread Starter Lee Collings

    (@leecollings)

    I’m not going to teach you how to develop WordPress plugin, but yes you can.

    Thread Starter Lee Collings

    (@leecollings)

    PS for anyone reading this: This issue is not resolved, and never will be apparently.

    Thread Starter Lee Collings

    (@leecollings)

    I’m sorry, but you are wrong. Plugins should be created so that the widely available features to every developer, still work.

    You cannot just output hard coded script to a page, this should never be done in WordPress.

    I’ve now given you a two star rating because of your attitude, and will be vocally discouraging the use of your plugin.

    Thread Starter Lee Collings

    (@leecollings)

    By default, WordPress enqueues jQuery in the <head> if your theme does not, then it’s been altered, and would be incompatible.

    My theme has not been altered, it’s been developed… by me. I created my theme from scratch. I’ve used the WordPress Developer docs correctly, and have utilised features that are on there to adjust for example the placement of the loading of scripts.

    Nothing that I’m doing is by any means incorrect usage. The fact that your plugin works with out of the box stuff is irrelevant. I’m telling you that your plugin doesn’t work correctly because you’re not correctly enqueuing your inline script, or else this wouldn’t be an issue.

    There is nothing wrong with what I’m doing, and your plugin should be able to work with this, but it doesn’t because you are hard coding echoing out to the page (which is very bad practice).

    What you should be doing is re-working your plugin code so that it correctly loads all of it’s assets (CSS and JS) using the enqueue methods, or you will find that many others will have issues using plugins that optimise the loading of assets, or any other optimisation tools (as these all work on the basis that plugins utilise the correct enqueue procedures).

    The fact you are refusing to do anything proves to me that you are not a confident WordPress developer, and perhaps do not understand enough about the WordPress ecosystem to be bothered enough to fix your plugin.

    I think I’ll just uninstall it then if this is how you think you should be programming.

    Note: I discourage anyone from using this plugin now.

    Thread Starter Lee Collings

    (@leecollings)

    As a follow up from this, I’ve tested by changing my theme to stop loading JS at the footer, and just enqueuing it standard out of the box, and the plugin works.

    So your raw output of <script> tag that sets all of the options, is just being echoed out on the page, and not making use of wp_add_inline_script Which is what you should be using, as you can then always follow the initial jQuery enqueue call.

    I shouldn’t have to revert my theme code to a really simple way of loading in order for this to work. Can you please change your plugin so it correctly enqueues?

    Thread Starter Lee Collings

    (@leecollings)

    I’ve just found out how to do this (although you need to re-write the information because you don’t do a very good job at explaining it).

    I’ve just seen though that you are loading a CSS file, how can I stop this from loading? (Without just overriding what’s in it, I actually want to turn off the enqueueing of it please), you don’t seem to have this option to disable all styling.

    Thread Starter Lee Collings

    (@leecollings)

    Hi,

    Thanks for your response but you probably need to use output buffering in your plugin.. from personal experience, that is what this sounds like.

    I am not nesting the shortcode within another shortcode, I’m using echo do_shortcode(); to output your shortcode in my template files.

    There is no instagram code, it’s a comment for me to know where to place it in future.

    Output buffering may help the plugin place the code where it is intended to be placed. You should read up on this, and always include it in your output procedures: https://wordpress.stackexchange.com/questions/89234/why-is-output-buffering-used-here

    You should also know that because of this issue (like many other people), I’ve chosen to not use the WordPress plugin because I don’t see it as fit for purpose until this issue is fixed.

    Thread Starter Lee Collings

    (@leecollings)

    And additionally, aside from the form not showing in the correct place, if I click the submit button without filling in the email address (which is set as required), I get a fatal PHP error:

    Warning: count(): Parameter must be an array or an object that implements Countable in …\wp-content\plugins\forms-for-campaign-monitor\forms\core\Ajax.php on line 132

    The page itself outputs Code: 108. (Note this seems to happen when the form is displayed incorrectly… On the very few occasions where the form is in the correct place, the AJAX seems to work okay).

    This really needs to get fixed… I even disabled all of my third party assets (Bootstrap and FontAwesome) and moved jQuery to load at the header, and still the issue is here.

    Judging by the low reviews on the plugin, I strongly consider this to be a fault with the plugin itself, and desperately need this looking into today ASAP.

    Thread Starter Lee Collings

    (@leecollings)

    Hi there,

    Thanks for your reply.

    The site currently is locally hosted and not using CloudFlare (neither the plugin or the DNS service itself).

    There are no caching related plugins involved, however I am still experiencing the issue.

    I could share the pages, however as I stated these are locally hosted so you would not have access to them.

    However, like I previously thought, are you using ob_start() in your plugin to use output buffering? It feels like this is the issue here.

    When I view the source, I can see the line ‘<!– Instagram Feed JS –>’ added to the bottom of the page, and then it seems all of your markup is placed underneath this (including the form HTML).

    Thread Starter Lee Collings

    (@leecollings)

    The form is switching back and forth between where I have placed it, and at the bottom of everything when I reload the page, and is very inconsistent.

    Hi, I’ve experienced this the first time I’m using this plugin. I’m using PHP To echo the shortcode of the form exactly where I want it, but this is not where the form is displaying… the form is being displayed underneatht he footer (not inside it) and is below everything, exactly as described here.

Viewing 11 replies - 16 through 26 (of 26 total)