Forum Replies Created

Viewing 1 replies (of 1 total)
  • I found three problems with P2 theme 1.0.3

    (1) There are two shorthand PHP tags. Because my server is “short_open_tag = Off”, a PHP parse error was occur.

    The fix point is below.

    * line 429 of functions.php
    <div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?}?>"....

    should be:
    <div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?php } ?>"

    * line 27 of entry.php
    <div class="postcontent<?php if (current_user_can( 'edit_post', get_the_id() )) {?> editarea<?}?>"...
    shoud be:
    `<div class=”postcontent<?php if (current_user_can( ‘edit_post’, get_the_id() )) {?> editarea<?php } ?>”

    (2) The language resource for ‘Updates from %s’ has double meanings. In archive.php, %s represents time. In author.php, %s represents a person.
    In some language (like Japanese), The translated strings will be different for this resource.
    I suggest using _c() function and conditional resource like below:

    * for archive.php: _c('Updates from %s|month', 'p2')
    * for author.php: _c('Updates from %s|name', 'p2')

    (3) The prologue_navigation() function in function.php does not work with single.php because posts_nav_link() is for multiple posts (not for singuar). But, the prologue_navigation() is located at single.php.
    I suggest remove this, or replace with previous_post_link(), next_post_link().

Viewing 1 replies (of 1 total)