Lovro Hrust

Hi, at this moment this is out of the scope of this project, but I might reconsider it in a near future. The reason for that is because in order to do that, I would have to modify output of core/embed block, youtube variation to also include enablejsapi in URL query parameter to enable javascript to control youtube video. And also, a javascript code should be added which would stop the video on popup closing. This would solve stop playing for youtube video, but not for other embeds, of which each has to be treated separately. If you are proficient in coding, you can do this by yourself, there is a custom event ‘makeiteasy/closeModal’ which fires on popup element when it is closed.

Thank you very much! If you have suggestions to improve something, please write in support or on github.

Also in includes/functions.php
lines 153-170 to:

if ( function_exists( 'mb_strlen' ) ) {

? ?function jr_mt_strlen( $string ) {

? ? ? return mb_strlen( $string ?? '' );

? ?}

} else {

? ?function jr_mt_strlen( $string ) {

? ? ? return strlen( $string ?? '' );

? ?}

}

if ( function_exists( 'mb_strtolower' ) ) {

? ?function jr_mt_strtolower( $string ) {

? ? ? return mb_strtolower( $string ?? '');

? ?}

} else {

? ?function jr_mt_strtolower( $string ) {

? ? ? return strtolower( $string ?? '' );

? ?}

}

To complete fixing problems which WP_DEBUG set to true reports (deprecated function call), in includes/admin.php, line 164 should be changed to this:

? ? ? unregister_setting( ‘jr_mt_settings’, ‘jr_mt_settings’ );

Hi, I believe I solved the problem.
There are default paddings (space inside a frame) on a popup wrapper (outermost element). These paddings were added prior to v1.0, because I think most people would have them as default and not have popup content from border to border like you have. To override this, you have to set paddings on wrapper to zero, and I believe you did, but they somehow got reset with update.
This css should solve the issue:

.wp-block-makeiteasy-popup .makeiteasy-popup-wrapper {
? ?border-radius: 10px;
? ?overflow: hidden;
? ?/* padding to zero */
? ?padding: 0;
}

.wp-block-makeiteasy-popup .makeiteasy-popup-content-wrapper {
   padding-bottom: 14px;
}

In case some of these properties doesn’t work, then it is a problem of order of importance, and put !important after property value, like so: padding-bottom: 14px !important;

If you need further instructions how to insert this css in theme, please write or google this.

I hope this will solve your issue and please leave a review if you are satisfied with plugin!

• This reply was modified 1 month ago by Lovro Hrust.

I inspected html/css on your site, but I was unable to conclude anything. Try following – make a copy of page or the whole database (to revert back if this does not fix things – also make sure that you know how to revert back – if you just make a copy of page, then you would not have to revert database, just upload earlies version, like you obviously did) and after updating plugin resave the pages/posts on which you have popup. This could help, because markup was changed a little and new css may not work properly with old markup. I could only tell more if I see the problem and could inspect the html/css. But I would say it is a small css fix required.

• This reply was modified 1 month ago by Lovro Hrust.

It would be very helpful if you could clone the site and on that clone update plugin. I could solve the problem easier in that way.

Thanks. I’ll check it late today.

I have checked code changes and it is very hard to conclude why this happened without seeing the real example page. My own test popups all show preserved through updates and I allways strive for backwards compatibility. I would say this is a purely css issue, and it might involve something which concerns other plugins you are using which might affect the css/layout of popup. If you can provide example of the page where this is happening, I will assist you with this. If you would rather not provide details publicly, you can contact me directly on email [email protected].

Could you copy here your block settings?

Thank you for your submission.
I’ll try to look into it tomorrow, and if not, then over the weekend.

Acknowledged. I will start improving docs as soon I will find time. Meanwhile, check my other block plugins, like new MakeITeasy slider.

I am glad it worked. Please leave a review if you can!

First, you should set a class or anchor on a button which will open your popup (under advanced menu). Let’s say you’ve given a button a class openme. After this, select popup, choose onclick as a method to open and under selector enter .openme. If you instead of class entered anchor with the same name, then you would enter #openme. Selector is a css way to select an element.

Thank you. Check my other plugins, MakeITeasy popup and MakeITeasy back to top. Hopefully I will soon publish more plugins, I have more of them almost ready. Write which block you would like to see?