lucspe

Hi,

Thanks for your reply.

I sent you a message via you site’s contact form with links to live site and link + httpasswd credentials to a freshly created staging site (everything is the same as live except WP-Swiper has been updated to .30) so you can see the issue yourself.

Hi there.

On the website in we use generateblocks and each slide has a generateblocks container with heading and buttons blocks inside (both of which are generateblocks blocks, not the default ones).

Up to .29 it works fine. Without doing any other change or plugin updates other than WP-Swiper .30 the issue occurs.

I can send you the details of our staging environment via Slack maybe (or whatever method you prefer) and push there the update to .30 so you can see the issue yourself.

Dear Jory,

Thanks for the quick reply.

I will then continue the discussion on the github issue you opened.

You’re welcome. Hopefully this is something you might want to consider adding in the future. But I understand this might not necessarily be a priority.

Hi Jay,

Regarding .pot file, the issue is that some keywords are not included (most notable is esc_html__ which is used in several places in the plugin). If you create the .pot file with WP-CLI I think it should add that, otherwise if you used POEdit, just add the extra keywords to the list.

Also – but that’s really minor because is essentially 1 string at the moment – the Gutenberg block localization is not implemented completely as that requires a few extra steps to work (see here: https://developer.www.ads-software.com/block-editor/developers/internationalization/).

Regarding point 2), at the moment it is my understanding that either you give an editor (or whatever non-admin user) the capability to just manage the bookings or if you want them to be able to manage the scheduling AND – what is most important – the exclusion dates, you have to give them full access to all the options, which doesn’t seem ideal. Or is there a way to give them access only to that “booking schedule section”?

Thanks,
Luca

Sure.

Btw you might want to amend developer’s documentation on your site regarding this as https://doc.fivestarplugins.com/plugins/restaurant-reservations/developer/ still encourages to check the GitHub repo (which as mentioned points to the one from previous developer of this plugin).

Basically the bulk of the issues I have are with translation as not all strings seem translatable, some because are not declared as multilingual (i.e. “Bookings Summary” in the dashboard), some because the .pot file seems incomplete (i.e. esc_html__ is not in the keywords so those strings are not in the .pot file).

Regarding suggestions, here are my thoughts:
1) the default “upcoming” filter would probably work better if it included also today’s bookings and not only future ones.
I know you can filter for TODAY bookings but the feedback I got from my client is that it would be useful for them to see all upcoming reservations (including the ones for same day) at a glance.
That’s 2 lines of code to change if hard-coded, or a bit more complex if one wanted to add an option for it instead of hard-coding it.

2) It would be good in the future to separate the screen where you modify the opening hours filters – especially the exclusion dates – so editors could manage that without having to give access to the rest of the configuration options. (that is – btw – a more complex endeavour and it was not part of the fixes I mentioned in my initial email, but as you asked for suggestions ?? ).

Best regards,
Luca

No problem.

However, as I said, on https://translate.www.ads-software.com/projects/wp-plugins/wp-gallery-enhancer/ it only shows “development” version.

As per FAQ (https://make.www.ads-software.com/polyglots/handbook/frequently-asked-questions/) my understanding is that translations will only be published if a stable version exists.

Hi there.

This indeed would fix the issue on the frontend.

However, in the backend the images still show as stacked as – obviously – the additional CSS is not loaded there.

The best workaround at the moment (until you release the new version) seems to edit those CSS rules directly in the “frontend/css/style.css” file in the plugin folder.

Thanks for pointing me out in the right direction.

Hi, reading this thread I was wondering if then MainWP dashboard cannot run in a setup where it is protected by HTTP Basic Auth or am I misunderstanding this?

hi @duongcuong96,

I am seeing this in debug log on several sites. It is rather annoying and pollutes the log file.

I took a quick look at it and this is what I gathered (sorry, I was really in a hurry so excuse me if the findings below are not 100% correct).

The error is reported at line 2087 of class-job.php, specifically when populate the “manifest” variable, here is the piece of code:

// Add job settings
        $manifest['job_settings'] = array(
            'dbdumptype' => $this->job['dbdumptype'],
            'dbdumpfile' => $this->job['dbdumpfile'],
            'dbdumpfilecompression' => $this->job['dbdumpfilecompression'],
            'dbdumpdbcharset' => $this->job['dbdumpdbcharset'],
            'type' => $this->job['type'],
            'destinations' => $this->job['destinations'],
            'backuptype' => $this->job['backuptype'],
            'archiveformat' => $this->job['archiveformat'],
            'dbdumpexclude' => $this->job['dbdumpexclude'],

        );

However, dbdumpdbcharset doesn’t seem to be defined anywhere in the plugin.

Looking at history of class-job.php on your GitHub repo, it seems that this change has been introduced in 3.6.9.

Hope this helps getting the issue resolved.

• This reply was modified 5 years, 3 months ago by lucspe.

Hi @duongcuong96,

Sure, I understand this is not a priority. It’s ok if you just consider it and also if you decide not implement it. I just proposed it because I think it’s probably useful to other people.

As for Gmail, I am not sure how you would be able to create a filter that would only catch the emails reporting an error and that did not complete the backup and separate them from the emails reporting an error and that did complete the backup.

Hi @duongcuong96,

Sure, I gladly left a 5-star review.

I hope to hear back from you and the devs if you were to consider the change in how notification works. I think it would be really useful.

Regards,
Luca

Hi Daryll,

First of all let me ask to the people I am doing this site for if they want to purchase a paid plugin (I am doing this pro-bono as it’s for friends).

I will get back at you about trying the pro version via PM on Slack eventually.

In general, I would suggest you to add to the description of the pro features the support for inline SVG as it is not obvious that this is handled.

Best,
Luca

Hi Daryll,

Thanks for your reply, and for providing this plugin to the WordPress community.

You wrote that the free version of the plugin does not add this functionality. Does the paid version add inline SVG support? I am asking because I looked on your site and it does not seem to mention that as one of the Pro features.

As for using the IMG tag, that normally would be fine (and worked like a charm on other sites where I installed Safe SVG), but in this case the requirements would be to be able to do some CSS effects on the images, which could only be achieved by inlining the SVGs.

Best,
Luca

I understand your point of view about keeping things simple.

However the point is that – as it stands – the plugin assumes that the footer text is hardcoded into “storefront_footer” action hook.

I believe the use case of moving the footer text after the footer (so hooked into storefront_after_footer) is not uncommon and whilst this can be achieved manually by a developer, I think the overall concept of the plugin is to make managing footer credits easy on the end user.

So it is not an “advanced or overly complicated” modification (as it just adds a select box in customizer so the user can choose whether to place the text in the footer or after) and would make this otherwise very useful plugin a bit more flexible ??

At any rate, case closed. Ultimately, this is your work so I respect your decision.

I just would have preferred to avoid having to mantain a forked version of this for my sites, which is the reason why I approached you in the first place about this ??

Cheers,
Luca