Marko Heijnen
Forum Replies Created
-
Forum: Plugins
In reply to: [Tabify Edit Screen] New release ?The release is scheduled for this friday. All current changes are already uploaded to trunk and applied to the development version you can download.
Forum: Plugins
In reply to: [Tabify Edit Screen] [Plugin: Tabify Edit Screen] WordPress SEO YoastWill be fixed on friday in the 0.4 release. Change is already uploaded to trunk and applied to the development version you can download
Forum: Plugins
In reply to: [Tabify Edit Screen] Tabify not picking up my Custom Post TypesWill be fixed on friday in the 0.4 release. Change is already uploaded to trunk and applied to the development version you can download
Forum: Plugins
In reply to: [Tabify Edit Screen] Tabify not picking up my Custom Post TypesWell looked into it and it was my bad. I fixed it and will release a fix this month. I’m going to try next weekend.
Not sure why I didn’t noticed this behavior sooner.
Forum: Plugins
In reply to: [Tabify Edit Screen] Tabify not picking up my Custom Post TypesIt works for me when I create custom post types by code. Need to check that plugin and play with it.
The only thing I can imagine that show_ui isn’t true. That is the only requirement to show up a post type.
Forum: Plugins
In reply to: [Tabify Edit Screen] New release ?Hey,
Sorry about that. Due to all kinds of things going on with my own business and within WordPress core I didn’t had the time to work on the existing issues in the plugin caused by a redesign. I first need to fix some issues in WordPress core before I’m able to work on this plugin.
This month there will be definitely be a new release. It’s something I’m eager to show but I do want it to be good.
Forum: Plugins
In reply to: [Tabify Edit Screen] [Plugin: Tabify Edit Screen] Metaboxes orderIncluding the metabox file when needed: https://github.com/markoheijnen/tabify-edit-screen/blob/master/inc/plugin-support.php
That file shouldn’t be existing in my plugin and when I got time I hope I can help out developers to get if proper fixed in their plugins
Forum: Plugins
In reply to: [Tabify Edit Screen] [Plugin: Tabify Edit Screen] Metaboxes orderI did fix the issue with Yoast his plugin. It’s most likely you still need to use a filter to enable the fix since the way I fix it is ugly and it’s not my mistake to fix.
The problem is the weird lazy loading what that plugin does and because of that I can’t use the WordPress action (add_meta_boxes) to get all the meta boxes of a post type
Forum: Plugins
In reply to: [Tabify Edit Screen] [Plugin: Tabify Edit Screen] Metaboxes orderIt doesn’t work since it isn’t a feature of this plugin (yet).
It was my own bad. Due the need of having the taxonomy hierarchical I had to pass the term_id as an array and not as a string/int. Also passed only the name but had the ones to term_id but changed it back.
Unfortunately not. It is something on my list. I will try to release an update of the plugin tomorrow and then I start to get some docs online.
Yes that is fine too. I still think the filter ‘tabify_default_metaboxes’ would be the best solution but having a javascript seems a good idea.
Reason why the filter is better is that I don’t add the classes my javascript code tries to manipulate.
I will look into that later today. I can see the issue since it will automatically set the metaboxes that didn’t got added to the list on the last tab if I remember correctly.
There is a filter for that. tabify_default_metaboxes or tabify_default_metaboxes__{$post_type}.
I think calling it from PHP is fine as it is. Doing it with JS/AJAX seems weird to me and also makes it weird when JS is disabled. ( I know this doesn’t really help me ).
I’m thinking to find of a solution that works great and I find it difficult to find one. If it is possible to have the code on ‘add_meta_boxes’ that would help Scott’s first idea to disable location rules when acf_input::validate_page() return false.
If that isn’t possible maybe a filter into acf_input::validate_page() to be able to return true. and then a filter to be able to disable the location rules. This idea seems more complex because of multiple filters
I’m busy with that already on my github repository. The code is now messed up due a rewrite to be able to add tabs on multiple places.
Hopefully I will manage to have a final version by the end of this week.