Matt McFarland
Forum Replies Created
-
Forum: Reviews
In reply to: [Ad King Pro] DB nightmare, no iframes?Hi Ash!
Thanks for your reply ??
Looks like it was indeed the expiry times! If there was away to disable IP logging that would be great. Honestly, what would be really cool (and not harm the DB at all) is logging impressions, clicks, and IP addresses on google analytics. Please take a look at the gist I posted earlier, as it shows impression logging and click logging. To log the IP address one could easily just have php add the IP into an element attribute of the banner “data-ip” for example.
Also, yes flash support keep that, sorry to come across like its terrible ?? It still has good use.
Yeah, what would be better than text support, is iframe support, because someone could create an html file with great styling, animations, etc.
The text banners, whenever I add html to them, they break. So iframe would be great.
Forum: Plugins
In reply to: [WordPress Calls to Action] A landing page is just a landing pageHi David,
Please accept my humble apology, as I sincerely did not mean to come across so aggressive.
I understand you have put a lot of effort into this and it shows. What bothered me was that I wanted to create a popup CTA but only under certain conditions, and the plugin just made it pop up everywhere, considering we get around 10k visits daily it really got a lot of our users angry.
Forum: Plugins
In reply to: [WordPress Calls to Action] A landing page is just a landing pageWhat about a CTA only if someone viewed more than 2 pages and has not logged in?
This is a more non-intrusive way to get more members.
I just hate that you don’t give enough options or flexibility.
So now all I have to do is create a simple js file, make it ajax load different CTA modals depending on php conditions. Prob take me 4 hours to make. I mean, wow. Can you just please make these though? I love most of your plugin, just hate hate hate, the lack of options.
Forum: Reviews
In reply to: [Inline Ajax Comments] Admin Area: works | Storefront: worksI’m not sure what the WP Ajax Edit Comments does, but if you are ajax loading the inline-ajax-comments it wont work unless you use a callback function to stick the scripts to the DOM and execute. I have this fully working.
https://github.com/MattMcFarland/inline-ajax-commentsIn your callback function (if you dont know what this is, it is a function that must run AFTER the form has been ajax loaded) just add ajaxLoadedCallback()
Forum: Reviews
In reply to: [Inline Ajax Comments] Please, make Short CodeHello, I have it working with ajax: https://github.com/MattMcFarland/inline-ajax-comments
Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…I have it fully working
My changes are below:
= 1.2.4.5m =
* Fix: unique target id’s added
* Fix: ajax loading multiple comment lists
* Fix: ajax submit multiple comment lists
* Fix: more/less buttons work on multiple comment lists
* Enhanced: swapped more/less buttons with graphics
* Tweak: More/Less stays on the same line as the input box at smallest browser widths for responsivenessTODO: implement multi-listing wp_nonce functionality.
= 1.2.4.3m =
* Fix: Allow for use ANYWHERE= 1.2.4.2m =
* Fix: Changed “user_nicename” (deprecated) to “display_name”= 1.2.4m =
* Tweak: Changed min-height from 17 to 32You can download it here:
https://github.com/MattMcFarland/inline-ajax-commentsForum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…Ok.. So I now have it working (sorta) So far put about 8 hours into this heh.
Problem 1: comments ajax handle, ‘data-template’ is now returning undefined.
Problem 2: Had to disable wp noonce in template-tags to get it to work.
Can’t seem to find a fix for these issues can you help? It’s almost 100% done!
Please look at my github dev branch, the latest (with problems) is there:
https://github.com/MattMcFarland/inline-ajax-comments/compare/dev?expand=1Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…you can see it working (except ajax submit) on https://www.hvac-hacks.com
Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…Hi zane, I agree.
Please see my latest update on github (dev branch) I’m using id instead of class to keep stylesheet intact.
Also, you can’t use document.submit for multiple posts working
So far I have multiple comment postings reading perfectly fine now and the more / less buttons also work according to plan.
Now to rework the the ajax submit and it’ll be 100% finished.
Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…The problem is that the target needs a unique identifier, I’ll show a fix here shortly.
Forum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…I’m also working on this:
https://github.com/MattMcFarland/inline-ajax-commentsForum: Plugins
In reply to: [Inline Ajax Comments] A few changes needed (u have github?)OK.
I now have it working perfectly.
Fix: now displays user nicknames/display names instead of user-names
Tweak: Made textarea (shrunk) a little bigger 32px instead of 17px
Fix: Now works anywhere (archives, page of posts, etc)Get it here: https://github.com/MattMcFarland/inline-ajax-comments
Forum: Plugins
In reply to: [Inline Ajax Comments] A few changes needed (u have github?)Found you have github, I have forked and created a dev branch:
https://github.com/MattMcFarland/inline-ajax-comments/tree/devForum: Plugins
In reply to: [Inline Ajax Comments] Doesnt work when multiple commentforms on one page…Forgot that get_the_ID returns an INT and we want a STRING..
anyway, it could be done similar to this:
<!-- Get the post id the comment belongs to and change it from int to string "comment_POSTID" --> <?php $cp_id = get_the_ID();?> <?php $comment_post_id = "comment_" . strval($cp_id); ?> <!-- The comments container is now unique --> <div class="inline-comments-container" name="<?php echo comment_post_id ?>">