mattnealstafflink

No worries @ratemyagent , I’m happy to create pull requests/suggestions if you have the plugin somewhere public in Git.

Also, in ReviewCarouselShortcode.php, the $data array receives a null variable in the str_replace() function in the third option ($attrs['heading']). If there is no heading, the plugin doesn’t check for empty. The easiest solution is the same as above, make it null coalescing:

$attrs['heading'] ?? ''

And in context:

$data = [

'carousel_id' => TemplateHelpers::generate_id(6, 'rma-review-'),

'classname' => isset($attributes['classname']) ? $attributes['classname'] : '',

'heading' => str_replace("{reviewCount}", $profile->ReviewCount, $attrs['heading'] ?? ''),

'is_agency' => $is_agency,

'profile_url' => $is_agency ? $profile->RmaAgencyProfileUrl : $profile->RmaAgentProfileUrl,

'reviews' => $reviews,

'rma_url' => UrlHelpers::get_rma_url(),

'show_img' => in_array($attrs['template_type'], ['full', 'no-avatar']),

'hide_agent_details' => in_array($attrs['template_type'], ['no-avatar']),

];

Null Coalescing was introduced in PHP 7.0, so it won’t work with older sites, but the plugin is listed as [email protected] or higher so that shouldn’t matter.

Bumping this topic. I still can’t find the docs…

Thanks Merv!

Thanks for the reply,

After some more digging around, I noticed that it was indeed a bot. I noticed a lot of requests to “autodiscover/autodiscover.xml”, followed by a request to the url “/”, then the warning would appear.

I wasn’t worried about there being an actual issue, but it was just clogging up my logs ??

Thanks!

Issue is with PHP 7.3.5. It works on later versions ??

It’s SUCH a good plugin, and they’ve just left it for dead. How horrible. I’m going to have to stop using it because there’s a bug I can’t get around.