max_Q

Found another issue with the example code: on viewing the form on the front end, I got three errors –
Warning: Missing argument 1 for Torro_Element_Type::get_input_id()
Warning: Missing argument 1 for Torro_Element_Type::get_input_id()
Warning: Missing argument 1 for Torro_Element_Type::get_input_name()

The errors correspond to the lines in the example code inside the get_input_html() function where $this->get_input_id() is called twice and $this->get_input_name() is called once.

I noticed that in your core elements, you are passing an $element argument to each of those functions, as in $this->get_input_id( $element ), but not in the example code. You’re passing in that $element argument when you call the get_input_html( $element ) function.

Looks like you might have to edit the “Register an element” section of https://torro-forms.com/api/using-torro/torro-elements/

It’s calling that same method: torro()->elements()->register( ‘Element_Class_Name’ );

The example code works fine now.

I might suggest adding a “if( function_exists( torro_load ) )” to the “How to add your code” example. If Torro Forms gets deactivated while your custom elements plugin is still active you get a fatal error. Ask me how I know.

Cheers

Version 1.0.0-beta.3

I straight copied and pasted the “Example” code from https://torro-forms.com/api/extending/elements/ into the root of a plugin. Then I wrapped it in the “How to add your code” function (function your_torro_functionality(){}).

As I said, it adds the new element just fine when I change it to call the register() method from the Torro_Element_Types_Manager class (torro()->element_types()->register( ‘My_Element’ );) rather than the Torro_Elements_Manager class (torro()->elements()->register( ‘My_Element’ );) as in the example code.

Any luck getting Revisr to work on GoDaddy?

I’ve installed the latest version, waited a couple of days and I still have 88,170 rows of _yith_ywraq_session_ and _yith_ywraq_session_expires in my options table. Can I look forward to your plugin cleaning this up, or will I have to do it manually?

Looks great. Instantaneous image swapping now. Good job.

The ‘clear selection’ works fine now.

Hey David,

I’m testing the new version and it does hide the gallery images when you ‘clear selection’. Unfortunately, I’m not getting any main image. I see a flash of the normal main default image, then it disappears and in it’s place is it’s title. The source attribute shows src=”undefined?TIMESTAMP”, where TIMESTAMP is, you guessed it, the timestamp. The data-o_href attribute contains the correct href, but src doesn’t.

Marking resolved.

Okay, David, here’s what I think is going on:

I have two attributes for my products, Finish (pa_finish) and Color (pa_color). The particular product I’m using for testing only has Color as an applicable attribute, not Finish.

On line 311 of smart-variations-images.php you assign the variable $variations the value of ‘true’. You then loop through each attribute and use the terms used by the post to create the select control. During the loop, if this particular post doesn’t use any of the terms of the current attribute (as is the case with my test product when looping through the ‘Finish’ attribute) you change the value of $variations to ‘false’. When you do the test ‘if ($variations)’ on line 329 the result is false, and your addition of the Variation Slug dropdown to the form is never created.

The bottom line is, if the product didn’t use at least one term of all of the attributes, no matter that it used some of the attributes, you’ll never see the Variation Slug control.

I propose starting out by assigning the $variations variable the value of ‘false’. Then, during the loop ‘if (!empty($fabric_values))’ on line 318 changing the value of $variations to ‘true’. You would only reach that point if the current post has at least one term of at least one of the attributes. But that’s all it takes, right? Get rid of the ‘else’ section on line 322, as it’s no longer needed. This allows me to see the Variation Slug control.

I’m going to do more testing now.

Regards

Sorry, I can’t. It’s a client site with some proprietary info in the back end.

I like the functionality of your plugin enough to spend some time seeing if I can suss out what’s going on. I’ll let you know what I find. Thanks for your interest.

Regards

Hi David,

All the products are variable products with three variations (colors) and all the attributes (black, brown, white) have been created and assigned.

All the variations have default images, and they show up when you choose a particular attribute (and it’s enabled in your plugin’s settings). Each product has a gallery with maybe twenty images and right now none of the gallery images are showing up because I haven’t been able to find the variation slug dropdown.

Curious, huh?

Another little wrinkle, a database backup I did before the initial commit was also assigned to “Unknown”. It’s the first commit in the list on the Commits page, with the commit message “Backed up the database with Revisr.” It’s now the only commit that still says “Unknown”. I’m using version 1.9.5. Just FYI.

Yeah, me too. I’m not doing anything interesting, just a subfolder install. URLs used to be mapped to subfolder_site.com/post, now they’re of the form main_site.com/subfolder_site/post. Had to go back to 0.5.4.3