Bart McLeod

Ok, now it works. Sorry to bother. Apparently it took some time before the added website was actually active on Googles side.

If debugged a little more and found that a call to dynamic_sidebar() in the footer caused the gallery of the homepage to be loaded. Allthough I can’t do without the dynamic_sidebar() it is good to know where the source of the strange behaviour lies.

Leaving the call to dynamic_sidebar() in place, but removing each and every widget from that sidebar also made the theme work with the plugin.

I have one remark though. My full-size images have watermarks. I would like to show large size images in the modal caroussel.

Another thing: When running the debugger on your plugin (on my custom theme) it runs through your code three times. The first two times if find the correct gallery and the correct images. The third time, it finds the gallery from the homepage and its images and renders the wrong modal caroussel. What could be wrong with my custom theme?

Solved this problem by installing the default Twentyfifteen theme. My bad.

I will probably have to go over my custom theme, to see where I should have put standard WordPress class names and html structures. This plugin makes for a good testcase as to where I should have put these in order to make my theme more compatible.

Yeah, you’re right. I tried to edit my review in a way that would still reflect the original, but couldn’t find a way to make it stand out good between the rest, so there it is, completely changed.

For those interested in what it was like: I thought the plugin made the admin area slow, because a debugger process was hanging in the background. My bad. Totally.

Version 2.1 solves a few problems for WordPress 3.81

I can confirm that my issue with the plugin is also fixed by the update, thanks!

The issues are fixed in version 1.7.3

In a fresh playground environment the cycle widget does work in the sidebar.

I do not know which change of settings or which change in my theme may have caused it to not work the first time.

The 404 on Continue Reading still exists. This is the same for the cycle widget as for the Random Testimonial widget.

The plugin author is right at it to fix this issue.

@mattyrob

It works ok with the core Widget. I suspect that the pro Widget is bypassing the frontend class and using the core class directly, possibly in order to suppress the native shortcode. If that is the reasoning behind it, it should have probably inherited the frontend class and overridden the filter method.

So within the context of your own plugin, this is not a bug. In terms of general compatibiltiy, it is. If you would add the filter function as I suggested, you would not do any harm and still increase general compatibility, which would be a good thing. This is of course entirely up to you, but to encourage you, I will rate your plugin four stars right after this comment. Should you decide to increase the general compatibility I promise to return and give you five stars.

Thanks for all your prompt responses and your patience,

Bart McLeod

ping @mattyrob

I have verified that it the theme is not thinking it is admin, by putting a filter method on the admin class: that doesn’t help.

What does help is putting a filter method inside the core class:

function filter($content) {
    return $content;
}

I suspect that the pro widget is using the core class, which causes this behavior and I would greatly appreciate if you would add this filter method to the core class, because otherwise I have to re-add it each time I update your plugin.

Ok, I see, sorry about the misinterpretation. I would have expected an abstract ‘filter’ method, but that’s probably not compatible enough with php versions WordPress supports. Anyway, tonight, I hope to be able to do some more research.

@mattyrob

“I was of the understanding that sidebars were not supposed to be inside the_loop()”

I was afraid of that. I will experiment with the same side bar outside the loop. It is just with this theme that it’s harder to style to the right position in that case.

btw I’m aware that the widget is not your code, but the widget is not causing the trouble, the filter is.

TESTED: It makes no difference if the sidebar is in the loop. Same behavior if it’s outside the loop. Somehow, the filter is interfering.

Also: s2class does not inherit from any other class and has no filter method. So I still think the filter is invalid.

Edit:
If I add a filter function that does nothing, I do get content of my blog post, but no widget (I think, because the filter does nothing).

@mattyrob

It’s a child theme I’m currently building. It adds a sidebar which is used inside the loop.

The fact that it’s used inside the loop is probably causing this behavior. You can easily reproduce it by printing a sidebar inside the loop on single.php.

On the sidebar I place the subscribe2 widget pro.