Markus Echterhoff
Forum Replies Created
-
Forum: Plugins
In reply to: [You Have a New (BuddyPress) Message] php errorsHi Andrew,
thanks for reporting this issue. Should be fixed in the newest version. Give it a try!
Awesome! Thanks for your patience and help in debugging this problem.
There was indeed a wptexturize call added to the the_title filter hook but for some reason it did not execute under all circumstances, which is why I was unable to reproduce the issue. I think I fixed it for good though. Give version 3.5 a try. The bug has been reported to bbPress a couple of years ago (https://bbpress.trac.www.ads-software.com/ticket/2865) but was still present in the bbPress code I used to create this plugin.
This is interesting! Your database contains the & # 0 3 9 ; typewriter apostrophe, whereas your subject line contains the & # 8 2 1 7 ; typographic apostrophe. If these tests are for the same bbPress topic, it would seem that your theme or some other plugin is running
wptexturize()
on the topic title, possibly via thethe_title
filter.To find out, either debug the code directly if you know how, or switch to a standard WordPress theme and deactivate plugins until you find the culprit. Then I could look into it and provide you with a workaround.
In the unmodified version of your latest reply you have included the entity code for the apostrophe you have used. These forums decode entity codes into their corresponding characters (which is why I also removed an entity code from my previous reply), but it was present in the notification email I got. Comparing both of our now removed apostrophe entity codes I noticed that mine was the typewriter apostrophe ( ‘ ) with code 039 and yours was the typographic apostrophe ( ’ ) with code 8217. The typographic apostrophe should already have been working normally this whole time because it is not a special character!
Perhaps this is an issue with character encoding? Is all of your setup UTF-8 or are some parts working in a different character set?
I have set up a minimal test installation and came up with a rather complicated way to reproduce your problem. If I enter the entity code ( & # 8 2 1 7 ; ) (without the spaces) in the topic title, it is not decoded to the typographic apostrophe in the email subject but shows up correctly on the page. Note that if I enter the character itself, it displays just fine even in the email.
Could it be that you somehow enter html entities to begin with? Do you type the apostrophe yourself or do you copy and paste it from some rich text editor?
If you are entering the typographic apostrophe character regularly, then something must be escaping entities before or after reading the post title from the database. In order to test that, please deactivate everything but a standard theme, bbPress and AsynCRONous bbPress Subscriptions (or create a fresh installation for testing as I did). Does it work then?
If you can access the database with an admin tool, you can also check the following: The column post_title of the topic’s row in the wp_posts table should contain the character ( ’ ) rather than the entity code ( & # 8 2 1 7 ; ) (without the spaces). If the database contains the entity code, it has either been entered as an entity code or was modified before being stored.
The problem could also be the browser, a browser extension, an issue with the webserver or php… but that would seem even more unlikely.
Please give it a thorough testing so we can get to the bottom of this. If we can’t find the cause, we’ll come up with a workaround.
- This reply was modified 6 years, 2 months ago by Markus Echterhoff. Reason: trying to display html entities
Please also make sure that AsynCRONous bbPress Subscriptions is actually active because it would seem the bug is also present in the current version of bbPress. If you disabled my plugin for some reason, apostrophes and other special characters would appear as html entities in email subjects.
I can no longer reproduce the issue. Apostrophes look just fine in email subjects over here.
Could you validate that in your
asynchronous-bbpress-subscriptions.php
line 8 readsVersion: 3.4
and the code in line 108 starts with$topic_title = wp_specialchars_decode(...
? This is what the line looks like if fixed.If that checks out, could you please also validate that no other active plugin or theme use any of the following filters:
abbps_topic_subject
,bbp_forum_subscription_email_subject
, orbbp_forum_subscription_mail_title
? Alternatively, you could test this in a fresh installation running a default theme where the only active plugins are bbPress and AsynCRONous bbPress Subscriptions.Are you by any chance using one of the filters to modify the email subject?
This is a bug. Thanks for reporting it!
I just released an update. Please give the new version a try.
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] admin notificationYou’re welcome.
And yes, this filter allows modifying the list of ABBPS notification recipients prior to scheduling the cron job. If used as described above, the admin notification will be the last email sent when the cron task is executed.
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] admin notificationIn case you have already tried the code I posted above and it didn’t work: I have found a couple of errors and updated my reply accordingly. Try again using the fixed code.
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] admin notificationIf you don’t want to install yet another plugin, a little coding should do the trick.
I would recommend against adding a bcc header to the emails because then this plugin would send you one notification per notified user.
The filter
bbp_subscription_email_recipients
indeed allows you to add the admin to the list of recipients, which would send a notification to the admin for any and all new topics and replies, regardless of whether or not they have manually subscribed. If that is what you want, try adding the following code to your theme’s functions.php:add_filter( 'bbp_subscription_email_recipients', function( $recipients ) { $recipients []= [ 'address' => get_bloginfo( 'admin_email' ), 'name' => 'Admin Name' ]; return $recipients; } );
The code is untested, but it should work. Let me know if it does. ??
- This reply was modified 6 years, 3 months ago by Markus Echterhoff. Reason: fixed code
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] admin notificationThis plugin does not do that. Please search the web for: “admin notification bbpress post” (without the “”). It seems there are currently at least 2 plugin solutions available.
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] 100 is limit for email notificationsNo problem. I am not currently using an email scheduling plugin myself, so I can’t comment on that. Give the old ones a try. If they don’t produce any PHP warnings and the emails get delivered, you should be fine.
Forum: Plugins
In reply to: [AsynCRONous bbPress Subscriptions] 100 is limit for email notificationsHi,
my plugin uses the WordPress internal email function
wp_mail()
to send notification emails. In order to limit how many emails are sent per time, therefore, you can use any email scheduling/queuing plugin for WordPress and it will automatically also queue emails sent by my plugin.