michaelkrieger

you don’t have, use, or need SRI for local assets. It only does this for remote assets.

Careful @loosie94 This is likely to become abandonware, with vague comments that there may be a migration strategy to a third party product linked in some way with a third party hosting platform.

This of course saddens me, as block-lab was pretty much the only clean plugin of its kind without some giant bloated framework associated with it. Moreover, given that all of the javascript is minified, even though it’s technically GPL, it would certainly be a difficult product to fork.

I certainly welcome more insight on what this WP-Engine product may look like to change my opinions.

https://getblocklab.com/the-block-lab-team-are-joining-wp-engine/

Wait! I’ve already built a bunch of things with Block Lab! What do I do?

If you’ve built things with the Block Lab plugin, you have no reason to worry. In fact, you can continue to safely work with Block Lab. As part of our work at WP Engine, we plan on creating a simple migration path that will bring the work you have done already in Block Lab over to what we build at WP Engine. So work with Block Lab now, and then, when the time comes, it will be easy to move over.

Does that mean the existing Block Lab plugin will not be worked on moving forward?

We are committed to providing support, bug fixes, and security patches to the current plugin for a reasonable amount of time, however, we won’t be developing any new features. The work we will be doing at WP Engine will build upon all we have learned building Block Lab and be even better.

• This reply was modified 4 years, 9 months ago by michaelkrieger.

You’re loading the javascript with async/defer.

Yes cf7 should check to see if the function is defined first and retry to accommodate lazy loading of javascript.

async defer was being added to my recaptcha javascript which was causing this error.

Removing the async/defer resolves it.

Please ignore.

Done

https://github.com/meitar/wp-sri/pull/9

Have a look at twentyseventeen theme in inc/icon-functions.php
https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyseventeen/inc/icon-functions.php for a wonderful example of using SVG. It uses them exclusively, which is why I suggest it’s where this plugin should be going.

That said, we don’t need to be this complicated, as this is meant to be general. Just before the </body> we can add the SVG icon.

<svg style="position: absolute; width: 0; height: 0; overflow: hidden;" version="1.1" xmlns="https://www.w3.org/2000/svg" xmlns:xlink="https://www.w3.org/1999/xlink">
<defs>
<symbol
id="icon-pause" viewBox="0 0 24 28">
<path
d="M24 3v22c0 0.547-0.453 1-1 1h-8c-0.547 0-1-0.453-1-1v-22c0-0.547 0.453-1 1-1h8c0.547 0 1 0.453 1 1zM10 3v22c0 0.547-0.453 1-1 1h-8c-0.547 0-1-0.453-1-1v-22c0-0.547 0.453-1 1-1h8c0.547 0 1 0.453 1 1z"></path>
</symbol>
</defs>
</svg>

When you want to use a star, you would then insert the code

<svg
class="icon icon-pause" aria-hidden="true" role="img"> <use
href="#icon-pause" xlink:href="#icon-pause"></use> </svg>

Of course we’d need to replace the star with an actual star image. Lots of royalty-free SVG stars out there, or one can be made in minutes in Illustrator.

This can easily be done with a couple functions.

• This reply was modified 7 years, 1 month ago by michaelkrieger.

Most SVGs in recent wordpress versions are embedded in the page in the footer. There is NO external file call, which Google PageSpeed and others prefer. Fewer dependencies on external resources means faster web sites.

> “so why are you so mad”
Not mad. Just hate to see wordpress plugins that depend on external resources to function correctly or assume a certain environment ahead of time. If it’s an option that can be chosen, I’m completely unaffected by it.

Nooooo! Fontawesome is terrible and using it will add bloat of a whole font versus a small image. WordPress has moved to SVGs added to the footer of the page. If we were to do anything, add a simple star SVG to the footer and refer to it via USE.

FontAwesome is a dependency we don’t need and so many users are moving away from it. Bootstrap 4 dropped icon fonts. WordPress dropped icon fonts. Lots of free star SVG images to choose.

Please use SVG if you’re moving from images and want scalable graphics.

Agreed. This should be an option. I too now define it twice