miketemby

Forum Replies Created

Viewing 15 replies - 1 through 15 (of 45 total)

  • @caseproof backtrace above but let me know if you need anything else. I’ve temporarily changed those esc_html__ references to esc_html to stop it.

    Already did that, but from wp_trigger_error where the error is thrown. 

    [03-Dec-2024 00:11:18 UTC] Array
    (
        [0] => Array
            (
                [file] => /wp-includes/functions.php
                [line] => 6054
                [function] => wp_trigger_error
                [args] => Array
                    (
                        [0] => 
                        [1] => Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>members</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.www.ads-software.com/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.)
                    )

            )

        [1] => Array
            (
                [file] => /wp-includes/l10n.php
                [line] => 1378
                [function] => _doing_it_wrong
                [args] => Array
                    (
                        [0] => _load_textdomain_just_in_time
                        [1] => Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>members</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.www.ads-software.com/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.)
                        [2] => (This message was added in version 6.7.0.)
                    )

            )

        [2] => Array
            (
                [file] => /wp-includes/l10n.php
                [line] => 1408
                [function] => _load_textdomain_just_in_time
                [args] => Array
                    (
                        [0] => members
                    )

            )

        [3] => Array
            (
                [file] => /wp-includes/l10n.php
                [line] => 194
                [function] => get_translations_for_domain
                [args] => Array
                    (
                        [0] => members
                    )

            )

        [4] => Array
            (
                [file] => /wp-includes/l10n.php
                [line] => 339
                [function] => translate
                [args] => Array
                    (
                        [0] => Sorry, but you do not have permission to view this content.
                        [1] => members
                    )

            )

        [5] => Array
            (
                [file] => /wp-content/plugins/members/inc/functions-options.php
                [line] => 144
                [function] => esc_html__
                [args] => Array
                    (
                        [0] => Sorry, but you do not have permission to view this content.
                        [1] => members
                    )

            )

        [6] => Array
            (
                [file] => /wp-content/plugins/members/inc/functions-options.php
                [line] => 119
                [function] => members_get_default_settings
                [args] => Array
                    (
                    )

            )

        [7] => Array
            (
                [file] => /wp-content/plugins/members/inc/functions-options.php
                [line] => 35
                [function] => members_get_setting
                [args] => Array
                    (
                        [0] => explicit_denied_caps
                    )

            )

        [8] => Array
            (
                [file] => /wp-content/plugins/members/inc/functions-users.php
                [line] => 14
                [function] => members_explicitly_deny_caps
                [args] => Array
                    (
                    )

            )

        [9] => Array
            (
                [file] => /wp-content/plugins/members/members.php
                [line] => 209
                [args] => Array
                    (
                        [0] => /wp-content/plugins/members/inc/functions-users.php
                    )

                [function] => require_once
            )

        [10] => Array
            (
                [file] => /wp-content/plugins/members/members.php
                [line] => 95
                [function] => includes
                [class] => Members_Plugin
                [object] => Members_Plugin Object
                    (
                        [php_version:Members_Plugin:private] => 5.3.0
                        [dir] => /wp-content/plugins/members/
                        [uri] => https://some-domain/wp-content/plugins/members/
                        [role_user_count] => Array
                            (
                            )

                    )

                [type] => ->
                [args] => Array
                    (
                    )

            )

        [11] => Array
            (
                [file] => /wp-content/plugins/members/members.php
                [line] => 467
                [function] => get_instance
                [class] => Members_Plugin
                [type] => ::
                [args] => Array
                    (
                    )

            )

        [12] => Array
            (
                [file] => /wp-content/plugins/members/members.php
                [line] => 471
                [function] => members_plugin
                [args] => Array
                    (
                    )

            )

        [13] => Array
            (
                [file] => /wp-settings.php
                [line] => 526
                [args] => Array
                    (
                        [0] => /wp-content/plugins/members/members.php
                    )

                [function] => include_once
            )

        [14] => Array
            (
                [file] => /wp-config.php
                [line] => 105
                [args] => Array
                    (
                        [0] => /wp-settings.php
                    )

                [function] => require_once
            )

        [15] => Array
            (
                [file] => /wp-load.php
                [line] => 50
                [args] => Array
                    (
                        [0] => /wp-config.php
                    )

                [function] => require_once
            )

        [16] => Array
            (
                [file] => /wp-blog-header.php
                [line] => 13
                [args] => Array
                    (
                        [0] => /wp-load.php
                    )

                [function] => require_once
            )

        [17] => Array
            (
                [file] => /index.php
                [line] => 17
                [args] => Array
                    (
                        [0] => /wp-blog-header.php
                    )

                [function] => require
            )

    )

    @cartpauj the issue is being caused by calls to esc_html__

    file] => /members/inc/functions-options.php
    [line] => 144
    [function] => esc_html__

    Thread Starter miketemby

    (@miketemby)

    Doesnt matter what module, anywhere that you select an image from the media library.

    • Selecting background image in any section, row, module
    • Selecting image in Image module
    • Selecting image in any other module that has images.

    They all use an ajax request to load the images from the media library.

    • This reply was modified 1 year, 12 months ago by miketemby.
    • This reply was modified 1 year, 12 months ago by miketemby.
    Thread Starter miketemby

    (@miketemby)

    Do you mean on the Ajax request?

    https://www.mydomain.com.au/wp-admin/admin-ajax.php
    Thread Starter miketemby

    (@miketemby)

    Response
:status: 200
Content-Type: application/json; charset=UTF-8
Access-Control-Allow-Origin: https://www.mydomain.com.au
Expires: Wed, 11 Jan 1984 05:00:00 GMT
Referrer-Policy: strict-origin-when-cross-origin
Cache-Control: no-cache, must-revalidate, max-age=0, no-store
Date: Wed, 29 Mar 2023 00:50:27 GMT
Access-Control-Allow-Credentials: true
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
Vary: User-Agent
x-wp-total: 188
x-powered-by: PHP/7.4.12
x-litespeed-vary: cookie=tsioptions,cookie=tsioptionext
Server: LiteSpeed
x-wp-totalpages: 3
x-robots-tag: noindex
x-litespeed-cache-control: no-cache
    Response
:status: 200
Set-Cookie: et-editor-available-post-1584-fb=fb; expires=Wed, 29-Mar-2023 01:18:51 GMT; Max-Age=1800; path=/; secure
Content-Type: text/html; charset=UTF-8
Cache-Control: no-cache, must-revalidate, max-age=0
Date: Wed, 29 Mar 2023 00:48:54 GMT
Link: <https://www.mydomain.com.au/wp-json/>; rel="https://api.w.org/", <https://www.mydomain.com.au/wp-json/wp/v2/pages/1584>; rel="alternate"; type="application/json", <https://www.mydomain.com.au/?p=1584>; rel=shortlink
Content-Encoding: br
Expires: Wed, 11 Jan 1984 05:00:00 GMT
Vary: Accept-Encoding,User-Agent
Server: LiteSpeed
x-powered-by: PHP/7.4.12
x-litespeed-vary: cookie=tsioptions,cookie=tsioptionext

    First is Response on Ajax request for media library items.

    Second is Response on actual page being edited

    • This reply was modified 1 year, 12 months ago by miketemby.
    • This reply was modified 1 year, 12 months ago by miketemby.
    Thread Starter miketemby

    (@miketemby)

    Report number for this site is: PBPPHJWM

    This issue occurs on all sites using Divi though.

    Thread Starter miketemby

    (@miketemby)

    I don’t have a platform to test Safari/Catalina but according to caniuse, webp is only supported on Big Sur onward with Safari 15.

    “Safari 14.0 – 15.6 has full support of WebP, but requires macOS 11 Big Sur or later”

    Incidentally, I am using BunnyCDN to deliver WebP at the moment and they are able to detect support with Safari 15 where LSCahce does not.
    I asked them how they are detecting it but they are unwilling to share the technical details.

    Thank you for the above. I will leave it for now as I find the BunnyCDN solution to be a lot more streamlined anyway. No need for the QUIC.cloud account, no need to wait for webp generation and no need to store them locally.

    I was testing the LSCache solution to determine what configuration of Cache/CDN provided the best performance. I’m going to leave the caching to LSCache and the image optimisation to BunnyCDN.

    Thread Starter miketemby

    (@miketemby)

    @qtwrk unfortunately, I believe Safari 15 can be installed on older MacOS versions such as Catalina where WebP support does not exist.

    That said, as of 3 days ago, Safari 16 is out and is only available on Big Sur and Montery and has full WebP support without exception.

    So, while it does not address issues with missing support for Safari 15xxx, you can be certain that if Safari version >= 16 it will definitely have support.

    FYI Safari 16.0.0 still does not add image/webp to the accept header ??
    Maybe in 2025…

    In the future MacOS version detection issues may be resolved with Accept-CH: Sec-CH-UA-Platform-Version response header, but as this would only be relevant to subsequent requests, it wouldn’t solve initial WebP support detection for the first request. Safari may not implement it anyway so who knows.

    Thread Starter miketemby

    (@miketemby)

    Wow, the arrogance is so unnecessary but also hilarious given the massive own goal you just scored.

    because only Safari on MAC OS (not Chrome or FF) sets the version number in UA and if version is >13 this has webp support.

    Except it doesn’t work for desktop/laptop, as you finally agree with in your last bullet point, which are the only apple devices that actually use MacOS (as opposed to iOS)

    2) The cache vary to detect the Mac OS version expects iphone and a OS version > 13 to use webp images. This vary is wrong because it doesn’t consider desktop Mac and iPad, so it should be corrected.

    In other words, it doesn’t do as you initially described and in fact my initial statement is entirely correct. Thanks for agreeing and thanks for the totally unnecessary sarcastic, arrogant, rude (and incorrect) response.

    Safari v15.6.1 and MacOS Montery(v12.5.1) has full support for WebP so there appears to be something wrong with the WebP support detection LSCache is implementing.

    Customer service clearly isn’t your strong suit.

    • This reply was modified 2 years, 6 months ago by miketemby.
    • This reply was modified 2 years, 6 months ago by miketemby.
    • This reply was modified 2 years, 6 months ago by miketemby.
    Thread Starter miketemby

    (@miketemby)

    For reference, MacOS Montery is not a ‘special build’ it’s the current MacOS version (12).

    LSCache clearly is not checking the UA header for Safari version as you have described because otherwise, it would work on my MBP which includes the following UA request header (Version/15.6.1)…

    User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.6.1 Safari/605.1.15

    It’s a little reductive to refer to the as my problem. Safari is the second most widely used browser.

    Thread Starter miketemby

    (@miketemby)

    I have been doing that but it doesn’t make a difference.
    I setup the scheduled purge, then purge all in tools, then run the crawler. No cache-control comments.
    I also tried just purge all, then opening the page in browser. No change.

    Thread Starter miketemby

    (@miketemby)

    for the Divi example , it is a good point , I will forward to our devs as feature suggest

    That’s great – thank you.

    crawler does this , as long as there is no purge call happened in the middle of crawling , it will continue to loop through all the pages in sitemap , regardless if it’s cached or expired/purged before crawler starts.

    As i’ve described above a couple of times – this is not my experience. Each time I purge the cache (well before running the crawler), and then run the crawler it hits one page and stops with the error mentioned. In no scenario have I run the purge during the crawl. I am describing the behaviour when purge runs before crawl.

    
Last interval: 44s ago

Ended reason: stopped_reset

Last crawled: 1 item(s)
    • This reply was modified 2 years, 12 months ago by miketemby.
    • This reply was modified 2 years, 12 months ago by miketemby.
    Thread Starter miketemby

    (@miketemby)

    sometimes the first attempt won’t work due to residual data from last time , then click it again should trigger it

    This is a pretty vague response. What residual data specifically? Are you saying there is a bug that causes this that needs to be addressed?

    • If the cache is purged (before it runs), it should crawl it.
    • If the cache is expired, it should crawl it.

    The fact that it doesn’t consistently do that suggests there is a bug. Again, the sole purpose of a crawler is to crawl and therefore cache pages.

    or if page returns x-litespeed-cache-control: no-cache header then marks it as blacklist and bypass it for next time.

    This is highly problematic. I’ll give you a specific example: Divi theme dynamically sets a no-cache header if the Divi css cache has been cleaned out, because the first page load is used to calculate critical css, which is then loaded on the second page load. So Divi sets no-cache header on page load one but does not do so on subsequent page loads.
    The behaviour of the crawler, blocklisting pages as soon as it hits a page with no-cache header, and not crawling them again means it will never cache the pages.
    This function at a bare minimum, should be configurable. I do not want it to blocklist pages when it hits a no-cache header.

    Thread Starter miketemby

    (@miketemby)

    you may need to click “manual run” twice.

    Why twice?
    If it is expired – it should crawl them – that’s the point that I am trying to get you to explain. It doesn’t make sense that it stops the first time and then requires a second run to work. 

        crawler = true
    crawler-usleep = 500
    crawler-run_duration = 400
    crawler-run_interval = 600
    crawler-crawl_interval = 1200
    crawler-threads = 3
    crawler-timeout = 30
    crawler-load_limit = 1
    crawler-sitemap = https://gippsafe.com.au/sitemap_index.xml
    crawler-drop_domain = true
    crawler-map_timeout = 120
    crawler-roles = array (
)
    crawler-cookies = array (
)
Viewing 15 replies - 1 through 15 (of 45 total)