Mikey

Hi Oliver,

When I first run my tests, it was on localhost. However, given your response, I tried on a staging environment and it worked well. Can’t figure it out why it doesn’t work on localhost though.

I will mark this as resolved.

Thank you.

Here’s my step-by-step testing:

1) I enable Offers for all products.

2) I set the Minimum Offer Price, by percentage, 50%. -> https://prntscr.com/mim4o8

3) The product’s meta seems ok -> https://prntscr.com/mim523

4) I go to SHOP to the product which is priced ” 100,00 lei ” (please notice the comma – my national currency format by wc_price) and I make an offer of ” 10 ” (which is automatically transformed in ” 10.00 ” – please notice the dot) – https://prntscr.com/mim5to

The offer goes through without any errors, even though it shouldn’t.

Do you think maybe it has something to do with the price formats?

I’ve noticed that in your last update you’ve inserted wc_price in most places, however I think you missed a few:

– the one in the Make Offer form -> https://prntscr.com/mim5to
– those in backend Manage Offers – Offer Details -> https://prntscr.com/mim6vz

In addition to this issue, there is this one where the Lightbox remains blank and doesn’t close automatically when submitting the offer -> https://prntscr.com/mim7m6

Let’s try to solve this together.

Hey Stanley,

Yes, I know about JS Exclude. But I cannot figure it out which one is the jQuery.datepicker script’s url/file name. The console is not helping the same way it does with .css files.

Can you figure it out from my screenshots? Where do I find the respective file?

Thank you so much.

Later Edit: Btw, Exclude JQuery is ON (in [5]Optimize tab). Shouldn’t this have dealt with the jQuery.datepicker already?

• This reply was modified 6 years, 1 month ago by Mikey.
• This reply was modified 6 years, 1 month ago by Mikey.

Hi Oliver,

I think there’s no confusion. The offer is sent, its status is Pending, and the admin can Accept/Counter/Decline it. I run the latest version of the plugin.

Btw, what is the difference between Minimum Offer Price (by percentage) and Automatically Decline Offers (by percentage)? – please see https://prntscr.com/mhxim5

Because your response seems to be the case for the Automatically Decline Offers option, whilst in case of Minimum Offer Price option there should be something else.

Like I said, in my testing, I’ve only set the Minimum Offer Price (with Offers enabled) and it doesn’t reject, nor do, anything. I was expecting some sort of popup error like “You cannot offer a price lower than $X!” or “Your offer must be higher than $X!”.

Thanks for looking into it.

• This reply was modified 6 years, 1 month ago by Mikey.

Hi, @jmcelhaney,

I’m afraid you misunderstood my question. I am referring to the USER, not the ADMIN.

When the USER goes on my website and has to fulfill a specific form, my business purports a specific situation where the user needs to list on his own one or more things (strictly subjective). Thus, I want him to be able to add as many lines as he needs when fulfilling that list in the form.

After more research on the internet, I found that Ninja Forms does not support this functionality and none of its add-ons as well. Thus, I will have to look for some other forms builder, unfortunately.

@subratamal, awesome.

Thank you.

Oh, why didn’t that come through my mind?! Geez, yes, this would indeed do the trick. And it does. !important is not even required.

Thanks, man!

!important would not work in my case.

Here’s the console, it makes it easier to understand -> https://prntscr.com/maovll

So, as you can see, using wc_price() gives the inner span these 2 classes (<span class="woocommerce-Price-amount amount"> which are the same as for the Product’s Regular Price. Thus, both Regular Price and MSRP will look the same.

Now that I think about it, could it possible be that my theme has somehow customized Woocommerce’s wc_price() function? Otherwise, this would mean that these classes belong to WooCommerce and you should’ve had the same issue in your tests, but you don’t. xD

• This reply was modified 6 years, 2 months ago by Mikey.

This is what I’m trying to explain to you. Using CSS like you suggested is not going to work, because of the wc_price() function. And I can’t figure out how to override that.

It’s like this: <span id="alg_wc_msrp">%msrp%</span>, but %msrp% = wc_price(&msrp);.

Therefore, you cannot change the font-size and color by using an outer rule, because there already is an inner rule given by wc_price().

Yes, I have 1.3.2. And I know the lines are different, that’s why I copy-pasted mine here. I’ve added a few lines and also tried to get rid of the issue described below.

Last time, to solve the issues, I think you added these to the code:

1) `if ( ! empty( $msrp ) ) {
$msrp = str_replace( ‘,’, ‘.’, $msrp );
$msrp = floatval( $msrp );
}`
and
2) '%msrp%' => wc_price( $msrp, array( 'currency' => $currency ) ),

This solved the issue, but it had one flaw that I’ve tried to fix by myself: I didn’t want for %msrp% to inherit the style (font color and size) applied to regular wc prices. I needed to make the two set of prices visually distinct from one another.

So what I basically did was to remove the wc_price() function and just leave it as '%msrp%' => $msrp; and to also remove entirely the 4 lines from point 1) above.

This way the MSRP is displayed as expected, but gives the debug Notices.

Therefore, how can I keep the wc_price() format, but at the same time to be able to style the %msrp% as I please in terms of font-size and color?

Hi @algoritmika,

This issue somehow came back.

Here’s what I get -> https://prntscr.com/maihda

These are the two lines in my class-alg-wc-msrp-core.php:
721) $diff = $msrp - $price;
728) round( $diff / $msrp * 100, $this->options['msrp_display'][ $section_id ]['you_save_round'] ),

Can you please help?

Thank you.

I have disabled it, since the FOUC is way too annoying. I was expecting to see no kind of flashes whatsoever.

In addition, it messes up the format of the products in Shop page (the first row displays only 1 product, out of 2) while on Mobile.

Yep, now it works, after the upgrade to 2.9.

However, there is still a slight FOUC when accessing pages. Can this be completely eliminated somehow?

This is what I get:

01/21/19 13:39:53.434 [93.119.153.4:51260 1 18c] [Media] posting to : https://wp.api.litespeedtech.com/placeholder/681x724?v=2.8.1&c=I2ZmZmZmZg==
01/21/19 13:39:53.922 [93.119.153.4:51260 1 18c] [Media] failed to decode response: <!DOCTYPE html>
<html style="height:100%">
<head><title> 404 Not Found
</title></head>
<body style="color: #444; margin:0;font: normal 14px/20px Arial, Helvetica, sans-serif; height:100%; background-color: #fff;">
<div style="height:auto; min-height:100%; ">     <div style="text-align: center; width:800px; margin-left: -400px; position:absolute; top: 30%; left:50%;">
        <h1 style="margin:0; font-size:150px; line-height:150px; font-weight:bold;">404</h1>
<h2 style="margin-top:20px;font-size: 30px;">Not Found
</h2>
<p>The resource requested could not be found on this server!</p>
</div></div><div style="color:#f0f0f0; font-size:12px;margin:auto;padding:0px 30px 0px 30px;position:relative;clear:both;height:100px;margin-top:-101px;background-color:#474747;border-top: 1px solid rgba(0,0,0,0.15);box-shadow: 0 1px 0 rgba(255, 255, 255, 0.3) inset;">

Report number: DWLKVXKE