Modern Tribe, Inc.

@zzzlumber – this is probably not the place to bring up that debate. But I feel your pain. Honestly, I think WP is the best solution out there for projects where you want to get your hands in there and make something awesome. But I don’t think self hosted wordpress installs is the best if you simply want to get something online and forget about it. If that’s your goal then i would suggest any number of the privately hosted services (including wordpress.com).

Yup!

Cheers!

@ JakePT, We’ve implemented all the bug fixes from your note. Are you down to retest and confirm that all is well?

Thanks!

This is a great idea. We’re going to sneak this in the impending WP 3.5+ support update. We’re also adding a filter called ‘image_widget_link_attributes’ that will work in much the same way that ‘wp_get_attachment_image_attributes’ works so that you can easily insert your own link attributes.

That is super super helpful! Thanks!

@jakept, this is very helpful! Thanks!

Curious about the medium / thumb issue. It was working fine for us. Are you sure that thumb and medium images aren’t defined as the same size as each other in your media settings? When you save the image widget and view on the front end, are you sure that the actual images being called aren’t different? Is it possible that the theme is displaying them the same even though they are actually different sizes?

Love the nit picks. We’ll definitely be adding those updates.

The link url one is a great idea but might wait until a future release since it’s not essential that it happen in this particular update.

Awesome! Thanks!

Hi @ybikov, our mission with this is to keep it as feature lite as possible since many people don’t need that checkbox and may even be confused by it. Instead, we have included a lot of hooks in the code to let you control that sort of thing and possibly even code your own checkbox (though i haven’t tried doing that through hooks so i’m not sure if it might need some patches to make that work).

If you’d like all the links to be rel=”nofollow” then you can simply use the ‘sp_template_image-widget_widget’ filter (or even make an ‘image-widget’ folder in your theme) to make your own version of the views/widget.php file where rel=’nofollow’ is baked in.

I’m open to other suggestions so long as most users don’t have to be faced with superfluous UI. If you’d like other filters in the code, that is up for debate as well.

Cheers!

@alfredo49, honestly, we’re just holding out for a few more people to test. So far, @ dudekpj is the only person who has responded to our request for testers. If we release this with bugs we’ll be inundated with urgent messages. We’d rather be slow to release and release something solid.

Have you tested the new version?

Thanks @dudekpj!

The fact that all the fields don’t update is actually a feature. I’ve heard a lot of frustration around the fields always updating so we changed the js to only update the fields if they are empty.

I’ve updated the typo. Great catch!!!

FYI, no one has submitted any bug reports (aside from @webaware’s comment about SSL filters). For all those folks who have been commenting about wanting this upgraded… it would be very helpful if you could help with testing.

Here’s an idea:

I want to phase out ‘imageurl’ in favor of dynamically getting the image url based on the attachment_id. In the interim, we could lean on the imageurl if it is set and once there is a better filter in place in wordpress we can reverse this and default to attachment id instead.

What do you think?

if ( !empty( $instance['imageurl'] ) ) {
	// If all we have is an image src url we can still render an image.
	$attr['src'] = $instance['imageurl'];
	$hwstring = image_hwstring( $instance['width'], $instance['height'] );
	$output .= rtrim("<img $hwstring");
	foreach ( $attr as $name => $value ) {
		$output .= " $name=" . '"' . $value . '"';
	}
	$output .= ' />';
} elseif ( abs( $instance['attachment_id'] ) > 0 ) {
	$output .= wp_get_attachment_image($instance['attachment_id'], $size, false, $attr);
}

Actually… more broadly, it seems odd that the HTTPS problem wouldn’t already be addressed in the core image code. Any ideas on that?

I’m looking at this… Actually, one thing that’s changed is we’re actually phasing out the imageurl var. So that filter is not really all that practical. Instead we’re using WordPress’s built in function ‘wp_get_attachment_image()’ which uses ‘wp_get_attachment_image_src()’ which in turn uses ‘image_downsize()’.

As such, you should be able to filter core which is probably better to make your code more generalized. I’m not sure what filter is best used in there though.

Hmmm… after looking through image_downsize(), i don’t se a nice obvious place to lay a URL filter.

Ugh.

Not sure what to do here…. I can write this to effectively bypass the WordPress system or we can petition to get a filter added. Bypassing WP will be more reverse compatible and will enable us to continue to support that filter, but will inherently keep this code from being aligned with WP code.

Thoughts?

@webaware – excellent point. I see what you mean about the filter being bypassed.

Honestly, I’d love to have a function in here that seamlessly handles the https problem. I’m more than happy to credit you for it if you want to own that aspect.

In any case, I’ll fix the filters because I’m a huge advocate for filters and definitely don’t want to release this with broken filters!