msmprojects
Forum Replies Created
-
Actually, folks, there’s no need to apply the patch to the Salesforce add on any more, as Mr. Katz has released an update to the plugin that includes it.
Noted in the Gist.
MSM
If you applied both patches, you’d just be causing the break again.
I confirmed with the GF developers that my first patch to GF would probably break other GF add ons. If you applied it, you should revert back to the shipped version. The GF developers are going to amend their developer documentation to indicate proper attribute quote style for add ons.
So, in the mean time, only apply this patch to the latest version of the Salesforce add on plugin, replacing it’s salesforce.php file: https://gist.github.com/1926853
MSM
Also, don’t apply both patches at once. Pick one or the other.
MSM
There is the possibility that my patch to GF might break other GF add ons that also add options to the Advanced settings tab if they don’t use the right quoting around HTML attributes.
If that turns out to be the case, here is a patch for the Salesforce add on that also brings back the option: https://gist.github.com/1926853
This is probably a safer patch. (Oddly, the only change is on line 148 of that file as well.)
I’ll submit this patch to the add on developer. It looks like GF and the add on developers need to agree on single- vs. double-quoting around HTML element attributes.
Also, as far as I can tell, though this option was missing from the Advanced tab, if you had forms that were integrated with Salesforce previously, they remain so and still deliver the form data to Salesforce.
MSM
I had the same problem. Inspected the page and found that there was a JS error in the tooltip added to the Advanced tab on the form settings.
Traced that back to a line in the Gravity Forms plugin’s tooltips.php file, where HTML single-quote vs. double-quote fun was breaking tooltips added by GF add ons.
I’m submitting a patch to the GF developers. In the mean time, if you want to try the patch yourself see https://gist.github.com/1926684 for the patch. The only line that is different from GF is line 148.
That, at the least, restores the option for me.
YMMV,
MSM