John Havlik

You are likely breaking a translation string for Breadcrumb NavXT/adminKit, hence the error. I don’t know what theGP_remove_comments_are_closed_here function looks like, but my guess is you’re returning NULL (or simply failing to return anything) on the Breadcrumb NavXT translation strings. Generally speaking, filters should not break the API (you should not be returning NULL for something that must return a string).

Thanks for reporting this. I was able to reproduce it in my development environment and am tracking it in the following github issue: https://github.com/mtekk/Breadcrumb-NavXT/issues/303. An initial fix has been pushed to the vollyballer branch (development branch for Breadcrumb NavXT 7.4).

Interesting, ultimately, it still sounds like something (MailPoet in this case) is breaking the WordPress API. That said, the function that gets tripped up here is slated to get refactored soonish (next major release), in the meantime, a check is being added to prevent the warning.

I’m tracking this in the following github issue: https://github.com/mtekk/Breadcrumb-NavXT/issues/302

Shortcodes have come up a few times in the years I have been maintaining Breadcrumb NavXT. Traditionally, they are a very poor way to call breadcrumb trails (manually adding them to every page/post that you want a breadcrumb trail is tedious). Now that the block editor exists (with block templates and block themes), it was decided that supporting the block editor with a Breadcrumb Trail block was a much better option. Breadcrumb NavXT can be called using the bcn_display() function, using the Breadcrumb Trail block, or the included widget.

Since shortcodes are on their way to being deprecated within WordPress, the core of Breadcrumb NavXT will not add shortcode support. You can always create your own shortcode in a site specific plugin that calls bcn_display(), there is also an extension to Breadcrumb NavXT that includes a shortcode.

The “Primary Category” feature is not something that is part of WordPress itself (Yoast is adding that). You’ll need extra code to tell Breadcrumb NavXT to use the primary category. You can use the bcn_pick_post_term filter to do this, there are also plugins that exist that allow you to specify what term/category Breadcrumb NavXT uses (Order Bender, and Breadcrumb NavXT Paths).

As for where the breadcrumb trail is showing up on your site, that is likely due to differences in how the theme handles posts and pages. It looks like in both cases the breadcrumb trail is placed below the title, it’s just on posts the title is below the post image while on pages it is above the post image. You’ll likely need to modify your theme/the location where bcn_display() is called within the theme to get the breadcrumb trail where you want.

If you want to wrap your breadcrumbs in <li> elements, you probably want to use the bcn_display_list() function instead of bcn_display(). With this, you don’t need to add <li> elements to your breadcrumb templates.

If you really want to add <li> elements to your breadcrumb templates, you can use the bcn_allowed_html filter to modify what’s allowed. See the following article for an example of how to do this: https://mtekk.us/archives/guides/how-to-add-li-and-other-tags-to-breadcrumb-templates/

This is most likely caused by overly aggressive ModSecurity rules. You will need to work with your webhost to identify the rules causing the problem and adequately adjust them. I expect that the HTML within the breadcrumb templates is causing the overly aggressive rules to trigger.

Breadcrumb NavXT doesn’t include a shortcode (and does not advertise having a shortcode). Breadcrumb NavXT does include a widget, an editor block (Gutenberg block), and there are instructions on how to call the breadcrumb trail using the bcn_display() function (see https://mtekk.us/archives/guides/calling-the-breadcrumb-trail/). If you need help with getting Breadcrumb NavXT integrated with your theme, you should open a support ticket: https://www.ads-software.com/support/plugin/breadcrumb-navxt/

@coriolis_too thanks for digging into this farther. Given the error I was expecting something like this but was lead astray by the line number PHP was giving.

@juliemoynat thanks for fixing the translation and notifying the translation team. I’m not sure why your replies were deleted from the thread, I think they provided important context.

@audrasjb thanks for getting the fixed translation string approved and following up on this. It looks like there may be an opportunity to improve the translation tool and WordPress itself here. WordPress should check for PHP errors when loading a translation package, similar to what it does on plugin activation. Additionally, the translation tool could warn on strings that would cause a sprintf/printf error, the tool already identifies these printf tags in the original string (maybe it could even prevent such a translation from being approved).

There was an error in the French translation distributed by WP.org, it should now be fixed, see https://www.ads-software.com/support/topic/fatal-error-in-class-bcn_breadcrumb_trail-php-on-line-124/page/2/#post-17857542

This one is a bit confusing, that line was not changed in 7.3.1. Additionally, it doesn’t look like the French translation has been updated recently either https://translate.www.ads-software.com/projects/wp-plugins/breadcrumb-navxt/stable/fr/default/?filters%5Bterm%5D=Go+to+the+first+page+of+search+results+for+%25title%25.&filters%5Bterm_scope%5D=scope_any&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

Lastly, I’m not seeing anything in the French translation for the string on the line of the error that should cause a problem (or is even different from the original English or Spanish translation (which I test against locally)). I’m not sure if there is something specific with the server setup (if it is a specific PHP version that causes it), or something I’m missing here.

Can you all check if line 124 of class.bcn_breadcrumb_trail.php is the same as this: https://plugins.trac.www.ads-software.com/browser/breadcrumb-navxt/tags/7.3.1/class.bcn_breadcrumb_trail.php#L124

A very recent thread covered this topic, please my reply in that topic as a starting point: https://www.ads-software.com/support/topic/internal-server-error-on-any-save-attempt/#post-17843965

If that doesn’t solve it, please continue the conversation in this thread.

Based on the error, this is due to an extension plugin to Breadcrumb NavXT not being compatible with Breadcrumb NavXT 7.3.0. There may be a newer version of the extension which needed to be installed before updating Breadcrumb NavXT. Please open a support ticket where you got the extension plugin from (this forum is only for support of Breadcrumb NavXT itselft, I can’t provide support for extension to it here).

Usually this is due to overly aggressive ModSecurity rules, you’ll have to work with your webhost on how to ensure a rule set that is compatible with WordPress is being used. Overly aggressive ModSecurity rules typically don’t like the HTML that is present in the breadcrumb templates.

Double check your Breadcrumb NavXT settings to make sure that the product category taxonomy type is set as the “Hierarchy” for the product post type. Sometimes, the default hierarchy that is selected ends up not being the one you want.