mtinsley

I meant with regards to php-addons, sorry, I’m gonna blame how ganked I was Friday ??

I know the feeling ??

Even with extensions and functions it’s a simple check. The only difference with the code I posted above is that you would have to iterate over each of the required functions or extensions in the readme file, and call function_exists or extension_loaded.

That can be coded into your plugin, to check for PHP version, WP version, etc etc.

I just thought it would be more convenient if the plugin browser notified users of any compatibility issues prior to installing the plugin. This would take some of the burden off of plugin developers.

Since there are so many different implementations of PHP, however, it would be a pretty tall order to put that into Core.

I’m not sure I get your meaning. Once the data is incorporated into the plugin api it would be fairly simple to add a few more checks in addition to the existing WordPress compatibility checks.

For example, this is the code where the wordpress version is checked (plugin-install.php line 341):

if ( !empty($api->tested) && version_compare( substr($GLOBALS['wp_version'], 0, strlen($api->tested)), $api->tested, '>') )<br />
			echo '<div class="updated"><p>' . __('<strong>Warning:</strong> This plugin has <strong>not been tested</strong> with your current version of WordPress.') . '</p></div>';</p>
<p>		else if ( !empty($api->requires) && version_compare( substr($GLOBALS['wp_version'], 0, strlen($api->requires)), $api->requires, '<') )<br />
			echo '<div class="updated"><p>' . __('<strong>Warning:</strong> This plugin has <strong>not been marked as compatible</strong> with your version of WordPress.') . '</p></div>';

Assuming the api is updated to include a minimum php version data point you would just need to add the following to check if you meet the requirement:

<br />
if ( !empty($api->min_php) && version_compare( phpversion(), $api->min_php, '<') )<br />
			echo '<div class="updated"><p>' . __('<strong>Warning:</strong> This plugin has <strong>not been marked as compatible</strong> with your version of PHP.') . '</p></div>';<br />

Unless there is something I’m not understanding it seems like the biggest challenge would be to update the plugin api to include the additional data from the readme, not wordpress itself.

Thanks for reporting the problem, version 1.1 should be out today or tomorrow.

Rather than wait for version 1.1 to be completed I put out a quick release that I hope will address this issue. Version 1.0.2 should be available now.

This issue does not seem to affect every blog; I’m guessing it has to do with your pluign/theme configuration. I haven’t been able to replicate this problem, but I believe I understand what is causing the problem. It will be addressed in version 1.1.

Actually it looks like I jumped to conclusions. On closer inspection of the code it seems like md5 is used as a fallback. phpass will attempt to use blowfish and extended des before using md5 as a last resort.

It seems very unlikely that wordpress would have to resort to md5. Support for blowfish doesn’t depend on PHP, but on the OS. I’m guessing most major OSs support either blowfish or extended des. In addition to this, as of version 5.3 PHP has its own implementation of both of those algos.

Still, since the minimum PHP requirement is 4.3 and provided there won’t be too many side effects it might be a good idea to switch out md5 for sha1.

One of the requirements for this plugin to run is to have the imap functions installed in PHP. Contact your hosting provider regarding this issue.

Sorry for the late reply, I just noticed your comment. I will take a look at that and do my best to work it in for the next version.

Does this apply to manually updating as well? By manual I mean updating my plugin directly from wordpress (not by manually uploading the files). I just tagged the latest version of my plugin and on my test blog when I try to update it says I have the latest version installed (my test blog has the previous version installed with no modifications).

Is this normal?