munikho

I’m sorry for not responding sooner @m_uysl. I checked again and it’s indeed specific to my setup. In my case I had a 2FA login plugin installed which was enabled for admin users, and this was setting the cookie TTL to the session. Which is probably the most secure solution.

For normal users the ‘remember’ flag is kept and login sessions are persistent.

Thanks for the reply!

Hey @abremojo, I’m experiencing the same bug using a different checkout plugin.

It can be fixed by going to wp-content/plugins/packlink-pro-shipping/resources/js/packlink-checkout.js and on line 105 change:

let dropOffId = document.querySelector('.shop_table.woocommerce-checkout-review-order-table' + ' input[name="packlink_drop_off_id"]');
let dropOffExtra = document.querySelector('.shop_table.woocommerce-checkout-review-order-table' + ' input[name="packlink_drop_off_extra"]');

To:

let dropOffId = document.querySelector('input[name="packlink_drop_off_id"]');
let dropOffExtra = document.querySelector('input[name="packlink_drop_off_extra"]');

Hopefully they will change this in their code though, otherwise it will keep breaking each time you update the plugin…

I have the same issue and I see the same error as @jairoochoa.

Besides downgrading, you can also temporarily fix the bug by going to plugins/packlink-pro-shipping/class-plugin.php and on line 394 replace $data_id = $data->get_id(); with $data_id = $data->ID;

That will fix it, but hopefully the plugin authors will fix it in the next version, because otherwise the above changes will be overwritten again when updating the plugin.

I had the same error in combination with the CheckoutWC plugin. This was the original code in /wp-content/plugins/packlink-pro-shipping/resources/js/packlink-checkout.js on line 105.

let dropOffId = document.querySelector('.shop_table.woocommerce-checkout-review-order-table' + ' input[name="packlink_drop_off_id"]');
let dropOffExtra = document.querySelector('.shop_table.woocommerce-checkout-review-order-table' + ' input[name="packlink_drop_off_extra"]');

But .shop_table.woocommerce-checkout-review-order-table doesn’t exist when using the CheckoutWC plugin. So I’ve updated it to

let dropOffId    = document.querySelector('input[name="packlink_drop_off_id"]');
let dropOffExtra = document.querySelector('input[name="packlink_drop_off_extra"]');

And now it works fine.

But Packlink doesn’t seem to be active on this forum, so I’m not sure how to let them know about this issue and potential fix.

I tried it out and it works wonders. Thank you so much for the great work. I love this plugin.

Awesome! Thank you so much for the great work Mustafa. Really appreciated…

Btw… the plugin used to be one of the most time-consuming on our server. Now it’s not anymore: https://ibb.co/wKFD8hx

I saw the get_attachment_id_from_url() function is used in one other place. Since it seems to be an expensive function, I would maybe consider replacing it or finding another way.

Great, thank you @zahardoc! That would be great.

I did just notice a tiny improvement to be made in my code, which is to only set the cache if the filetype is known.

public function get_attachment_mimetype( $attachment = '' ) {
	// Let's hash the URL to ensure that we don't get any illegal chars that might break the cache.
	$key = md5( $attachment );
	if ( $attachment ) {
		// Do we have anything in the cache for this?
		$mime = wp_cache_get( $key, 'mime-type' );
		if ( $mime === false ) {
			// Get the MIME type
			$filetype = wp_check_filetype($attachment);
			if($filetype){
				$mime = $filetype['type'];
				// Set the cache
				wp_cache_set( $key, $mime, 'mime-type', DAY_IN_SECONDS );
			}
		}

		return $mime;
	}

	return false;
}

Great, thank you for fixing this!

Thanks for fixing the H2 markup so quickly in the latest release! Would be great if the settings page could still move as well, but I will be patient ??

That would be great.

Left a review!

Thanks for the update Jason! This has fixed the issue on my side. Thank you very much for the great work.

Wonderful, thank you so much @jason_the_adams!

@karix, that finally fixed it. Thanks so much!

Is there any way to fixing this without changing the give.php file? Or @benmeredithgmailcom and @matheusfd, could this be integrated in the plugin so it doesn’t require manually changing the file each time there is an update?

Thanks!

@samdahl7 do you have access to ftp? You can remove the give plugin through ftp in /wp-content/plugins/give… and then reupload it there.

The donor data is saved in the database, not in the file structure.