Ian Thompson

Specifically I’d like to use the NHS Scotland Logo as per digital assets https://www.nhsscotlandci.scot.nhs.uk/digital-assets/nhs-scotland/

Your Theme is able to upload a Logo, but I cannot seem to fathom out how to do this AND maintain the Site Title and Tagline.

Happy to help make child themes that support the NHS theme in Devolved Nations ??

• This reply was modified 3 years, 9 months ago by Ian Thompson.
• This reply was modified 3 years, 9 months ago by Ian Thompson.

Just found that the word list for the captcha module used with this is fully available for public download.

https://mysite.domain/wp-content/plugins/si-contact-form/captcha/words/words.txt

is open to anyone to download – needs quick permissions change to prevent this, but since the wordlist is out there may need a new word list !

Can any one comment on if this is likely to increase vulnerability of this contact for to mass attack?

I’ve just tested my current install of wordpress 2.9.2 and register plus 3.5.1 and the above fix works for me (ok I did do the patching by hand and did not used patch).
The bit you need to fix is here

<script type="text/javascript">
	function check_pass_strength ( ) {

		var pass = jQuery('#pass1').val();
		var user = jQuery('#user_login').val();

		// get the result as an object, i'm tired of typing it
		var res = jQuery('#pass-strength-result');

		var strength = passwordStrength(pass, user);

		jQuery(res).removeClass('short bad good strong');

		if ( strength == 1 ) {
			jQuery(res).addClass('bad');
			jQuery(res).html( pwsL10n.bad );
		}
		else if ( strength == 3 ) {
			jQuery(res).addClass('good');
			jQuery(res).html( pwsL10n.good );
		}
		else if ( strength == 4 ) {
			jQuery(res).addClass('strong');
			jQuery(res).html( pwsL10n.strong );
		}
		else {
			// this catches 'Too short' and the off chance anything else comes along
			jQuery(res).addClass('short');
			jQuery(res).html( pwsL10n.short );
		}

	}

	jQuery(function($) {
		$('#pass1').keyup( check_pass_strength )
		$('.color-palette').click(function(){$(this).siblings('input[name=admin_color]').attr('checked', 'checked')});
	} );

	jQuery(document).ready( function() {
		jQuery('#pass1,#pass2').attr('autocomplete','off');
		jQuery('#user_login').val('<?php echo $user_login; ?>');
		jQuery('#user_email').val('<?php echo $user_email; ?>');
    });

The problem is that register plus uses javascript to do this feature using the jquery plugin
<script type='text/javascript' src='<?php trailingslashit(get_option('siteurl'));?>wp-admin/js/password-strength-meter.js?ver=20070405'></script>
that clearly comeswith wordpress and for some reason the results returned in statement
var strength = passwordStrength(pass, user);
don’t match with the values stored in pwsL10n.bad pwsL10n.good … etc. I don’t know enough javascript or jquery to work out how to fix this properly. I do know that wordpress includes jquery see (https://digwp.com/2009/06/including-jquery-in-wordpress-the-right-way/) so I suspect the reason register plus is something to do with a change in jquery and or the password strength meter script included in wordpress no longer producing the responses that register plus was expecting.

I have made the following patch file to correct the problem

*** register-plus.php.preedit	Sat Apr 25 02:10:03 2009
--- register-plus.php	Sat Aug 29 16:24:49 2009
***************
*** 1347,1361 ****

  		jQuery(res).removeClass('short bad good strong');

! 		if ( strength == pwsL10n.bad ) {
  			jQuery(res).addClass('bad');
  			jQuery(res).html( pwsL10n.bad );
  		}
! 		else if ( strength == pwsL10n.good ) {
  			jQuery(res).addClass('good');
  			jQuery(res).html( pwsL10n.good );
  		}
! 		else if ( strength == pwsL10n.strong ) {
  			jQuery(res).addClass('strong');
  			jQuery(res).html( pwsL10n.strong );
  		}
--- 1347,1361 ----

  		jQuery(res).removeClass('short bad good strong');

! 		if ( strength == 1 ) {
  			jQuery(res).addClass('bad');
  			jQuery(res).html( pwsL10n.bad );
  		}
! 		else if ( strength == 3 ) {
  			jQuery(res).addClass('good');
  			jQuery(res).html( pwsL10n.good );
  		}
! 		else if ( strength == 4 ) {
  			jQuery(res).addClass('strong');
  			jQuery(res).html( pwsL10n.strong );
  		}

just copy this into a file and then do
patch < patchfilename
on a command line where patchfilename is the name of you saved the patch to. HTH
Ian

this plugin appears to have lost it’s maintainer. this problem has been present for a long time. see https://www.ads-software.com/support/topic/227976?replies=32

nope not an install problems. I also have the problem I think it is a fault with the password strength meter. The problem is RP has not been updated wince wp 2.6.5 and so not all features work properly. see
https://www.ads-software.com/support/topic/247214?replies=3
and more specifically here
https://www.ads-software.com/support/topic/227976?replies=15#post-947093
I think you need to change the codes for the password strength

I think that skullbit has become devbits, it does look like he might be doing some work on a new version … and I would likewise be happy to give another donation if this was confirmed by him.

this should work now as Postie has been updated (1.2) so that it doesn’t grab pluggable.php from register plus.

BIG thanks to Postie Author for that one

OK got a work around for the postie vs register plus issue – rename postie directory to zzz_postie so that it loads last and so the wp_new_user_notification gets defined before postie includes the pluggable.php file. (this sorted the user moderation issue)

can’t get captcha to work on either 2.6 or 2.7.1

I’m having big proboblems with RP in 2.7.1 firstly it says

“You have another plugin installed that is conflicting with Register Plus. This other plugin is overriding the user notification emails. Please see Register Plus Conflicts for more information.”

so I checked out https://skullbit.com/news/register-plus-conflicts/ and I don’t have either of these modules installed.

I did a recursive grep to search for wp_new_user_notification to check that it isn’t in any other modules I have and didn’t find it. I also searched for pluggable.php – and found that the latest version of postie (which I need) is a bad person and includes plugable.php. So I’ll be taking that up with the postie author.

I can’t get the password meter to work even with the hack suggested above.

captcha doesn’t work for me either.

and the user moderation feature doesn’t seem to work either – new users get added strait to the system – though this could be the postie clash above.

Would really welcome and update for 2.7.1

As a follow-up I found that if I deleted the feed_keys row(s) from the wp_usermeta table in phpMyAdmin and then went into user profiles and regenerated the key by ticking the box and updating then the feed keys work.

This applies to both wordpress 2.6.5 and 2.7 (I’ve tested it on both).

N.b. I have “Require Feed Keys” unchecked and “Feed Access” set to “Use Feeds”

I have the invalid feed key problem with 2.6.5 so I’m not sure that it is a 2.7 issue.

I’ve just upgraded to wordpress 2.7 – I’ve found that the bug fix mentioned above and in

https://www.ads-software.com/support/topic/147613?replies=4
https://www.ads-software.com/support/topic/120549?replies=8

has had to be applied to every update of wordpress for quite a while. IT has worked every time before. However this time the above fix doesn’t work and all I get is the RSS feed header as the widget title and no items. Oddly enough the RSS feed in question is coming from another wordpress blog !
https://www.npci.org.uk/blog/index.php?feed=rss2

The html produced looks like this

<li id="rss-2" class="widget widget_rss">
<h2 class="widgettitle">
<a class='rsswidget' href='https://www.npci.org.uk/blog/index.php?feed=rss2' title='Syndicate this content'>
<img style='background:orange;color:white;border:none;' width='14' height='14' src='/wp-includes/images/rss.png' alt='RSS' /></a>
<a class='rsswidget' href='' title=''>National Prescribing Centre Blog</a></h2>
</li>
<li id="rss-214713071" class="widget widget_rss">
<h2 class="widgettitle">
<a class='rsswidget' href='https://www.nhs.uk/NHSChoices/shared/RSSFeedGenerator/RSSFeed.aspx?site=News' title='Syndicate this content'>
<img style='background:orange;color:white;border:none;' width='14' height='14' src='/wp-includes/images/rss.png' alt='RSS' /></a>
<a class='rsswidget' href='https://www.nhs.uk/News/Pages/NewsArticles.aspx' title='RSS Feed for NHS Choices News pages'>NHS Choices: Behind the headlines</a></h2>
<ul>
<li><a class='rsswidget' href='https://www.nhs.uk/news/2009/01January/Pages/Menopauseherbalremedies.aspx' title='The Daily Mail reported today that herbal remedies to treat menopausal symptoms are unproven and could actually damage health. The newspaper said that an independent review by experts has found no strong evidence that herbal remedies such as ginseng, black cohosh and red clover have any effect on the hot flushes, sleeplessness and loss of libido associated w [&hellip;]'>Dangers of herbal cures</a>
<span class="rss-date">14 January 2009</span></li>
</ul>

which as you can see misses the href link and title for the actual feed. Whereas the feed below it displays perfectly.

Any suggestions ?

I’ve just upgraded to wordpress 2.7 – I’ve found that the bug fix mentioned above and in

https://www.ads-software.com/support/topic/147613?replies=4
https://www.ads-software.com/support/topic/120549?replies=8

has had to be applied to every update of wordpress for quite a while. IT has worked every time before. However this time the above fix doesn’t work and all I get is the RSS feed header as the widget title and no items. Oddly enough the RSS feed in question is coming from another wordpress blog !
https://www.npci.org.uk/blog/index.php?feed=rss2

The code produced looks like this

<li id="rss-2" class="widget widget_rss"><h2 class="widgettitle"><a class='rsswidget' href='https://www.npci.org.uk/blog/index.php?feed=rss2' title='Syndicate this content'><img style='background:orange;color:white;border:none;' width='14' height='14' src='https://healthalerts.org.uk/wp-includes/images/rss.png' alt='RSS' /></a> <a class='rsswidget' href='' title=''>National Prescribing Centre Blog</a></h2>
</li>
<li id="rss-214713071" class="widget widget_rss"><h2 class="widgettitle"><a class='rsswidget' href='https://www.nhs.uk/NHSChoices/shared/RSSFeedGenerator/RSSFeed.aspx?site=News' title='Syndicate this content'><img style='background:orange;color:white;border:none;' width='14' height='14' src='https://healthalerts.org.uk/wp-includes/images/rss.png' alt='RSS' /></a> <a class='rsswidget' href='https://www.nhs.uk/News/Pages/NewsArticles.aspx' title='RSS Feed for NHS Choices News pages'>NHS Choices: Behind the headlines</a></h2>
<ul><li><a class='rsswidget' href='https://www.nhs.uk/news/2009/01January/Pages/Menopauseherbalremedies.aspx' title='The Daily Mail reported today that herbal remedies to treat menopausal symptoms are unproven and could actually damage health. The newspaper said that an independent review by experts has found no strong evidence that herbal remedies such as ginseng, black cohosh and red clover have any effect on the hot flushes, sleeplessness and loss of libido associated w [&hellip;]'>Dangers of herbal cures</a> <span class="rss-date">14 January 2009</span></li>
</ul>

which as you can see misses the href link and title for the acutal feed. Whereas the feed below it displays perfectly.

Any suggestions ?

Andrew, thanks for great plugin. But yes I also would like to be able to make most of the blog hidden and have certain pages visible to unregistered users. I’ve tried the WP Members plugin but this is too complicated and isn’t as good as your plugin. Happy to help with testing this feature.