Atanas Yonkov

Hi @jmnly ,

This can be done but I might have hard time justifying it, since I want to keep this plugin as simple as possible and not to flood it with lots of functionalities. Why you would want to show a tour only on mobile?

@bozdoz , @hupe13 , is there any update regarding my comment in the PR?

I can confirm the shortcode is now working and the gallery appears inside the leaflet popup, however, since code gets stripped, when a gallery image gets expanded, the lightbox breaks (you cannot slide to other images from the gallery). Perhaps there can be some workaround to that as well?

• This reply was modified 1 year, 9 months ago by Atanas Yonkov.
• This reply was modified 1 year, 9 months ago by Atanas Yonkov.

@hupe13 , @bozdoz , thank you for the update. I tested it and the gallery is now working, however, the lightbox breaks, as well as some minor styling issues. I issued a PR with detailed information and reproduction steps: https://github.com/bozdoz/wp-plugin-leaflet-map/pull/208

Hi @magdamisiek01 ,

I see you moved on to a different theme but in case anyone still has issues with this, simple css can be the easiest way to remove them. Use the following css code in appearance => customize => additional css:

.entry-meta.taxonomies .cat-links, 
.entry-meta.taxonomies .tags-links {
	display: none;
}

@bozdoz, That works but try adding content from custom post type by using a shortcode, like I try to do. It works but strips html from the_content(), so the only way to get it work with html markup is to remove these two lines and remove the unescape function https://i.imgur.com/hEcR2ul.png (hardcoding an image src won’t work for me, i need to display dynamic content there with image gallery)

My point is, if you provide a hook to modify the above-mentioned function, my issue would be resolved. I do not see why it would be an issue to add a hook and making this plugin a bit more customizable.

Sorry this topic got a bit off, since at the beginning I did not realise the actual problem and the solution I need. I understand it might have been quite confusing for you to understand the issue I am having, so do ask if anything is still not clear.

• This reply was modified 1 year, 9 months ago by Atanas Yonkov.
• This reply was modified 1 year, 9 months ago by Atanas Yonkov.
• This reply was modified 1 year, 9 months ago by Atanas Yonkov.

Actually, the shortcode is not the problem here, maybe I did not explain it correctly in the first place. I have a problem with how add_popup_to_shape functions and I need a way to override it without hardcoding the change in the plugin.

(At the beginning, I was having an issue with shortcode not working inside shortcode but I fixed it by installing the plugin that you recommended.)

The current issue that I have problem with and I would like you to fix are lines 376 and 377 of add_popup_to_shape function, since it is stripping down all html code from the leaflet popup box, while I need to display custom post type content because of design specifications. Image

While I understand the plugin strips all html tags for security reasons, it also leaves us with no way to display html code inside the leaflet message. For example, try to add an image there – it will not work. There needs a way to be able to add custom content in this box but currently it does not seem to be possible.

• This reply was modified 1 year, 9 months ago by Atanas Yonkov.

Hi @bozdoz , any update on this one? Can you provide a way to override the following function:

add_popup_to_shape

I need to implement a design that looks something like this but currently all html tags get stripped, so it is not possible. A hook would be great. Thank you!

@bozdoz , is there a way to remove this without altering plugin files, which I believe is a bad practice? Perhaps having a hook or something that lets you modify the popup?

@bozdoz , can you have a look please? Line 375 in class.leaflet-map.php causes problems (it strips all html tags inside the popup) when using nested shortcode inside [leaflet-marker]

@hupe13 ,
I could not make it work like that but I was able to keep the shortcode html (using the Nested Shotcodes by Outerbridge plugin too) by replacing line 375 from class.leaflet-map.php
echo \"{$shape}.bindPopup(window.WPLeafletMapPlugin.unescape({$message}))\";

with echo \"{$shape}.bindPopup({$message})\";

My shortcode structure looks like this in the cms:

[leaflet-map address="Panhandle, San Francisco" zoom=13 height=878]
[leaflet-marker lat=37.79418967176286 lng= -122.40021432209008 iconUrl="/wp-content/uploads/2022/12/Pin.png"][leaflet-popup id=132][/leaflet-marker]

Any reason that this should strip all html tags? If not, perhaps, you can update the plugin, so this can work out of the box? Many thanks.

• This reply was modified 1 year, 11 months ago by Atanas Yonkov.

@hupe13 , this plugin is allowing me to add a simple shortcode to echo some text but nothing more. I created a shortcode to display custom post type with title, content and gallery shortcode and it works well inside the_content but it is stripping all html tags and disables the gallery shortcode when I try to add it inside the [leaflet-marker]

To my dismay, all the html tags get stripped and the [gallery] shortcode that I use inside my CPT is no longer displayed. This is how the popup html looks for me IMAGE: Popup HTML

I have not tested it but I am pretty sure the Geojson file will also not be able to pass html tags, so I am pretty much stuck at the moment. Any help would be much appreciated.

Hi @guiver01 ,
I think there should be a reason I added this extra check $query->is_category($cat_id) but I do not remember on prima vista. I will test and let you know. What widget causes a problem?

Hi @mediafishcanarias ,
The plugin works with custom post types but you need to do some tweaks. It is explained here: https://www.ads-software.com/plugins/post-order-by-category/#is%20there%20support%20for%20custom%20post%20types%3F

Hi @ashleighgj ,
Redirect between pages and multiple tours are not currently possible but you can tweak this by extending this plugin. See more here.

Hi @akt01 ,
This plugin loads the shepherd.js library that consists of one small minified js file, so I would not worry too much about it. The plugin uses browser localstorage to determine whether to show the tour. Localstorage is not accessible via php, so I do not think there is a way not to load this js file.

I haven’t used intro.js, so I cannot comment on that.

As for the question whether the tour can be triggered via a link, this can be done by extending this plugin.

By the way, contributions to this plugin are always welcome. There is always a room for improvement. If you have any ideas, you are encouraged to create a pull request at the official plugin’s repo.