nwr91
Forum Replies Created
-
You need to re-assign field groups to the Options pages after this update
Forum: Plugins
In reply to: [Object Sync for Salesforce] SQL IssuesWe have already narrowed it down to the Salesforce Sync plugin. The site is not using any other plugin that uses the ActionScheduler library.
The long-running SELECT is probably unrelated, but that still doesn’t explain the multi-100 DELETE FROM statements.
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce updates not pulling throughIt’s currently running on 1.9.9, but still has issues – would staging site access help with debugging?
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce updates not pulling throughCurrent value is Field Label, no change when set to API Name.
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce updates not pulling throughACF hasn’t changed anything that would affect this – I didn’t have access to the admin of the site over the weekend, but there have no new posts since May 22nd – is this when the plugin was last updated? Have the recent changes for V2 been pushed in 1.10?
Around the same time, fields in the Field mapping area have not been loading (https://pasteboard.co/KaO9y7z.png) – Is this related?
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce updates not pulling throughDifferent Salesforce instances (with different callback URLs), but same Salesforce account pulling same object from Salesforce.
It has previously been working fine, and last new post was pulled on 22nd June.
Changes to data on some posts does go through correctly, but not on others, and there have been no new posts since this date although new items have been added to Salesforce.
Since around the same time the Salesforce mapping page does not load fully – inspecting the WP field select option, it’s pulling through ACF fields that are in a different post type which it didn’t do before.
Forum: Plugins
In reply to: [Object Sync for Salesforce] Salesforce updates not pulling throughThere are several custom cron events running on the site successfully every hour (WP Crontrol has been installed since build during March/April to manage these, and is still installed), but ActionScheduler seems to be missing events. The cron has been moved to a server cron, so no longer relies on site hits to run.
Salesforce is also populating 2 sites with identical content (one launched last year and updates correctly).
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????Ah, gotcha. We’ve seen folks distributing commercial themes that actually manually include() plugins from a subfolder within the theme. This not only can cause conflicts with timing (of when the include runs versus the plugins_loaded action, but more dangerously, the theme’s bundled version of the plugin wouldn’t get security updates and such as a normal plugin would.
I’d never do that, although the other developer at work does – not with woocommerce as I know of
Thanks for understanding! I just want to speed up my development process as I create award winning websites which the default templates built in tables do not suffice for more advanced layouts. I’ve spent an extra week worth of development at home re-doing woocommerce templates to fit the style of the site which is why I want to use the plugin, but with the constant updates I’m sceptical about using it with no mention if templates are updated in the release notes.
Would be awesome if you could start including them with the updates so I can use the plugin i made to speed up build time ??
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????There’s a difference between standards when building your own standalone project, and standards when maintaining a public project with a legacy install base
Web Standards are web standards.. end of! has nothing to do with legacy code. Using tables for non tabular data for example.
More advanced cart layouts can be achieved with divs compared to tables which make the cart look rubbish!
Those are point releases, and GitHub makes it easy to see what has changed between versions.
I never edit core files, just the templates which create the front end of a store
Did you cover software versioning and version control systems in your studies? I’m not sure why you’d repeat work modifying templates with each release otherwise.
Not in a module, but on my own and in work, yes. It’s just making sure that any updates to files in the WooCommerce templates directory are updated accordingly.
You mean you bundled WooCommerce in a theme? That’s a pretty bad idea
No, it’s the same as copying the templates directory to the theme folder, but instead it is in a plugin. The same way WooCommerce checks in the theme folder for a woocommerce directory, and using those files before the ones in the WooCommerce plugin.. This one checks in the theme folders woocommerce directory first then my plugin, then woocommerce… like:
Order of checking for templates normally in theme
theme directory > woocommerce plugin
Order of checking for templates in my plugin
theme directory > my plugin > woocommerce
– just an extra step in betweenNo promises! We normally try to maintain backward compatibility, but should some unexpected conflict arise, or some feature enhancement relating to it — do you really want us to pledge to not work on a part of our codebase for a period of time?
No, but the release notes with the updated plugin don’t say which files have been updated, whereas core wordpress does. If it said which template files have been changed I could go into my own version and update it.
Some of it is legacy code.
Legacy code maybe, but stick to the same class naming conventions at least
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????I hope you’re not editing core files…
I’m not that stupid…
I’ve always copied the templates directory into the theme directory and renamed to woocommerceI’ve made a plugin before which checked in the theme directory for a woocommerce folder before using the plugin’s woocommerce directory and then defaulting to the woocommerce plugin itself.
It’s just that WooCommerce has updated so much and I’ve made it in my own time that I just haven’t been able to keep up with the WooCommerce updates. I will update it to the latest Woo templates if I know that the templates will not be updated for a few months
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????It the fact that I bothered to learn in detail about the best practices about web development. Most self-taught developers don’t follow the most basic web standards! They may be the ‘best WordPress developers’ but if the code doesn’t follow standards it’s wrong.
WooCommerce is a good example.. there’s a huge mix of CSS class naming conventions.. is it
class="thisClass"
orclass="this_class"
. yes, both are correct, but choose a standard and stick to it.I’d rather just create a plugin to fix WooCommerce myself, if you can reassure me that nothing will be added that will make me keep updating the plugin as much as WooCommerce updates. It’s literally every 2 days now
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????Are you sure you’re running the latest version of WordPress — 4.3? This is what it looks like for me, even with custom columns added by Yoast SEO:
WooCommerce Products is still messy! Even worse actually
That was an example, I wasn’t suggesting you copy their code verbatim — that would be silly. But the point is, you can treat the cells just as divs if you like in your CSS. Markup as desired.
To allow enough room for titles in the left hand column / pseudo element it would need to be at least 50% leaving hardly any room for the actual cart contents
I get the feeling that you’re very attached to a specific way of doing things, and you’re sticking to your way regardless of any input we may have to offer
I haven’t studied a 4-year degree for nothing.. Tables are bad and unless it is structured as a table, then lists/divs should be used.
Pull requests are always welcome on our GitHub Repository!
I’d probably end up re-writing the whole of the template files ??
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????It the fact that there’s so many updates that creating a plugin to replace the standard woocommerce files seems pointless as I never know when the templates will be updated.
variable.php
is a mess anyway so that needs updating urgentlyForum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????Actually, it hides most of them, and then reveals it when a toggle link is clicked.
No it doesn’t – https://imgur.com/8H5KGxC That looks a mess! 390px wide. Any custom columns that are added don’t get removed
The point being, the ui can be manipulated easily via media queries. You can even prepend column headers per cell into ::before pseudo-elements, as demonstrated here:
https://css-tricks.com/examples/ResponsiveTables/responsive.php
I’ve done that before and you have to have at least 50% width on the pseudo element to make the title spacing worthwhile, which loses valuable space on the screen
I’ve tried to make my own plugin to override the WooCommerce trash that comes as default, but there’s that many ‘updates’ it makes it obsolete the minute I start it. – WHY was there 3 updates in less than a week when they could be bundled into 1 a month
Forum: Plugins
In reply to: [WooCommerce] WooCommerce STILL using TABLES????Yes tables can be made responsive if there isn’t much content in it and it’s pretty much the same length of content.
The edit.php page gets rid of literally everything on the page, something which you don’t want to do on a cart page.