oganianarman

Hey Elena,

Thanks for reply, but it harms performance instead of helping(screentshot where and what I have shared) and SEO too and breaking others js .Your plugin name is optimizer but it harms instead of helping without that changes. And all that changes are fixable taks,they aren’t something that impossible to do, e.g scroll to IntersectionObserver is very easy task that can be done maximum 1 day and will not give any problem with backward compatibility. In any way thanks and hope you will do these changes, because you have very good product.

• This reply was modified 1 year, 11 months ago by oganianarman.

Yes it is loading. The issue simple for understanding.

Using this function(https://developer.www.ads-software.com/reference/functions/wp_editor/) WP tinymce will be loaded and if I use your shortcode(with rich text editor) in the SAME page with that function will be load your tinymce, in a page will be 2 tinymce. Your tinymce will ovwerwrote WP tinymce(e.g https://prnt.sc/eFGL2Cp1KQHT) ,because tinymce is global variable or WP will ovwerwrote your tinymce(dependce from position of script), that is why your plugin should use the same WP tinymce,otherwise they will be overwrote each other.

I didn’t say tinymce.min.js is from your system, it’s from WP(https://developer.www.ads-software.com/reference/functions/wp_editor/ this function load it) and that is the problem you are overwriting it.

I think you don’t understand the issue, WP also is using tinymce>4. Let’s me try again explain.

Where are you loading all these files https://prnt.sc/RHybVV64Nzc4 ?

I am using this( https://developer.www.ads-software.com/reference/functions/wp_editor/) WP standart function to load tinymce(which you should use too).

You are overwriting WP tinymce which is defined here https://prnt.sc/sedcbLxo9kbO and all these files and maybe more https://prnt.sc/KC9rcz6iPk0k not working with your tinymce(skins,quicktags,filemanager,plugins and etc.)

FYI: To do this form https://prnt.sc/9BCYUHqgwfdW I don’t understand why you need tinymce all that you can do with pure js instead of load a very huge js file, it’s work maximum 2-3 days work(I have done it myself which is much bigger than you are using,that is why know )

• This reply was modified 2 years, 8 months ago by oganianarman.

Hey again,

a) WP tinymce is using quicktags, filemanager, plugins loading(for others plugins e.g shortcodes),tinymce theme styling and etc, all of that you are rewritting, that is why it isn’t the same

b) Maybe a plugin/theme also is using tinymce in the SAME page with your rich text editor.

We should use the SAME tinymce(because using 2 tinymces will give conflict nobody can guarntee every function of tinymce will work),but of course you should change it and load it from WP to make your plugin compatibility with others themes/plugins.`

Hey @nextendweb,

I really don’t have time for debats,I can only suggest you instead of writting hacks for plugins/themes or suggesting some plugins to change their code to work with your plugin(https://www.ads-software.com/support/topic/conflict-with-smart-slider-3-output-buffering/), fix your code logic. It’s good plugin and you are good developer,I am sure you can do it. We are using the buffer in a lot of places in our themes(for lazy loading,webp converter,audio,video,css concate and etc.) and we still haven’t had ANY issue with others plugins who are using the buffer.

Hey Again,

Your example isn’t correct

1. ob_start – Our code (has priority is -99999999)

2. ob_start – Your code

and OUR ob_get_clean is working in the last(shutdown hook has 99999999 priority)

BUT your loop will remove it , here is screenshot of buffer handlers(#2 our ,which will be removed in your loop)

https://prntscr.com/vg6kbu

It means the problem in your side.

Hey @nextendweb,

Thanks for response. Did you see the pattern example I shared? I think you misunderstood the logic of buffering.

Let’s say you calling ob_start once,but you are removing others buffers https://prnt.sc/vfq0o2, which doesn’t belong to you(it’s the same if you will open 1 div tag but will close 3 div tag).

You should just use a $varible to calculate how many times you are opening ob_start instead of using count of ob_list_handlers in here https://prnt.sc/vfq0o2 .

Hey Prajakta,

Is there any news for this problem?

Hey Prajakta,

Thanks for response,but you are kidding me))? what means 1 close tag is standard? it’s your standard? Or maybe because this task is difficult for you and you are popular plugin,that is why themes author HAVE TO integrate the code with your plugin?

FYI: You just need to calculate in the header(opened tags) or footter(closed) tags,it’s difficult task,but possible. Css hiding is bad for SEO.

Hey again

I think you don’t understand what I mean.

Let’s say I have a theme

1. header file is <div id=”a”><div id=”b”><div id=”c”>
2. footer file is </div></div></div>

Everything is correct in my theme? yes!

now I am using your plugin and only changing header of my theme,but leaving the footer to load from theme. What I will get 2 unclosed tags. The same if I will use only footer but will leaving the header to load from theme.

Your plugin will not corrupt the page ONLY when I will use both header and footer together.

Hey Prajakta,

Thanks for reply. I saw commit nn guthub only the fixed of 1,but I didn’t see the fix related 2 or it hasn’t been fixed yet?

Hey Prajakta,

do you have an idea how to fix it?

Hey Prajakta,

1. But in your default footer there isn’t any closing tag,it means using your default header and footer,I will get broken html?

2. What if a theme is using in the header multiple div like this <div id=”a”><div div=”b”><div id=”c”> ,it means in the footer there are 3 divs and using only header without or only footer without header, the html can be completly broken