Bjarne Oldrup

Does the problem appear on this page, too? THis is a test page @harmoney kindly generated. This would help a lot. https://mts.demo.cshp.co/wp-org-broken-markup-tags-closing-for-headers-below-minimum/

Yeah, unfortunately it appears to. Checked with checkbot.io, and got these errors:

Line 724, Column 1, Tag must be paired, missing: [ </li> ], start tag match failed [ <li> ] on line 706.
Line 728, Column 6, Tag must be paired, missing: [ </li></li></li> ], start tag match failed [ <li> ] on line 684.
Line 782, Column 1, Tag must be paired, no start tag: [ </li> ]
Line 810, Column 1, Tag must be paired, missing: [ </ul> ], start tag match failed [ <ul> ] on line 799.
Line 866, Column 6, Tag must be paired, no start tag: [ </ul> ]

I won’t have time in the foreseeable future to attempt such a rewrite but found Marc to be entirely open to community contribution PRs on the plugin’s github repo if you do.

Completely understandable, and thank you for your contribution, it is appreciated. This minor flaw, does not break user experience or functionality. Luckily, a missing end tag and browsers be like ???♂? – whatever.

Well isn’t that a nice little treat. Thank you @marckdk!

The Danish translation is a custom translation, that’s true.

Uninstalling PT solves the issues for me. Installing 1.0.9 is also ok. The problem appears to occur when I upgrade to 1.1.0

I will try to see if I can reproduce this on a fresh install tomorrow, with Query Monitor enabled. Stay tuned.

I’m using a combination of PolyLang and LocoTranslate, and have for years. But giving the benefit of the doubt, let’s do the banana test:

Sure thing, on the front end, when Danish is chosen, the “Leave a reply” text is translated as expected:

The English version is still untouched:

So the problem is not that the translation is not kicking in, more than all the comment/reply fields are being translated into Danish with version 1.1.0, even though English is chosen, and the rest of the page is in English:

Uninstalling Performant Translations, or simply reverting to 1.0.9, fixes that, and both the English and the Danish page are shown correctly.

Now if you will excuse me, I have a ?? to clean up ??

Lets get that site health out of the way first ??

` wp-core

version: 6.4.2
site_language: da_DK
user_language: en_GB
timezone: Europe/Copenhagen
permalink: /%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: production
user_count: 3
dotorg_communication: true wp-paths-sizes

wordpress_path: /home/sustain2/oldrup.dk
wordpress_size: 92,41 MB (96899819 bytes)
uploads_path: /home/sustain2/oldrup.dk/wp-content/uploads
uploads_size: 52,15 MB (54685371 bytes)
themes_path: /home/sustain2/oldrup.dk/wp-content/themes
themes_size: 11,82 MB (12391001 bytes)
plugins_path: /home/sustain2/oldrup.dk/wp-content/plugins
plugins_size: 136,80 MB (143440337 bytes)
database_size: 46,30 MB (48545792 bytes)
total_size: 339,47 MB (355962320 bytes) wp-dropins (2)

fatal-error-handler.php: true
object-cache.php: true wp-active-theme

name: Blocksy (blocksy)
version: 2.0.22
author: CreativeThemes
author_website: https://creativethemes.com
parent_theme: none
theme_features: widgets-block-editor, automatic-feed-links, responsive-embeds, html5, title-tag, custom-logo, lifterlms-sidebars, boostify-header-footer, fl-theme-builder-headers, fl-theme-builder-footers, fl-theme-builder-parts, editor-styles, editor-style, editor-color-palette, editor-gradient-presets, post-thumbnails, menus, align-wide, customize-selective-refresh-widgets, header-footer-elementor, disable-custom-font-sizes, disable-custom-colors, disable-custom-gradients, widgets
theme_path: /home/sustain2/oldrup.dk/wp-content/themes/blocksy
auto_update: Disabled wp-themes-inactive (1)

Twenty Twenty: version: 2.5, author: the WordPress team, Auto-updates disabled wp-plugins-active (31)

Accessibility Checker: version: 1.7.1, author: Equalize Digital, Auto-updates enabled
Accessibility Checker Pro: version: 1.5.2, author: Equalize Digital, Auto-updates disabled
Activity Log: version: 2.9.0, author: Activity Log Team, Auto-updates disabled
Admin Columns: version: 4.6.1, author: AdminColumns.com, Auto-updates enabled
All-in-One WP Migration: version: 7.79, author: ServMask, Auto-updates disabled
Antispam Bee: version: 2.11.5, author: pluginkollektiv, Auto-updates enabled
Asset CleanUp: Page Speed Booster: version: 1.3.9.3, author: Gabe Livan, Auto-updates disabled
Blocksy Companion (Premium): version: 2.0.22, author: CreativeThemes, Auto-updates enabled
Clean Image Filenames: version: 1.4, author: Upperdog, Auto-updates enabled
Content Aware Sidebars: version: 3.19.3, author: Joachim Jensen - DEV Institute, Auto-updates disabled
Embed Privacy: version: 1.8.1, author: Epiphyt, Auto-updates disabled
EWWW Image Optimizer: version: 7.2.3, author: Exactly WWW, Auto-updates disabled
Exclude Image Thumbnails From UpdraftPlus Backups: version: 1.0.3, author: Dream-Encode, Auto-updates enabled
GenTime: version: 1.1.0, author: Sybre Waaijer, Auto-updates disabled
Lightbox for Gallery & Image Block: version: 1.13, author: Johannes Kinast [email protected], Auto-updates disabled
LiteSpeed Cache: version: 6.0.0.1, author: LiteSpeed Technologies, Auto-updates enabled
Loco Translate: version: 2.6.6, author: Tim Whitlock, Auto-updates enabled
MRW Simplified Editor: version: 2.12.1, author: Mark Root-Wiley, Auto-updates disabled
Performant Translations: version: 1.0.9, author: WordPress Performance Team (latest version: 1.1.0), Auto-updates disabled
Polylang: version: 3.5.3, author: WP SYNTEX, Auto-updates enabled
Real Custom Post Order: version: 1.3.79, author: devowl.io, Auto-updates disabled
Simple Local Avatars: version: 2.7.7, author: 10up, Auto-updates enabled
SimpleTOC - Table of Contents Block: version: 6.2.0, author: Marc T?nsing, Auto-updates disabled
The SEO Framework: version: 5.0.3, author: The SEO Framework Team, Auto-updates enabled
The SEO Framework - Extension Manager: version: 2.6.3, author: The SEO Framework Team, Auto-updates disabled
UpdraftPlus - Backup/Restore: version: 1.23.16, author: UpdraftPlus.Com, DavidAnderson, Auto-updates enabled
User Switching: version: 1.7.2, author: John Blackbourn & contributors, Auto-updates disabled
Wordfence Security: version: 7.11.1, author: Wordfence, Auto-updates enabled
WPCodeBox 2: version: 1.0.3, author: WPCodeBox, Auto-updates disabled
WP Htaccess Editor: version: 1.71, author: WebFactory Ltd, Auto-updates enabled
WPIDE - File Manager & Code Editor: version: 3.4.7, author: XplodedThemes, Auto-updates disabled wp-media

image_editor: EWWWIO_Imagick_Editor
imagick_module_version: 1809
imagemagick_version: ImageMagick 7.1.1-19 Q16-HDRI x86_64 21601 https://imagemagick.org
imagick_version: 3.7.0
file_uploads: 1
post_max_size: 50M
upload_max_filesize: 50M
max_effective_size: 50 MB
max_file_uploads: 20
gd_version: 2.3.3
gd_formats: GIF, JPEG, PNG, WebP, BMP, AVIF, XPM
ghostscript_version: 9.25 wp-server

server_architecture: Linux 3.10.0-962.3.2.lve1.5.81.el7.x86_64 x86_64
httpd_software: LiteSpeed
php_version: 8.2.14 64bit
php_sapi: litespeed
max_input_variables: 3000
time_limit: 90
memory_limit: 256M
max_input_time: 90
upload_max_filesize: 50M
php_post_max_size: 50M
curl_version: 7.87.0 OpenSSL/1.1.1w
suhosin: false
imagick_availability: true
pretty_permalinks: true
htaccess_extra_rules: true
current: 2024-01-30T19:32:37+00:00
utc-time: Tuesday, 30-Jan-24 19:32:37 UTC
server-time: 2024-01-30T20:32:36+01:00 wp-database

extension: mysqli
server_version: 10.6.16-MariaDB-cll-lve
client_version: mysqlnd 8.2.14
max_allowed_packet: 268435456
max_connections: 800 wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /home/sustain2/oldrup.dk/wp-content
WP_PLUGIN_DIR: /home/sustain2/oldrup.dk/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: true
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: production
WP_DEVELOPMENT_MODE: undefined
DB_CHARSET: utf8mb4
DB_COLLATE: undefined wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable pll_options

browser: 0: Detect browser language deactivated
rewrite: 1: Remove /language/ in pretty permalinks
hide_default: 1: Hide URL language information for default language
force_lang: 1: The language is set from the directory name in pretty permalinks
redirect_lang: 0: The front page URL contains the page name or page ID instead of the language code
media_support: 0: The media are not translated
sync:
0: comment_status
1: ping_status
2: sticky_posts
3: post_date
4: menu_order
5: _thumbnail_id
post_types: post, page, wp_block, ct_content_block, epi_embed
taxonomies: category, post_tag
version: 3.5.3
default_lang: da
menu_1: da => 6 | en => 33
menu_2: da => 0 | en => 0
menu_3: da => 0 | en => 0
footer: da => 0 | en => 33
footer_2: da => 0 | en => 0
menu_mobile: da => 6 | en => 33
menu_mobile_2: da => 0 | en => 0
previous_version: 3.5.2 pll_language_da

name: P? dansk
slug: da
term_group: 0
term_id: 17
locale: da_DK
is_rtl: 0
w3c: da-DK
facebook: da_DK
home_url: https://oldrup.dk/
search_url: https://oldrup.dk/
page_on_front: 5099
page_for_posts: 0
flag_code: dk
flag_url: https://oldrup.dk/wp-content/plugins/polylang/flags/dk.png
custom_flag_url: 0
active: true
fallbacks: 0
is_default: true
term_props:
language/term_id: 17
language/term_taxonomy_id: 17
language/count: 53
term_language/term_id: 18
term_language/term_taxonomy_id: 18
term_language/count: 5 pll_language_en

name: In English
slug: en
term_group: 0
term_id: 20
locale: en_GB
is_rtl: 0
w3c: en-GB
facebook: en_GB
home_url: https://oldrup.dk/en/home/
search_url: https://oldrup.dk/en/
page_on_front: 5108
page_for_posts: 0
flag_code: gb
flag_url: https://oldrup.dk/wp-content/plugins/polylang/flags/gb.png
custom_flag_url: 0
active: true
fallbacks: 0
is_default: 0
term_props:
language/term_id: 20
language/term_taxonomy_id: 20
language/count: 20
term_language/term_id: 21
term_language/term_taxonomy_id: 21
term_language/count: 5 pll_warnings

wpml:
plugins/content-aware-sidebars: /home/sustain2/oldrup.dk/wp-content/plugins/content-aware-sidebars/wpml-config.xml
plugins/autodescription: /home/sustain2/oldrup.dk/wp-content/plugins/autodescription/wpml-config.xml
themes/blocksy: /home/sustain2/oldrup.dk/wp-content/themes/blocksy/wpml-config.xml

@maltmann, a pragmatic workaround is also to wait inserting the TOC until when you are done editing. I’ve put the TOC block in a group container for a background colour, and saved it as a pattern, so inserting it after editing is quickly done.

If I’m doing a major edit, I might even delete the existing TOC, make my edits, and insert it back in. It is not perfect, but I still prefer SimpleTOC over the other solutions I tried.

Uhm, okay, I just spent hours fiddling with this embed source, and now it works, I’d like to share what I learned – as it was a bit confusing.

Embed Privacy has a Background option for each Embed source. This can be used for a generic thumbnail, when a “dynamic” thumbnail, like YouTubes isn’t available. Yet, at least.

To set a background image for the video’s found on WordPress.tv, you must edit the background of the VideoPress Embed – as the URL given by the Share button on WordPress.tv, actually points to VideoPress (which it also says in the block editor, to be fair.) Sample below.

Don’t, like me, get too confused by the Learn.www.ads-software.com url in the video thumbnail, nor that the video is actually served from video.wordpress.com ??
Do make sure you are editing the Embred Privacy embed settings for the correct language, otherwise your edit’s won’t kick in ??

I still desire the dynamic thumbnails from WordPress.tv aka VideoPress would be fetched at some point. But for now, my edited default background does an ok job, since I only plan to share videos with the blue learn.www.ads-software.com thumbnail (title removed) anyways. I’m therefore marking this as resolved.

Just confirming that, too. Have been using Loco Translate since WP 6.4 release on multiple sites. Works perfectly.

Thank you, Tim, for this invaluable plugin.

Thanks for the clarification @davidanderson, much appreciated.

I guess, Wordfence has no way of identifying why a plugin was pulled from www.ads-software.com, and therefore just pins the “critical” label on it. A bit oversensitive, maybe.

Glad it was a false alarm. And yeah, the timing of enforcing policies does smell a bit fishy.

Happy holidays to everyone who does that, and a nice weekend to everyone else ?????

100/100 score in Google Lighthouse, and no errors in W3C’s HTML validator now – that’s a fine little Christmas present right there.

Thank you!

The longer autosave interval is adequate for me. Resolved.

Acknowledged. Duplicate headlines on a page aren’t great in the first place. I’ll wet my content ??

@kittmedia, thank you so much for trying. Good call, avoiding hacky manual replacements, that would likely break down the road.

I have one more trick up my sleeves. My caching plugin offers to combine inline CSS in a separate file. That usually gets the job done, although I have to look out for specificity issues when doing that. WordPress itself also outputs styling as a child to a div, so that needs to be taken care of anyway – if validation is important to the project. I’ll go that route, when it makes sense. Thank you for your time, and this fine plugin. I look forward to trying it out in a real project.

Bjarne

There’s also the compromise, to reduce the frequency of autosave. That is really a matter of preference, but I found that for me, a 10-minute interval is just fine. This can be set with this snippet:

if ( ! defined( 'AUTOSAVE_INTERVAL' ) ) {
    // Change 600 to the number of seconds you prefer (10 minutes in this example).
    define( 'AUTOSAVE_INTERVAL', 600 );
}

I’ll do some editing with that setting; experiencing if the “jump” still affects my workflow.

So here’s what I settled on; MRW Simplified Editor remains enabled for admins (me). I’m personally not interested in applying inline styling to blocks anyway, it’s a maintenance nightmare and not scalable. It’s ok for prototyping a pattern, but once the layout is done, I move the styling to a proper style sheet, and apply a class to the pattern. That’s reasonably robust and paves the road for a client-friendly workflow.

So that means I only need to hide additional stuff for, say, editors. That’s easily done using the small snippets discussed – and – I can conditionally run these snippets depending on user role and whether one is logged in.

Most (premium) tools for adding code snippets to WordPress, feature a UI to create such conditionals. Screenshot from the tool I use to run snippet if user has the editor role:

If using free tools to add snippets, the condition can be built with a line of PHP, so that’s doable – I’m just using the tools I have.

Thanks again! Your plugin really helps to create a simpler editing experience ??