PaulH

I’ve applied the update this morning (July 2nd) and I’m awaiting confirmation from my client.

Any update on this issue being fixed. Time is running out before SagePay discontinues protocol 2.23.

Just had an email from my client (after I’d updated the plugin to 2.3) and they aren’t getting the order email from the website now. They got the SagePay confirmation email but it seems like the final process isn’t working.

I’ve had to revert the plugin back again for the time being.

I hadn’t noticed a new version being released. I’ve just downloaded and installed and this time it is working ??

Can I ask what specifically was changed because when I attempted your fix above (line 222 change) it just made matters worse.

I replaced the line and gave it another try, now it’s complaining about a missing currency field, so I’m guessing that has caused more problems:

VSP Form Transaction Error
This transaction attempt has failed. We are unable to redirect you back to the web store from which you were purchasing. The details of the failure are given below. 

Status:
MALFORMED

Status Detail:
3045 : The Currency field is missing.

Just downloaded and tried out version 2.2 of the plugin and it still doesn’t work.

I’m getting an error at Protx (SagePay):

VSP Form Transaction Error
This transaction attempt has failed. We are unable to redirect you back to the web store from which you were purchasing. The details of the failure are given below.

Status:
INVALID

Status Detail:
3087 : The SuccessURL format is invalid.

No worries. SagePay is discontinuing protocol 2.23 in July so we’ll need the update by then – plenty of time ??

Any update on this?

I compared the code from v2.0 and v2.1 and the only change I could see (excluding variable and function renames) is the change of the sagepay protocol number from 2.23 to 3.00.

As I haven’t been able to download v2.1.1 I don’t know what additional changes were in there.

I presume you’re after the System Info from the Jigoshop plugin page:

### Begin System Info ###

	Multi-site:               No

	SITE_URL:                 https://emptybox.co.uk
	HOME_URL:                 https://emptybox.co.uk

	Jigoshop Version:         1.15.4
	WordPress Version:        4.2.1

	Platform:                 Windows
	Browser Name:             Chrome
	Browser Version:          43.0.2357.45
	User Agent String:        Mozilla/5.0 (Windows NT 6.3; Win
                                  64; x64) AppleWebKit/537.36 (KHT
                                  ML, like Gecko) Chrome/43.0.2357
                                  .45 Safari/537.36

	PHP Version:              5.4.25
	MySQL Version:            5.5.42
	Web Server Info:          Apache

	eAccelerator:             Disabled
	APC:                      Disabled
	OpCache:                  Disabled

	PHP Memory Limit:         256M
	PHP Post Max Size:        20MB
	PHP Upload Max File Size: 20MB
	PHP Max Input Time:       60
	PHP Max Input Vars:       1000
	WordPress Memory Limit:   64MB

	Short Open Tag:           Enabled
	Allow URL fopen:          Enabled

	WP_DEBUG:                 Disabled
	WP Table Prefix:          Length: 8 Status: Acceptable

	Show On Front:            page
	Page On Front:            2990
	Page For Posts:           3307

	Session:                  Enabled
	Session Name:             PHPSESSID
	Cookie Path:              /
	Save Path:                /tmp
	Use Cookies:              On
	Use Only Cookies:         On

	DISPLAY ERRORS:           On (1)
	FSOCKOPEN:                Supported

	ACTIVE PLUGINS:

	Category Order and Taxonomy Terms Order: 1.4.1
	Cimy User Manager: 1.4.6
	DLynx Cookie Law: 1.0
	DLynx Forms: 1.0
	DLynx Framework: 1.2
	Easy Updates Manager: 5.0.0
	EG-Archives: 2.0.2
	Google Analytics Dashboard for WP: 4.7.1
	Google XML Sitemaps: 4.0.8
	InfiniteWP - Client: 1.3.12
	iThemes Security: 4.6.13
	Jigoshop: 1.15.4
	Jigoshop - Up-sells/Cross-sells: 1.4.1
	Jigoshop PayPal Express Checkout Payment Gateway: 2.1.4
	Jigoshop Product Add-ons: 1.19.1
	Jigoshop Sagepay Form Gateway: 2.0
	Jigoshop Table Rate Shipping: 3.3.3
	Jigoshop Wishlist: 1.1.1
	Lockdown WP Admin: 2.2
	MCE Table Buttons: 3.2
	Post Types Order: 1.7.7
	PS Auto Sitemap: 1.1.8
	Responsive Lightbox: 1.4.10
	Share Buttons by AddToAny: 1.5.6
	Simple Trackback Validation with Topsy Blocker: 1.2.4
	Theme My Login: 6.3.11
	User Submitted Posts: 20150319
	W3 Total Cache: 0.9.4.1

The currently installed version of the Sage Pay plugin works fine, the latest 2.1 returns the invalid successUrl error. For some reason the download link we have doesn’t offer the 2.1.1 download.

I found out that I also needed to duplicate and rename all the functions mentioned in this action (add_header_info, etc) as the function would be called without access to the jigoshop ones. Once I’d done that the new action started to work.

I should be able to work out the rest of what I need now.

So, is my code correct? It doesn’t look like it is working and as this is a live site I can’t debug it as well as I’d like.

The main thing I want to check is that the parameter $orderId will be passed through using the hook as I think it is.

Thanks.

Update: It turned out that JigoShop doesn’t play nicely with Root Relative URLs. I disabled that now the site is live and PayPal Express is working OK.

I think i’ve found a quick way of adding it in myself:

add_action( 'jigoshop_after_email_order_info', 'add_coupon_code_email', 10000, 1 );
function add_coupon_code_email( $orderId ) {
	$orderData = get_post_meta( $orderId, 'order_data', true );
	$discounts = @$orderData->order_discount_coupons;
	$codes = "";
	foreach($discounts  as $discount){
		$codes .= @$discount->code . ", ";
	}
	echo "Discount Code Used: $codes". PHP_EOL. PHP_EOL;
}

The @ are to prevent errors showing up for the moment as the site is live. Not ideal I know but the client wants the information in the order email as they don’t want to log into the admin to check on the order!

That is what I thought, I just really didn’t want to have to do that as it will hamper updating the plugin in the future.