Jason Crist
Forum Replies Created
-
Thank you for the report @radgh. We released a new version just a short bit after you reported this. Would you mind trying again on the newest version? I’m not sure that anything font-related (as the error response seems to point to) was tinkered with, but something related may have fixed the issue.
Hrm. This is interesting, I’ve not seen this error before…
<?php echo __('Contact', 'fse <?php echo
That “double <?php” is causing some errors, though I’m not sure how it would have happened.
You should be able to change this:
<?php echo __('Contact', 'fse <?php echo __('freshsnow', 'fsefreshsnow');?>');?>
to this:
<?php echo __('Contact', 'fsefreshsnow');?>
to fix the error. (assuming your theme slug is ‘fsefreshsnow’ which I’m not clear about considering how it was mangled) However I wasn’t able to reproduce the error you described myself. If you have any additional thoughts on how we got there I’ll check this out again.
- This reply was modified 6 months, 3 weeks ago by Jason Crist.
I believe this should be fixed in the 2.1.1 release with the following change:
Should be fixed in the following PR which will be in the next release.
This feature is out with the latest release (2.1.x)
Forum: Plugins
In reply to: [Create Block Theme] Can’t Change ScreenshotThere is a github issue that has been opened to allow for the management of screenshots.
https://github.com/WordPress/create-block-theme/issues/560In the meantime manually changing the screenshot is the easiest way to manage it.
I’m not sure why a screenshot.png wouldn’t work though, or why removing the .png version and providing a .jpg would be necessary. Hopefully that shakes out as the screenshot management feature is added.
You may want to try deselecting the
Localize Images
option when saving a theme (with the latest 2.1 version). This should avoid the calls that are causing the issue (as a temporary stopgap).Thank you for the report. I’ve opened a github issue and will be tracking it there. I’m looking into it now and hope to have a fix in the next release.
Forum: Plugins
In reply to: [Create Block Theme] create child theme bug?I’m not sure if it’s the SAME problem (I was testing on 2.1 rather that 2.0) however I did find A bug which I have created a fix for here. Hopefully that will resolve your issue creating a child theme.
Forum: Themes and Templates
In reply to: [Blockbase] ponyfill.cssI would say that, at this point in Block Theme evolution, that using ANY theme as a parent theme is rather unnecessary. The aspects of a theme that are well suited as coming from a parent are actually very portable (theme.json settings) and I wouldn’t recommend that structure except for edge cases.
Blockbase specifically has a lot of historical “shims” and “polyfills” that helped us get configurable themes created quickly a few years ago when Block Themes were just starting out but those shims and polyfills aren’t necessary anymore and actually make it MORE difficult to customize now that much of that is available to be done in theme.json settings (and Blockbase is sometimes overriding that in CSS).
Better to start with a theme that has a lot of the styling already in place as a starting point. (We use Block Canvas for that purpose very often which actually looks a fair bit like Blockbase but without the baggage.
Forum: Themes and Templates
In reply to: [Blockbase] ponyfill.cssWhen Blockbase was a Young Theme many aspects of the Block Themes that are well handled now were not. There were things in the Block Themes roadmap that we expected to be taken care of down the road, but we wanted to add that functionality to themes being designed today. Most of the things in “ponyfill” are configured using “custom” settings or other global parameters and target styles that (at the time) weren’t handled by CORE. It gave us a mechanism to control those aspects in child themes.
Ultimately those things in ponyfill can/should be removed to leverage the native solution instead which could allow the ponyfill to go away. It’s not longer very relevant to newer themes and using Blockbase as a parent theme is discouraged.
The code is considered a “ponyfill” because it’s something that ADDS FUNCTIONALITY in it’s “own way” rather than backfilling the ability to do things in older environments (which is what a “polyfill” does).
Forum: Plugins
In reply to: [Create Block Theme] Resulting zip file has no nameHi. I was able to reproduce this, however from what I can tell it ONLY effects the “export” option from the wp-admin menu area (which I believe will eventually be going way though it hasn’t yet so it should work as expected). If you do the same export from the Site Editor location then the theme is exported with the name expected.
However it seems that neither the CBT export option (from the ‘wrench’ icon in the Site Editor) or the default export option (from the ‘three dots’ option) export the theme as a ‘child’ (as you mention above as well).
Forum: Plugins
In reply to: [Create Block Theme] Block theme not exporting header and footerI’m not entirely sure how the solution will be implemented, but the problem stems from the
theme
attribute being set on thetemplate-part
blocks. If set, that attribute has to EXACTLY match the folder structure of where the theme resides, making it very possible that themes imported into different environment won’t work.The solution is to remove the attribute from themes that are saved/exported. This fixes things most of the time. I believe that’s done if a theme is saved/exported from the CBT editor interface. I’m not sure if the result is different via the wp-admin interface.
The kicker, though, is that if a
template-part
block is referenced from apattern
then it MUST have thetheme
attribute or it won’t work. But as we established above it has the potential to not work in other environments. Thus the solution there is to NOT include anytemplate-part
blocks in patterns.If you’re having trouble with themes exported (either from Gutenberg or Create Block Theme) then removing those theme attributes SHOULD make things work as expected. This issue is probably the best one to watch regarding what’s going on. Once CBT has a reasonably solid fix it will be noted there.
- This reply was modified 1 year, 4 months ago by Jason Crist.
- This reply was modified 1 year, 4 months ago by Jason Crist.
Forum: Reviews
In reply to: [Create Block Theme] Enable it for other themesThe plugin used to be called “Create Blockbase Theme” and was originally for Blockbase but it now works for all Block Themes. It is specifically for Block themes though, it would not work for classic themes.