Gary Pendergast
Forum Replies Created
-
Forum: Plugins
In reply to: [WooCommerce] Orders page bug after WordPress 5.0.2 UpdateHere’s a small workaround you can use to fix this until a proper fix is released:
function fix_request_query_args_for_woocommerce( $query_args ) { if ( isset( $query_args['post_status'] ) && empty( $query_args['post_status'] ) ) { unset( $query_args['post_status'] ); } return $query_args; } add_filter( 'request', 'fix_request_query_args_for_woocommerce', 1, 1 );
Forum: Fixing WordPress
In reply to: Indent List Item Not WorkingThank you for the report, @gbundros! I’m glad you’re seeing everything else working well.
Generally, it’s not possible to indent the first item in a list: list indenting is intended to show a sub-list belonging to the item in the parent list. I just tested in the classic editor with the TinyMCE Advanced plugin, it’s not possible to indent the first item in a list there, either.
Could you provide more information about what you’ve used in the past to indent the first item of a list?
Forum: Plugins
In reply to: [WooCommerce] Customer registration – Residence number disappearsThank you for the question, @claytonfeltran!
I’ve moved this topic to the WooCommerce forum, so the Woo support experts are able to help you. ??
Forum: Fixing WordPress
In reply to: Collation (general and 520) mixed up by WPThank you for the suggestion, @satollo! I’ve opened a ticket to investigate it further, I think we can make the scenario you’re describing much smoother. ??
It’d be super helpful if you could write about your current experience on the ticket: what size tables are you needing to convert, and how long does that take? What versions of MySQL are you upgrading from/to? Are there particular plugins that generate these failing
JOIN
queries?Forum: Developing with WordPress
In reply to: Delete/reset custom field value weeklyHi @nikphirke!
If you want to delete
post_views_count
from all posts, you could use thedelete_post_meta_by_key()
function, like so:delete_post_meta_by_key( 'post_views_count' )
If you only want to delete it from specific posts, you can use your current functionality, but you’ll need to define the correct value for
$post_id
.Forum: Fixing WordPress
In reply to: Sort in galleryThank you for the extra information, @homeexchange.
It does appear to be a mobile/tablet problem, I’m able to reproduce the bug you describe on my Android phone.
I’ve reported a bug to get this fixed: https://github.com/WordPress/gutenberg/issues/12965
Forum: Fixing WordPress
In reply to: Sort in galleryThank you for the feedback, @homeexchange!
We’re going to be looking at adding gallery reordering to the block editor in WordPress 5.1, you can follow progress over on this issue.
In the mean time, you’re still able to reorder galleries by clicking on the “Edit Gallery” button at the top of the gallery block.
Forum: Fixing WordPress
In reply to: Menu builder is need to get easierThank you for the suggestion, @microbit!
Improving menus is one of our priorities for 2019.
This project is currently in the very early stages, I’ve passed your comment on to the design team who are investigating it.
Forum: Developing with WordPress
In reply to: comment_form() button – change from toHi @astatine85!
You can change this using the
comment_form_submit_button
filter. There’s an example in the filter documentation.Forum: Fixing WordPress
In reply to: Update of php 7.3 cause errors in post.phpThank you for the bug report, @zzhenryquezz!
A fix for this bug was committed a few days ago, it will be included in the upcoming WordPress 5.0.2 release, due out on December 19.
You can also read more about WordPress 5.0.2 RC1.
Forum: Alpha/Beta/RC
In reply to: WordPress 5.0-beta3 does not save ACF metabox dataHi @flexer!
WordPress 5.0 beta 4 has just been released, which resolves this issue.
Forum: Alpha/Beta/RC
In reply to: WordPress 5.0-beta3 does not save ACF metabox dataI have inspected the POST requests when updating/publishing a post and they do not include any of the input fields found in the ACF metaboxes.
This is different from what I’m seeing, on a fresh install of WordPress Beta 3. After following your instructions, when I click the “Save Draft” button, I see the following form data submitted:
_wpnonce: a769abe117 _wp_http_referer: /wp-admin/post-new.php user_ID: 2 action: editpost originalaction: editpost post_type: post original_post_status: auto-draft referredby: https://.../wp-admin/post.php?post=5&action=edit _wp_original_http_referer: https://.../wp-admin/post.php?post=5&action=edit auto_draft: 1 post_ID: 7 meta-box-order-nonce: cdc040c3e1 closedpostboxesnonce: 89df6f89ba samplepermalinknonce: 768d6cd171 acf[field_5bdfda2e736eb]: baz comment_status: open ping_status: open post_author: 2
The
acf
parameter is being passed with the input value, but the extra ACF form data (added byACF_Form_Post::edit_form_after_title()
->acf_form_data()
,ACF_Form::render_data()
->acf_hidden_input()
) isn’t.That second issue is an important one that should have it’s own conversation. Can you please un-delete the topic?
TBH, the forum is a poor venue for bug reporting. We can continue the conversation over on #45284.
Forum: Alpha/Beta/RC
In reply to: WordPress 5.0-beta3 does not save ACF metabox dataI just saw your other comment on the pressing “Enter” causing the form to be submitted. I’ve created a bug to track that one, too: #45284.
Forum: Alpha/Beta/RC
In reply to: WordPress 5.0-beta3 does not save ACF metabox dataThanks for the feedback, @elliotcondon!
Could you confirm if ACF has worked in previous 5.0 betas? It seems like the missing functionality would have prevented ACF from working in any of them.
The problem is that ACF adds a bunch of hidden
<input>
fields on theedit_form_after_title
action, which isn’t fired in the block editor. I see you have a workaround for it that works with the Gutenberg plugin, but it won’t work in 5.0, as it depends upon thereplace_editor
filter.I’ve created a patch with a new filter in #45283, does this seem like it would work for you?
Forum: Alpha/Beta/RC
In reply to: post_type_supports($post_type, ‘custom-fields’)Thank you for the report, @ollybach!
I’ve just added a fix for this to the 5.0 branch, it will be included in the upcoming 5.0 Beta 3 release.