Pothi Kalimuthu

wp_is_mobile isn’t used by 99.99% of the themes unless specifically mentioned somewhere in the theme documentation.

You can ask the theme developer if wp_is_mobile is used.

Alternatively, you may search through all the files (within the theme) for the word “wp_is_mobile”. Here’s the one-liner, if you use a terminal in a macOS or GNU/Linux…

find wp-content/themes/ -type f -iname '*.php' -print0 | xargs -0 grep -in wp_is_mobile

For Q1 (site editor): Support for wp_is_mobile is needed for site editor or any code to work with this plugin. When there is no wp_is_mobile, this plugin simply just doesn’t do anything at all. I don’t think the site editor will support wp_is_mobile in the near future.

For Q2 (front-end): Like the previous answer, a theme needs to do something with wp_is_mobile to display different content for mobile users. 99.99% of the sites don’t show different content for mobile users. Those that do, usually show reduced, striped-down version of the content to make a site load much faster on mobile data (or wifi data). Basically, what you see in mobile and desktop won’t make any difference for normal eyes. But, behind the scene, a lot of stuff may be fine-tuned to load the mobile version faster (with the help of wp_is_mobile function). For example, we may not need to show some part of side-bar widgets for mobile visitors. So, they are usually removed altogether by some sites with the help of wp_is_mobile. Some ads are removed by some sites for mobile visitors (while others increase the number of ads on mobile). The possibilities are endless.

Basically, when there is no wp_is_mobilefunction in the theme or anywhere else, then this plugin is of no use for such sites or part of the sites.

That worked. Thank you.

Hello,

Screenshot: https://chandoo.org/assets/convertkit-wishlist-settings.png

The full stack trace of the error in wp-content/debug.log file…

[02-Aug-2024 05:23:16 UTC] PHP Fatal error: Uncaught TypeError: ConvertKit_API_V4::add_subscriber_to_form(): Argument #1 ($form_id) must be of type int, string given, called in /private/wp-content/plugins/convertkit/vendor/convertkit/convertkit-wordpress-libraries/src/class-convertkit-api-v4.php on line 517 and defined in /private/wp-content/plugins/convertkit/vendor/convertkit/convertkit-wordpress-libraries/src/class-convertkit-api-traits.php:253

Stack trace:

0 /private/wp-content/plugins/convertkit/vendor/convertkit/convertkit-wordpress-libraries/src/class-convertkit-api-v4.php(517): ConvertKit_API_V4->add_subscriber_to_form(‘default’, 2836704309)

1 /private/wp-content/plugins/convertkit/includes/integrations/wishlist/class-convertkit-wishlist.php(161): ConvertKit_API_V4->form_subscribe(‘default’, ‘pothi+20240802_…’, ”)

2 /private/wp-content/plugins/convertkit/includes/integrations/wishlist/class-convertkit-wishlist.php(64): ConvertKit_Wishlist->member_resource_subscribe(Array, ‘default’)

3 /private/wp-includes/class-wp-hook.php(326): ConvertKit_Wishlist->add_user_levels(12778, Array)

4 /private/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)

5 /private/wp-includes/plugin.php(517): WP_Hook->do_action(Array)

6 /private/wp-content/plugins/wishlist-member/classes/class-member-methods.php(1268): do_action(‘wishlistmember_…’, 12778, Array, Array, Array)

7 /private/wp-content/plugins/wishlist-member/classes/class-registration-methods.php(605): WishListMember->set_membership_levels(12778, Array, Array)

8 /private/wp-content/plugins/wishlist-member/classes/wishlist-member3-actions.php(1749): WishListMember->wpm_register(Array, ”, false, false)

9 /private/wp-content/plugins/wishlist-member/classes/wishlist-member3-actions.php(134): WishListMember3_Actions->add_user(Array)

10 /private/wp-content/plugins/wishlist-member/classes/wishlist-member3-hooks.php(342): WishListMember3_Actions->process_admin_ajax_actions(‘add_user’, Array)

11 /private/wp-includes/class-wp-hook.php(324): WishListMember3_Hooks->admin_actions(”)

12 /private/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(”, Array)

13 /private/wp-includes/plugin.php(517): WP_Hook->do_action(Array)

14 /private/wp-admin/admin-ajax.php(192): do_action(‘wp_ajax_admin_a…’)

15 {main}

thrown in /private/wp-content/plugins/convertkit/vendor/convertkit/convertkit-wordpress-libraries/src/class-convertkit-api-traits.php on line 253

Due to privacy reasons, I can’t provide a screen recording. Used the same method as in the screen recording shared by you. However, the issue might arise when used with other plugins that we use in our specific environment / site. Here’s the list of plugins used in our side…

wp plugin status

  A akismet                       
  A block-bad-queries             
 UA convertkit                    2.4.9.1
  A coursecure                    
  A elementor                     
  A elementor-pro                 
  A really-simple-captcha         
  A simple-history                
  A ultimate-addons-for-gutenberg 
  A ssl-insecure-content-fixer    
  A subscribe-to-comments         
  A wishlist-audio-player         
  A wishlist-member               
  A wishlist-variables            
  A wishlist-welcome              
  D object-cache.php

PHP is at 8.1.x. WP core is at 6.6.1.

Thanks for looking into this.

Thanks everyone. Now, the plugin is also tested with the upcoming version (6.6) of WordPress core.

@jmsilcom

Some naming schemes were changed to match with the upstream Mobile Detect library. Currently, those old names were brought back in the plugin version 3.1.0. Hopefully, this update resolves the issue. Thanks.

My apologies @lezgubeaux for the trouble. Earlier, I didn’t test with PHP 8.2. Just now, I tested with PHP 8.2 (and PHP 8.3) by installing/activating the previous version (1.5.1) and then updating it (to version 3.0.2). The update went through successfully. I really couldn’t understand what’s going on. If you have any ideas, please let me know.

The plugin version 3.0 and 3.0.1 had some issues that would bring down a site. Please try with version 3.0.2.

The minimum PHP version requirement is moved to PHP 7.4. If your server / site uses a lower version, please consider upgrading to PHP 7.4 or above.

Thanks for the heads-up. Somehow, I missed the updates from Mobile Detect library. For now, I’ve updated the core library to 3.x that is currently LTS. Mobile Detect version 4.8 requires PHP 8.0. Since, there are still sites with active PHP 7.4 support, I will hold on updating to 4.8 for now.

Thanks for the time to review this plugin.

How about keeping the minimal required version to the major version number (7.4), instead of point release number (7.4.x)?

There is no difference in terms of features between the major version(7.4) and the subsequent point releases (ex: 7.4.30). Only bug fixes and security patches are different. Direct quote from… https://www.php.net/supported-versions.php

Each release branch of PHP is fully supported for two years from its initial stable release. During this period, bugs and security issues that have been reported are fixed and are released in regular point releases.

This would solve the issues mentioned by @gothickgothickorguk who is probably using the PHP version supplied by the OS that takes care most (if not all) of the security patches for the lifetime of OS. For example, Ubuntu 22.04 comes with 8.1.2 and this version will stay there until the OS reaches EOL (until Apr 2027). This means the users don’t have to switch the PHP version every 3 years.

Your call.

• This reply was modified 1 year, 11 months ago by Pothi Kalimuthu. Reason: Chose the correct wording
• This reply was modified 1 year, 11 months ago by Pothi Kalimuthu.

@kzeni Sorry to spam your thread.

@tigroumeow Just a quick feedback: I had the same issue with PHP 7.2 running on Ubuntu 18.04 (that is still supported). It’d be nice to include such changes at least in the changelog. Additionally, I’d even include such changes in the version number. For example, I would have released it as 6.4 if not as 7.0. Thanks.

Hello,

I didn’t test it out with PHP 8.1 as I have been running on limited resources. Thanks for testing it out.

The deprecated notice seems to come from the upstream Mobile Detect library. It was fixed by the author long ago. I didn’t push the update. My apologies.

It’s fixed with version 1.4.1.

Thanks again,
Pothi.

I can confirm that the latest update (1.9.101.1) works.

I will consider the proposed changes in the upcoming updates. Thanks for the feedback. Appreciate your time.