Raja Anbazhagan

I don’t have the issue anymore with 1.45 build.

Thanks, James.

I will follow it up on GitHub.

Thanks, Bethany & James. I honestly thought I replied to this post earlier, sorry for that.

After hitting a lot of dead ends, I realized that the problem I have right now is a usability issue with the analytics module of amp specification.

Anyway, The Google Site Kit works as it should and I am happy to have this plugin. Thanks for the good work.

Hi Thanks for replying. Both the document and the AMP playground shows the same example which I have hard time converting into a GA event/trigger.

The information I need is this. The analytics section in your plugin takes a vendor name and a json for config. Can you show an example where I can use the ${cumulativeLayoutShift} macro and pass it to google analytics as an event?

If you feel like it, I can help contributing to your plugin.

I checked the code. Fortunately it’s a single line fix for me. I didn’t have enough permission to commit the fix to your SVN. So here is the patch.

Index: trunk/gothamblock.php
===================================================================
--- trunk/gothamblock.php	(revision 2481979)
+++ trunk/gothamblock.php	(working copy)
@@ -48,6 +48,7 @@
 			  var over = document.getElementById("overlayh");
 			  mes.style.display = "none";
 			  over.style.display = "none";
+			  document.body.removeAttribute("style");
 		  }
 		  function gothamadblock_myClosePopSSJ() {
 			  window.location.reload()`

• This reply was modified 3 years, 9 months ago by Raja Anbazhagan.