Rick Buczynski

Getting back to you, I wasn’t able to reproduce your problem. But I looked over the code, and found some potential issues with how it saves the includes to the database. So I corrected them. Try it now by upgrading your plugin to the latest (0.2.1).

If that doesn’t help, please open a new support thread and give me more information; specifically, the entire configuration for each of these files (paths, dependencies, version, in footer, etc …).

Brendan, Thanks for the good feedback. I’m thankful that you appreciate my work.

Sorry you’re experiencing some issues, though. I can see the problem with that line of code. I guess I was lazily combining operations.

I’ll add it to my to-do list for this Friday, and so you should hopefully see a fix by the weekend.

See version 0.2.0 for this update.

Thanks for the post. For some reason I wasn’t notified of it, so I’m very late in getting back to you.

By conditional, do you mean IE conditionals …

<!--[if IE 9]>

… ?

If so, that’s not supported, but it’s an awesome idea. I’ll look into implementing that. This plugin is due for an update, anyhow, since it throws a lot of warnings depending on your PHP configuration. I’ll mark this as an enhancement for the next release.

Thanks for your feedback!

I did more research. It seems that by combining scripts, localization is lost for thickbox.js. In WP 3.5.1, see /wp-includes/script-loader.php, line 182:

did_action( 'init' ) && $scripts->localize( 'thickbox', 'thickboxL10n', array(
			'next' => __('Next >'),
			'prev' => __('< Prev'),
			'image' => __('Image'),
			'of' => __('of'),
			'close' => __('Close'),
			'noiframes' => __('This feature requires inline frames. You have iframes disabled or your browser does not support them.'),
			'loadingAnimation' => includes_url('js/thickbox/loadingAnimation.gif'),
			'closeImage' => includes_url('js/thickbox/tb-close.png')
	) );

When the plugin is enabled with combining on, this localization is not triggered (hence the thickboxL10n undefined errors).

I fixed my issue by adding this to my theme’s functions.php:

function mytheme_thickbox_compression_fix() {
    echo '<script type="text/javascript">';
    echo "var thickboxL10n = ".json_encode(array(
        'next' => __('Next >'),
        'prev' => __('< Prev'),
        'image' => __('Image'),
        'of' => __('of'),
        'close' => __('Close'),
        'noiframes' => __('This feature requires inline frames. You have iframes disabled or your browser does not support them.'),
        'loadingAnimation' => includes_url('js/thickbox/loadingAnimation.gif'),
        'closeImage' => includes_url('js/thickbox/tb-close.png')));
    echo '</script>';
}
add_filter('wp_footer','mytheme_thickbox_compression_fix',20000001);

It’s a hack that works for now, at least until this issue can be addressed by the developer.

Same here. I have a custom slider, but the problem is caused by this:

Uncaught ReferenceError: thickboxL10n is not defined

It appears that packing thickbox.js produces undesirable results. Moreover, if I try to exclude it from the scripts via the exclude-js field, then the order in which the scripts are processed is wrong, so I get jQuery undefined errors.

So is there a way to define a script order that takes into account all scripts (even excluded ones)?

It would be nice if we could also determine which scripts go to the bottom of the page, and which ones stay in the head.