Ricky de Laveaga

I was also confused about where to find settings and agree with the proposed solution of adding:

a “Settings” link under the plugin name on the Installed Plugins page (e.g. wp-admin/plugins.php) that links to wp-admin/options-discussion.php to better help direct admins on where to customize their SLA experience.

Thanks so much for the lightning fix. I noticed in testing the patched version that in the minified JS the function that sets the eventPopupURL later used to open the window is setting var a to "https://tourdates.bandsintown.com/event/"+this.id;return g(a).setQuery(this.collection.eventPopupQueryParams()).toString() which does not return events for me where "https://bandsintown.com/event/"+… does. Removing tourdates. has events and the Tickets and More links returning the event. Thinking you would probably be editing unminified original file I checked to see if that was available and it was, thanks for that, this is line 25156 in main.js.

Once I had event links working on new API, I noticed a separate problem later on in the JS (line 25479 in main.js)…
this.popupWindow=e.openWindow(a,b,this.popupOptions(375,627))

…Creates an unusable cropped popup window (page layout does not respond to small viewport) where passing a version minus ,this.popupOptions(375,627)…
this.popupWindow=e.openWindow(a,b)

…Spawns a full window in a new tab as I would expect and I imagine most downstream consumers of the plugin would also. Thanks again for the attention, and if I can help by committing these proposed changes to the JS somewhere, please let me know.

make that line 175 in bandsintown.php with parent::__construct in place of parent::WP_Widget

Hi Phil,
Thanks for the update, getting this (Stack Overflow: The called constructor method for WP_Widget is deprecated since version 4.3.0) , after updating to 1.1.2 and fixing/adding data attributes that changed or were added to v2 API. Can verify that an identical plugin with parent::__construct in place of parent::WP_Widget in bandsintown.php on line 178 as Stack Overflow answer recommends solves the issue. Any chance of adding the source to @bandsintown GH? I would add a PR there if you want, but know that is asking a lot so if it’s easier to fix yourself and leave SVN as is, totally understand.

Ricky

• This reply was modified 7 years, 1 month ago by Ricky de Laveaga. Reason: typo

Unnecessary default options (shape or language, not sure which, could be both) the plugin currently passes to the Pinterest JavaScript API as data attributes are inexplicably forcing it to the small gray one.

If you change Lines 67 – 78 to:

// add the shape if not default
if(isset($shape_op) && $shape_op != "rectangle") {
  $return_string = "$return_string' data-pin-shape='$shape_op";
}
// if shape is not round, add the color and language
if(isset($shape_op) && $shape_op != "round") {
  // add the color if not default
  if(isset($color_op) && $color_op != "gray") {
    $return_string = "$return_string' data-pin-color='$color_op";
  }
  // add the language if not default
  if(isset($lang_op) && $lang_op != "eng") {
    $return_string = "$return_string' data-pin-lang='$lang_op";
  }
}

Size and color options work.

Bill is there anywhere I can submit a patch, if you want one?

@marcuspope hell yes!
plugin works like a charm
https://www.ads-software.com/extend/plugins/preserved-html-editor-markup/