remi123

That isn’t how it works, The css has to be added late with a style tag, can’t be part of the inline css else it doesn’t work.

Yeah OK, that makes sense.

Nothing changed with that in the last update.

I don’t see it when I test with plain emails. Can you tell me more about your setup so I can recreate what you are seeing?

Well.. since we’ve updated WooCommerce to it’s most recent version (3.9.0) it does work properly indeed.
So; problem solved.

Nope, no issues anymore after the update. Thanks!

Well.. I checked again and now it’s working? Maybe by an update?

I will mark this topic as solved, thanks anyway!

Checked a second time; it works on posts but not on pages. So, the message is Dutch at posts but English at pages.
We use WordPress 5.3.2 and Minimum Featured Image Size 2.0.1

• This reply was modified 4 years, 10 months ago by remi123. Reason: Thought it was solved, yet it wasn't
• This reply was modified 4 years, 10 months ago by remi123.
• This reply was modified 4 years, 10 months ago by remi123. Reason: typo

I’ve looked into it and the exact reason why it has come back is unclear.

However I believe the 2 ‘gmail hack functions’ could be combined.

OLD:

public function check_to_add_gmail_hack( $css, $email = '' ) {
	add_filter( 'woocommerce_mail_content', array( $this, 'add_gmail_hack' ), 50 );
	return $css;
}

NEW:

public function check_to_add_gmail_hack( $css, $email = '' ) {
	if( Kadence_Woomail_Customizer::opt('responsive_mode') != true ) {
		$css .= '.gm-remove-late{display:none;}';
	}

	return $css;
}

Which makes function add_gmail_hack unnecessary and unused.
Because the woocommerce_email_styles filter only runs on HTML messages and, as far as I’ve seen, prepends inline CSS to woocommerce_mail_content filter.

Hi @britner

It seems like the fix for the ‘plain email gmail hack’ has disappeared?
The line <style type="text/css">.gm-remove-late{ display:none;}</style> is back in our plain WooCommerce emails.

Anyone? @corgmo?

• This reply was modified 4 years, 10 months ago by remi123.

Hi Erwin,

Thanks for your reply. Do you have any idea, if it get’s picked up, when this will be?
Or where I can follow any updates on this request? ??

Also;
add_filter( 'woocommerce_mail_content', array( $this, 'add_gmail_hack' ), 50 );
should only be applied to HTML e-mail messages. Now we’ve got a shop which uses plain text and this results in plain text messages all starting with;
<style type="text/css">.gm-remove-late{ display:none;}</style>= Confirm booking =

Hi Ben, in this case it’s WooCommerce Bookings.

Yeah.. there are actually too much words and lines hardcoded English..

For now I’ve modified several files of your plugin but do you think your plugin becomes 100% translation ready in near the future?

and also line 560 please:

from:
$results .= '<p><button type="submit" onclick="return confirm(\'Deleting your account will delete your access and all your information on this site. If you have a recurring subscription, you must cancel that first to stop payments. Are you sure you want to continue?\')">Delete Account</button></p>';
to:

$results .= sprintf(
	'<p><button type="submit" onclick="return confirm(\'%1$s\')">%2$s</button></p>',
	esc_attr__( 'Deleting your account will delete your access and all your information on this site. If you have a recurring subscription, you must cancel that first to stop payments. Are you sure you want to continue?', 'leaky-paywall' ),
	__( 'Delete Account', 'leaky-paywall' )
);

another two;

line 305 in shortcodes.php from:
$profile_table .= ' <td>' . ucfirst( $status ) . '</td>';
to:
$profile_table .= ' <td>' . __( ucfirst( $status ), 'leaky-paywall' ) . '</td>';

line 307 from:
$profile_table .= ' <td>' . $profile_payment . '</td>';
to:
$profile_table .= ' <td>' . __( $profile_payment, 'leaky-paywall' ) . '</td>';

Thanks! Looks good, still found one two tho.

Could you change line 3015 in functions.php from:
$display_price = 'Free';
to:
$display_price = __( 'Free', 'leaky-paywall' );

and line 649 in shortcodes.php from:
$content_access_description .= ucfirst( $type['allowed'] ) . ' ' . $type['post_type'] . 's';
to:
$content_access_description .= __( 'Unlimited', 'leaky-paywall' ) . ' ' . $type['post_type'] . 's';

The last part of the line above is still English in my Dutch website, it seems it cannot be translated although the default WordPress translation has the words ‘posts’, ‘pages’ etc.. i made a workaround by replacing the word ‘posts’ in Dutch by using the ‘leaky_paywall_content_access_description’-filter. Maybe you can find a translation fix for this later on?

• This reply was modified 6 years, 4 months ago by remi123. Reason: found a second one
• This reply was modified 6 years, 4 months ago by remi123. Reason: type

@endocreative do you have an estimation when the next update will be released?

• This reply was modified 6 years, 4 months ago by remi123. Reason: tagged wrong user

I also noticed line 594 (shortcodes.php) is static;
$content = '<p>Please <a href="' . get_page_link( $settings['page_for_subscription'] ) . '">go to the subscribe page</a> to choose a subscription level.</p>';

I assume there could be a lot more of these static lines or words.
Are you going to fix all of these to be translatable in your plugin? That would be great to be looking forward to.