renatobusatto

That’s brilliant, thank you!

Just to add the ICS problematic verson is 10.13.0. After having this error I have downgraded the ICS verson to 10.12.2 and everithing works fine at this version.

• This reply was modified 1 year, 4 months ago by renatobusatto.

No worries, thank you again for your hard work in keeping this plugin.

If you allow me to give my 5 cents suggestion, it would be helpful keeping it simple and adding as many specific css classes as necessary (such as has_desc, has_time, has_date etc). In this way your php code would be simpler and would allow more control using css only.

Thanks for clarifying. That was an interesting choice considering in this case there is no eventdesc element inside a has_desc. To me. it would make more sense to have a has_date class instead, and more importantly, in this way I could hide the hover block that has no desc using CSS only (considering the :has selector isn’t supported by Firefox yet). Please, would you have a suggestion on how to solve this? I can’t think of a solution without using javascript.

Thanks once again.

That was brilliant, thanks a lot!

Thanks Scott, that would be great!

That’s good to know, thanks.

Thank you for your reply. I’ve just sent you an email with the shortcodes I’m using.

Thank you very much for your lightning quick fix, I’ve updated my code and it’s working perfectly!!

If someone ever need, this is my code to remove URLs from the events’ description. I have added it using the Code Snippets plugin.

function r34ics_ext_remove_url($ics_data){
  array_walk_recursive($ics_data['events'], function(&$value, $key) {
    if ($key=='eventdesc') {
      $value = preg_replace_callback(
        '/\w+:\/\/\S*\s+/',
        function ($m) { return ''; },
        $value
      );
    }
  });
  return $ics_data;
}
add_filter('r34ics_display_calendar_filter_ics_data', 'r34ics_ext_remove_url');

Thank you very much for looking into that, I’ll send it to you by email.

It would be really helpful to be able to use regex on the events’ description at the server side. Using javascript can hide it from the user, but the info is still sent to the browser. Any one can see it on the page source, or worse, have private information indexed by Google. Adding an ‘apply_filter’ hook with the ics_data array as a parameter ($ics_data) before rendering the template (class-r34ics.php file, line 621) would be enough to enable this kind of filter.

This is just a suggestion. I’ve been trying to do it in a safe way on the server side and it’s been really hard do to it without a filter hook.

• This reply was modified 4 years, 7 months ago by renatobusatto.

Just an update on this. It seems that any all day recurring event shows as starting at 12 am.