reviewmylife

Hi labubbl – I’m guessing you are using my Ad Injection plugin – https://www.ads-software.com/extend/plugins/ad-injection/

I’d suggest you turn on debug mode and then look at the debug messages in the HTML source. If this doesn’t work send me a link to one of your affected pages, along with some details of what adverts you are expecting to see.

Another idea – Test mode will only show adverts if you are logged on at admin level. You could try turning the adverts to ‘on’ instead.

You can contact me by clicking the feedback link on the plugin settings page.

Hi Septrax, That is good that you got it working ??

Could you let me know what the problem was? It might be useful to know for other people.

Cheers.

Hi septrax,

There is probably something very simple going wrong. First of all I suggest you turn on debug mode, and then look at the debug messages that will be inserted into the HTML source. These may help you figure it out. If you find out please post the solution ??

If you can’t work it out can you send me your email address via my website’s contact form – https://www.reviewmylife.co.uk/contact-us/.

To help solve this I’ll need:

1. the contents of the settings table in the ‘debug’ tab of Ad Injections.
2. for you to turn on debug mode.
3. a link to an affected page on your website.

If we find a solution I’ll post it on here as well.
Thanks!

Hi liaaz,

At the moment there is no way to show ads immediately after the comments box – unless you have a widget area after the comments box. If you do have a widget area there you can insert the adverts using Ad Injection widgets.

(If you don’t have a widget area there you could add one to your theme in this location if you really wanted to.)

Hi Andy, I have not yet tested it with multisite, it is on my TODO list for later in the year.

I suspect there may well be problems due to Ad Injection saving and loading adverts from disk in mfunc mode.

direct_static and direct_dynamic modes probably have a higher chance of working.

If you try it on multisite please let me know how (or if!) it works. I’d be interested to know.

Thanks ??

Starting in reverse from cause to reproducing the bug…

I think the reason for this bug is this line (about line 470).

} elseif ( isset( $fr2 ) ) { // supercache active

$fr2 is false BUT it is set! So this will always evaluate to true.

Here’s some additional info to help you reproduce it.

The ‘Don’t cache pages for known users.’ must be ticked.
The supercached version of the page must have already been created by an anonymous user.

Here’s some more detailed steps.

1. Clear WP Super Cache cache.
2. Clear browser cookies.
3. Go to page with mfunc tags (you are an anonymous user). A .php file is created in the supercache directory.
4. Make a note of its timestamp.
5. Post a comment.
6. Note that the .php file has been updated.
7. Look in the .php file – you’ll see the name/email has been cached.
8. Use another browser with cookies cleared to browser to that page. You’ll see the name/email are filled in with the person who submitted the previous comment.

Here’s the last bit of the debug logs. What seems to be interesting is that after going into the block where it prints ‘Not caching for known user’ it manages to get into the block where it prints ‘Renamed temp supercache file to’. This is I think because of you ‘isset’ check.

23:49:49 /two-paragraphs/ Cookie detected: comment_author_53b7a3ca522a2576bc9c84658f306d1f
23:49:49 /two-paragraphs/ Cookie detected: comment_author_email_53b7a3ca522a2576bc9c84658f306d1f
23:49:49 /two-paragraphs/ Cookie detected: comment_author_53b7a3ca522a2576bc9c84658f306d1f
23:49:49 /two-paragraphs/ Cookie detected: comment_author_email_53b7a3ca522a2576bc9c84658f306d1f
23:49:49 /two-paragraphs/ Not caching for known user.
23:49:49 /two-paragraphs/ supercache dir: /[SNIP]/wp-content/cache/supercache/[SNIP].co.uk/two-paragraphs/
23:49:49 /two-paragraphs/ Dynamic content found in buffer.
23:49:49 /two-paragraphs/ Renamed temp supercache file to /[SNIP]/wp-content/cache/supercache/[SNIP]co.uk/two-paragraphs/index.html.php
23:49:49 /two-paragraphs/ Sending buffer to browser

Could the fix be to do something as simple as this (one extra line in wp-cache-phase2.php?

if ( $wp_cache_not_logged_in && wp_cache_get_cookies_values() != '' ) {
		$super_cache_enabled = false;
		$cache_enabled = false;
		if ( isset( $GLOBALS[ 'wp_super_cache_debug' ] ) && $GLOBALS[ 'wp_super_cache_debug' ] ) wp_cache_debug( 'Not caching for known user.', 5 );
		return $buffer."<!-- Returning live page as you are logged in -->";
	}

It seems easily reproducible.

1. Load a dynamic page in your browser (one with mfunc tags in it).
2. Submit comment.
3. Comment is now saved into newly created .php file.

This is a bad bug as it means that the commenter’s email address is then revealed to other visitors!

Hi liaaz,

Version 0.9.4.1 of the Ad Injection plugin which I’ve just submitted now supports blocking ads on specific category or tag types.

Hi liaaz,

I am working on the category restriction code right now ?? I’m adding global options to restrict all ads by categories and/or tags. I’m hoping to submit the first version of this feature tomorrow (Wednesday).

Can you give a few more details on what you mean by restricting by the URL being visited?

I’ll take a guess – If you want to restrict ads from a specific posts/page you can define the ‘disable_adverts’ custom field for the post/page to be the value ‘1’. Or you can insert a <!--NoAds--> tag into the page contents.

Hope this helps. Get back in contact if you need any more help.

I don’t have anything helpful to add, but I can reproduce this error as too – so it is not just you.

Not that I’d want to delete it of course as it works well for me ??

I gave it a quick go on my test site – all looks good ??

Just spotted that my code block in reply 15 was deleted and I can’t edit the post anymore. Here’s a link to it on pastebin.

Oh and by the way, I’ve started testing your trunk at revision 323148 on my main reviewmylife website. The mixed mod_rewrite/PHP mode is working very nicely so far. All pages are being served compressed with a mix of the .gz files, and dynamic compression.

I might give your new CDN support a go soon as well.