rfc1437

after looking into this whole thing for a while now (several other places with problems with proper http/https handling showed up) it seems that in some cases it is needed to use is_ssl() to check for current scheme and then str_replace on urls to turn them to the needed scheme. An idea might be to add a filter to all places where jquery-lightbox outputs URLs and hook a filter function to that single place to handle this problem.

ok, patch in that ticket is there, thanks to jkudish. For situations where you have an older version or can’t upgrade, put this in your functions.php:


// fix ssl handling for background_image theme_mod
function fix_theme_mod_background_image_ssl($url) {
if ( is_ssl() )
$url = str_replace( 'https://', 'https://', $url );
else
$url = str_replace( 'https://', 'https://', $url );
return $url;
}
add_filter('theme_mod_background_image', 'fix_theme_mod_background_image_ssl', 10, 1);


This is just here for people who search ??

anybody who sees any fun in “discussing” with devs might be willing to hop onto this and try to get it through the ticket-refusal-wall: https://core.trac.www.ads-software.com/ticket/18005

I actually use 1.3.3 now, but the mixed http/https problem still is there. You can see it on https://hugo.rfc1437.de/category/galerie/ – both the lightbox.min.css and the jquery-lightbox.min.js are loaded via http instead of https.

I have exactly the same problem, with 3.1 and now 3.2. It looks like the code for add_custom_background addes the styling to the body tag directly and uses an absolute URL there which doesn’t take https/http into account.