Robert.Vidrine

Thank you for your rapid response. I have already fixed the problem on my live site, and when I went to create the tabs on my development site, I noteiced that the process of creating the tabs is much different than it used to be.

It occurs to me that even though I am using version 2.9.2, I have been copying the blocks on previous pages which already had the styling I wanted instead of creating new blocks. It seems that this was perpetuating the older style of blocks I thought that the blocks would get any new functionality just by updating the plugin, but perhaps I need to rebuild the blocks from scratch to get the new functionality?

Thanks for the reply. HOwever, it appears that I have the most recent version of ADVGB (2.4.3). I can download the latest version of ADVGB and upload it again to my site if you think I should force a reinstallation of the files.

Or, is there something else you mean?

Robert

BTW, although some of the functionality of the tabs is still in place, the tabs block on the page link submitted has been changed somehow to a “Classic Paragraph” block. I don’t see any way to convert it back to an adv-gb-tabs block.

I am delighted to report that the 2.3.5 update has fixed my problem! All of my existing tab panels are now working as expected again.

Thank you very much for your speedy work on this. I really appreciate it!

I don’t know if this is helpful or not, but when the newest version of the plugin was applied to my site, all of the previous uses of the tabs block broke, but the one that I rebuilt recently (on version 2.3.3) did not. This is a very serious error on my site, as the faculty profiles, which use the tabs block are consistently the most popular pages on our site. I would like to keep using Advanced Gutenberg for tabs blocks, but am nearing a point at which I may have to switch to another solution to get these pages running again.

In the current version of the plugin (2.3.4), the content which was formerly in tabs now shows up as almost completely unstyled content as described above. The tab labels are an unordered list with bullets, followed by the content of the tabs, each in a bordered segment, in the order that the tabs were laid out on the page.

Thank you for any help you can provide to make your previous tabs work again. I am going to look at the current tabs and the recreted ones and see if there is a class I can add to the tabs to make them work again. (They must be missing a class name or something, as none of the tab styling is being applied to them, other than some inline styles to make the borders and background colors).

Additional info:
I noticed that version 2.3.4 was released today, so I upgraded to this new version on a development copy of the site I linked before, and all of the existing tabsets failed, as if the CSS selectors were no longer relevant. This is the same behavior I saw when I deactivated the plugin. Each of the tab labels appear as an item in a unordered list at the start of the tabset, followed by the intended contents of each of those tabs, with a border around each content block. (I suppose that indicates that some of the CSS rules are being applied, but these must be inline styles that remain in the HTML after the plugin is no longer working.)
I cannot give you a link to this private development site, and don’t see a way to attach a screenshot to better explain what is happening on these pages after applying version 2.3.4 update. However, I would be happy to send you a screenshot if that would help.

Thank you for looking into this,
Robert

Thank you for looking at this. Sorry about the problem with the page I linked. I had to rebuild that tabset from scratch because this page needed to be working quickly. All of the other Faculty Profiles in that section still show the problem.

Here is another example:
<https://education.wfu.edu/about-the-department/faculty-and-staff-profiles/dr-joseph-milner/&gt;

If you visit the Faculty Profiles page (find it in the breadcrumb trail), all of the other pages linked to it exhibit this problem.

Thank you for your help!
Robert

On inspecting the tab elements, the li containing the tab label is not getting the advgb-tab-active class on the existing tabs. (Since this is working on new tabs, I was able to confirm that tabs in other contexts are getting this class.)

I have not figured out any conflict that would cause this, but perhaps this information would help in figuring out what is not happening that should be. I can confirm that upon clicking a tab, I am taken to a new URL with the anchor of the chosen tab displayed in the URL.

Thanks again for any help you can provide.

Javier,
I have obviously hurt your feelings with my review. I am very sorry for this. I do respect that you have put in a lot of time on this plugin, and have been very responsive. I noted that in each of my posts.

However, there are issues with the functionality of your plugin. This is not personal. I have tried to offer constructive criticism of your plugin. It is quite true that I do not understand everything about your plugin and how it works, and it is also true that the plugin did perform some functionality that was useful to me. However, it is also true that it made a mess, which it then cleaned up when I deactivated it.

I sincerely hope that you continue to develop this plugin. I have deep respect for those who are brave enough to share their work publicly, and there is a great deal of value in this plugin. It is not in my eyes a five star plugin.
The star rating system is not just to rate the amount of time you have put into a plugin, nor the quality of the developers making the plugins; it is an objective measure of the performance of the plugin.

I have followed the Donate To This Plugin link from www.ads-software.com, with the intent of donating to your continued development. This goes to codection.com but I don’t see anywhere to make a donation.

I am simply trying to point out areas where your plugin needs a little work. I have shared my opinions about your plugin so that others can see my perspective and know what is good and what is not so good about your plugin. My review and rating reflect that your plugin does very well some of what it sets out to do, but some parts not so well.
It is my sincere hope that it will improve even more and become a five star plugin, showing the hard work and expertise you are clearly putting forward.

I have clearly offended you, though I honestly don’t know why. If I can come up with specific code changes to suggest, I will submit them to you personally, at the email address you have provided in other posts.
Please keeup up the good work!

Javier,
I am very sorry if you feel that my review was too harsh. I recognize that this plugin does many things that I myself cannot program, and I respect the fact that I am leaning on the knowledge that you and your colleagues have which I lack. I appreciate the fact that you are giving your plugin away for free.

The fact is that this plugin only approximately did what it’s supposed to do. It did accomplish something that saved me time, importing my users, creating passwords, and importing metadata. Unfortunately, it also cost me time trying to figure out what went wrong, as it created an entirely new set of fields in my user profiles, which destroys the functionality of having well-labeled, easy-to-use input fields which I had created.

As soon as I removed the plugin, it cleaned up the extra columns it had added, which effectively got rid of the problem. After this point, I attempted to raise my rating to three stars. I’m afraid I cannot agree with your other users and give you five stars. This plugin is somewhat useful (and I thoroughly appreciate you responding so immediately to my other post and adding documentation to the plugin), but it is not perfect. To me, five stars means “perfect”; Three stars means “pretty good, but look at the details to deal with the blemishes”.

I will attempt again to raise my review to 3 stars.
You seem to be a very conscientious, responsive developer, and if I can figure out any more direct suggestions for improving your plugin, I will submit them. Please continue your work; this plugin has the potential to be something great!

I found a solution, but I’m not sure it doesn’t have other implications…

The problem occurs when the header text is hidden, so the .site-branding box is not shown. I finally found a way to run a real code inspector on my mobile device (through Chrome dev tools, unlike instructions from Google, had to install the Android SDK too). The .site-branding box is still occupying space, although it doesn’t appear visually.

I know that the technique for hiding the .site-branding box is straight from the core themes (introduced in Twenty-Eleven?), but this seems to be the cause of the problem.

If I change the following code (located in inc/custom-header.php)

.site-branding {
			position: absolute;
			clip: rect(1px, 1px, 1px, 1px);
		}

to this:

.site-branding {
			display: none;
		}

The problem disappears! No more scrolling “off page” to the right!

Since display: none still leaves the code in the DOM, just removing the element from the visual display and causing it to not take up space on the page, I believe this will not adversely affect SEO. screen readers and bots could still see it. I’m not sure if there are other implications that originally prompted the use of the clip property instead of display, but this does seem to take care of the problem.

Anyone know why ‘clip’ is used instead of ‘display’ and why this solution would cause other issues?

Some more experimenting, and the problem only shows up when I am using a header image and hiding header text. I realized also that the mobile emulators are not accurate in regards to this bug. I finally got a mobile device connected behind the firewall, so I could view my site (not yet public) on an actual mobile device (android phone). Confirmed that with a non-cropped 1280×300 image and no header text, the page will scroll right, seemingly outside of the viewport (footer shading, nav menu bar etc. do not extend outside the viewport).
This was with newest version of Simone (2.0.3) on WP 4.1 with all plugins deactivated.

I’m going to dig further into the code and analyze the differences between when the header text is shown and hidden. Something is causing my mobile browser (not sure exactly what it is–called “Internet” on my android phone; chrome variant or Opera variant maybe?) to “see” some content shifted to the right and is expanding the viewport to allow for it.

Does this help anyone else pick apart this problem?
Thanks for any help!
Robert

My code uses the filter pre_set_site_transient_update_themes to add my theme info. Is there something wrong with doing this?

There may not be a critical reason why my theme could not be hosted on www.ads-software.com, but it is only relevant to academic sites located at Wake Forest University. It doesn’t include a lot of features that would be required of a general purpose theme. (It does not include much support for basic blogging features, since it is used almost solely for academic department websites.)

Thanks bcworkz!
I had been going on the understanding that the default set during add_setting() was used if get_theme_mod() was not found, but this would be a lot more complex. (The code would have to look for the add_setting() and find if the not found mod name was specified there, then get the default value.)

My theme update can finally be released!
(Now that I’m not searching for an error that’s not there…)

@nexorianus:
I would appreciate someone taking this on, if indeed the developers have abandoned it. It (and User Avatar) are very useful plugins, but they have to be updated.

Having to hack it to get it to work again means that I’ve already taken the first step in moving away from the author’s development cycle. If they don’t revive it, I’ll either have to move to another plugin, or try to maintain my own hacked version.