rolfhuiber
Forum Replies Created
-
Forum: Plugins
In reply to: [Yoast SEO] Defensive ProgrammingFrom your answer I read, to solve the problem, is that the problem is caused from WordPress and/or a plugin, and an update would maybe fix the issue.
Is it correct, when I conclude, that you are reading data, which is produced by another source, into your plugin?
Is it also true, that you don’t check the validity of the data read in to your plugin?Forum: Plugins
In reply to: [Yoast SEO] Defensive ProgrammingHello Priscilla
When it is the way to go, to inform your developers, please create an issue.
RolfForum: Plugins
In reply to: [Yoast SEO] Defensive ProgrammingMain is, that the error is produced in the Yoast code because it tries to access an object which does not exist. Defensive programming would check if the reference is a valid object before accessing it attributes/members. Yoast accesses an attribute from an non existing object, this generates a PHP error which this gets protocolized as we run WordPress in debug mode.
When the object is mastered in your own code, and you can be sure the object exists, you might relax defensive programming.
When on the other hand objects are accessed from other plugins (maybe through callbacks from plugins) you have to check the validity of the references received.
For example (as I do not know what Yoast tries to retrieve from the error messages), when some code accesses a WooCommerce order object, but billing is not provided, and would try to access the address of the billing structure which is non-existing (null) it will throw an error. That this billing object is non-existing is a decision from the plugin, the receiving code (Yoast) has to deal with such situations.I might have reported this already earlier for Yoast or another plugin who generated a lot of errors, advises for turning of debug mode are not helpful.
Forum: Plugins
In reply to: [User Login History] No GEO location: User-Agent not properly defined@faiyazalam
Works, thanks a lotForum: Plugins
In reply to: [Caxton - Create Pro page layouts in Gutenberg] Demo link is brokenStill broken
smart manager version 4.3.11
WooCommerce 4.1
WordPress 5.4.1We are having the same issue:
https://github.com/woocommerce/woocommerce-gateway-paypal-express-checkout/issues/749Thanks, can you please tell us the version of Pro containing the fix.
When not yet released, when do you expect a release of the fixed version?reproduction:
We have two payment gateways: PayPal and bank transfer. We add fees when customers use the PayPal gateway.
When a customer orders with a bank payment and later, via the account/order page, uses the pay action, the order is not recalculated upon changing the payment gateway to PayPal.No additional products are added.
As described above, the customer changes to use a different payment method, the fees are not recalculated.Changed all to copy. Did a bulk edit/update.
Had some hard time with products with variations, showing “product not available, not in stock” (can’t remember the exact message). Sometimes only some variations showed up. Updated several times variations, edited prices or sku’s, updated the product. At the end it worked.
Thanks for your support.Are all of these for WooCommerce Wholesale Prices:
wholesale_customer_have_wholesale_price
wholesale_customer_have_wholesale_price_set_by_product_cat
wholesale_customer_variable_level_wholesale_minimum_order_quantity
wholesale_customer_variable_level_wholesale_order_quantity_step
wholesale_customer_variations_with_wholesale_price
wholesale_customer_wholesale_minimum_order_quantity
wholesale_customer_wholesale_order_quantity_step
wholesale_customer_wholesale_pricewwpp_ignore_cat_level_wholesale_discount
wwpp_ignore_role_level_wholesale_discount
wwpp_post_meta_enable_quantity_discount_rule
wwpp_product_hash
wwpp_product_wholesale_visibility_filterwwp_wholesale_role
Or are they maybe from another plugin?
Thanks for your answer, which I completely understand.
>you are choosing to block access to the WordPress media post type template pages that some sites generate.
Please document/explain this in the features of the plugin.What I thought the plugin would/should do is, that it spots the media during rendering and change the URI, so that it goes through your WP code to check the authorization, either serve the file or redirect to the login page.
The created URI should be obfuscated (e.g. using postId), it should not use the media filename (as a part or complete) within the uploads folder, as that one is directly accessible and not protected.
Forum: Plugins
In reply to: [WPS Hide Login] Redirection not workingRedirection url, Redirect URL when someone tries to access the wp-login.php page and the wp-admin directory while not logged in.
For example when set to ‘/”home”/’.
For /wp-admin/, HTTP/302 and redirect to ‘/home/’.
But for /wp-login.php it is not working, HTTP/404, it does not redirect, it shows ‘Oops! That page can’t be found.’
The behavior is the same when providing an unknown URI, e.g. ‘/notexisting/’.Pages work.
Also have the problem that media can not be protected. Tried withA selected media
(selected the media from the select box)
OR
A media with ID
(took the id from wp-admin/post.php?post=8389&action=edit&lang=en, when selecting to “Edit more details” from the Media page.
OR
A post with ID
(took the id from wp-admin/post.php?post=8389&action=edit&lang=en, when selecting to “Edit more details” from the Media page.
OR
Is a mediaNo errors in debug.log
Forum: Plugins
In reply to: [Loginpetze] Add additional placeholdersChristian, thanks works great.