Roni Laukkarinen

…of course I was logged in as a company account ???♂? But the commenter is me and my GitHub can be found here. Does Advanced Media Offloader has a contribution guidelines or a GitHub repository?

@dhager I renamed the plugin folder from gravity-forms to gravityforms (which is the official dirname anyway after certain version, old plugin versions had hyphen in between that’s why had it like so).

Hi Emre,

I’m extremely busy with work right now, but if you do the icon WordPress way (scalable vector (SVG) icon instead of img) like in my previous example https://github.com/ronilaukkarinen/wp-fastest-cache/commit/81b96df5ec94d0a8197ce412c2ded2e78c525620#diff-9898b34307db8359d47bf3dd05eccbf4

This way it will work more future-proof.
If this is not what you seek I will look on to it later.

Roni

Hello.

I noticed a bug on smaller devices, there’s forced margin-left: 0 that causes the misalignment: https://i.imgur.com/Ekp3ucg.png

Can you remove that line (line 122, #toplevel_page_wpfastestcacheoptions div.wp-menu-name) so it will work, thanks!

OK, good! You can add @rolle or Roni Laukkarinen. ??

Thanks! Couple of issues:

1. the icon is not direct inline svg format (that WordPress supports by its function) but inside which makes the image a bit unsharp. Also the size is a bit over the area that is usually reserved for the icon, don’t you think? Did you look my code suggestion in my earlier message https://github.com/ronilaukkarinen/wp-fastest-cache/commit/81b96df5ec94d0a8197ce412c2ded2e78c525620#diff-9898b34307db8359d47bf3dd05eccbf4 ?

Comparison: https://i.imgur.com/VhF17vv.png (yours) https://i.imgur.com/LHKKWy4.png (mine)

2. I still see colored version in the upper menu https://i.imgur.com/NqXCnfk.png

Can these be tweaked? ??

What do you think? ??

Hello,

Has been a hard year for me as my father passed away so sorry for this taking so long.

I finally got it the official WordPress way. As it comes from svg inline rather than it supports hover and selected coloring:

Screenshots
Without selection + upper menu: https://i.imgur.com/DOHXAqO.png
Selected: https://i.imgur.com/cN1sTsB.png
Hover: https://i.imgur.com/lDEfK0n.png

Changes
Here are the changes it works with, only added svg as inline and things in variables inside add_menu_page() function to easier management, I hope you will accept it: https://github.com/ronilaukkarinen/wp-fastest-cache/commit/81b96df5ec94d0a8197ce412c2ded2e78c525620

All the best,
Roni

Any time, just send me the big version of that icon (512×512 or bigger).

I can convert it to scalable SVG! you can then use my modifications here to make the icon work better.

Do you have bigger size of the icon? I need much bigger than 48×48. 512 x 512 would be suitable.

Any chance for this change? The yellow really stands out too much…

Also noticed in mobile:

My code should fix this as well, as it’s made using WordPress Standards and SVG.

And also, because WP Fastest Cache is bitmap img and not SVG (scalability, performance, best practices).

I think it is, because it’s colored. Those other two are bad examples as well, because they are not the same color than in WordPress otherwise in the sidebar. But at least they are greyscale.

Many plugins do it even better, they add it under Settings so it won’t clutter the sidebar. Tha’ts best practices. You in the other hand have WP Fastest Cache in BOTH up panel and sidebar, that’s bad. Not necessary.

See this screenshot for example:

• This reply was modified 6 years, 5 months ago by Roni Laukkarinen.

Hello,

In case you want to use my modifications, here they are:

This is only public function register_my_custom_menu_page, no other parts changed from wpFastestCache.php: https://gist.github.com/ronilaukkarinen/df2848f0eef65e43754e01f843897af8

toolbar.css in full: https://gist.github.com/ronilaukkarinen/43e675a5b780feb9059d037bfc355047

Icon file (save to images folder): https://gist.github.com/ronilaukkarinen/ecd745cfc8c6443830636b4c36f82d68

• This reply was modified 6 years, 5 months ago by Roni Laukkarinen.
• This reply was modified 6 years, 5 months ago by Roni Laukkarinen.