room34

Scratch my previous reply.

Tip for fellow plugin developers who are running into this issue:

1. You probably don’t need to call load_plugin_textdomain() at all because WordPress has a just-in-time loader for translations in all versions after 4.6. I deleted the code from my plugins and the translations are still working without it, but I still got the warning, because…
2. I poked around a bit further and determined that the call that is generating the notice is at line 151 in?wp-admin/includes/plugin.php?in the?_get_plugin_data_markup_translate()?function. That private function is called by the public function?get_plugin_data()?which I do use in my plugins, fairly early. I see that function has a parameter to bypass translation, so that seems to be my fix.

So, if you’re still getting the error after removing the direct call in your plugin, check if you’re using the get_plugin_data() function, and be sure to set its third input parameter ($translate) to false.

• This reply was modified 5 months, 2 weeks ago by room34.

@iulia-cazan Are you saying it works with after_setup_theme with a different priority? What did you change the priority to?

I’ve tried it with 10 (default), 11, 1, and even PHP_INT_MAX and 0 - PHP_INT_MAX to test the extremes, and I can’t make the notice go away. (Interestingly, get the notices twice for my plugins. Using this hook makes one go away, but another persists. I can’t figure out why, but this is happening in a Multisite setup with Network Active plugins, so perhaps that’s the issue.)

I might need to see the specifics of your setup to troubleshoot this further. Can you please use the Pro Support Request Form (it’s fine if you don’t have a Pro license) to send me your exact shortcode and System Report? Thanks.

It’s frustrating that Outlook does that instead of just deleting them. But you should be able to remove them from the calendar with the hidecancelledevents parameter:

https://icscalendar.com/icsdocs/#hidecancelledevents

@ironprogrammer Thanks for the link… I tested this and it seems to work.

Interestingly… I was having this layout issue in Safari on a site that doesn’t have Classic Editor installed, but that does use Advanced Custom Fields for the fields on a Custom Post Type that hides the main editor window. I installed this version of Classic Editor on that site and it resolved the issue there too!

Anyway, my point is that while this issue obviously does affect Classic Editor, I realize now that it’s not specifically limited to it. Might be a WordPress core issue.

I’ll do a bit more investigation and see if I’m able to replicate the problem on my end. That’s usually the key to figuring out a solution, but sometimes there are specific factors I can’t recreate.

Thanks for following up. It does sound to me like the caching was muddling the situation, which can often be the case. (The caching isn’t directly causing the problem, but because data is cached, it makes it more difficult to pinpoint exactly what’s happening.)

I’m curious if the ICS Feed URL Tester works with this URL now that you’ve turned off the legacy loading method. If it does, then I’d suggest trying the feed in a separate ICS Calendar all by itself and see if that works. (This is not a permanent solution, just an effort at narrowing down the problem, since I wasn’t able to replicate it on my end.)

Actually… I was just taking another look at the code, and I forgot that I had changed the timeout on the new request method to 30 seconds. I see in your System Report that you have the legacy request method turned on. Is there a specific reason you need to use the legacy method? If not, try turning it off and see if the Athletics calendar loads. (The legacy method still has the 5 second timeout.)

Thanks for the follow-up info. I do think it may make sense for me to explore adding an option to configure the request timeout limit within the ICS Calendar settings though. Right now it has a 5-second timeout, which is important for performance (and is usually more than adequate, since this is a request directly between two servers which will typically have high-speed connections, and the transferred data is usually quite small). But I think this is a good example where, if we bumped up the timeout even to 10 seconds, the request would probably go through. You’d get the data, but the page would still probably be a bit slow because all of that old data is getting parsed.

Sharing the bulk of my email response here, since it may be relevant to others who are encountering a similar issue:

I tested your Athletics feed with the preview tool and the ICS Feed URL Tester on my site, and it’s working fine in both cases, and I also was able to download the ICS file by loading the URL directly in my browser.

But… I did notice that it took quite a long time in all three cases, and I think that gets to the heart of the issue. This feed file is pretty large, and I see it has a huge number of events going back as far as 2009.

Unfortunately, old events never get cleared out of the feed (some sources do that, but Google doesn’t), and there’s no way to just request a portion of the feed from the source, so each time the feed is requested, it’s downloading all of that data, most of which is not needed.

I’m not sure if it’s feasible for you to do this, but if you could go in and delete all of the years-old events from the Athletics calendar, it would probably improve the performance. That would really be the “best” solution, but it could be very time-consuming and tedious.

There’s another option, but I’m not positive it will work. The feed may not be loading for you because of a memory issue, but I think it’s more likely a timeout issue. This solution would only help if it’s a memory issue…

Go to ICS Calendar > Settings and Utilities > Settings and bump up the value for Increase memory limit when rendering calendars. Set it to 512 MB to start, and then adjust further if needed. Be sure to run Clear Cached Calendar Data under the Utilities tab after saving the changed setting, then see if the calendar loads.

If the issue is due to a timeout, there’s not currently a way around that, but I could add it as another setting in the next update.

@iamjblackwell Ah, never mind… they both did come in, but Akismet flagged them as spam. Very strange.

@iamjblackwell Strange… it’s just not coming through, but I have received other support requests so I know the form is working.

Can you just email me your shortcode and system report to support at room34 dot com? Thanks.

@iamjblackwell Are you sure you submitted the form? I never received an email notification, and I just went in and checked the form entries directly in my site database and it’s not there.

@tomacino I’m the developer of the plugin. It’s fine… please use the form and send me the info and I’ll help sort it out.