rpetersen29
Forum Replies Created
-
Hi @maxipos
You will need to add this CSS to either Website Custom CSS (pro feature) or another CSS plugin you have:
@media (max-width: 480px) {
.simple-banner {
display: none !important;
}
}The 480px is the breakpoint that you will need to play around with to set to your liking. Usually mobile is in the 300-500 range and tablets are in the 700-800 range.
Hi @farsidefarm
I actually found one of them through the pictures you provided. It looks like the Simple Banner Javascript is still cached and is using the the 2.17.x version. There were breaking changes in the 3.0.0 version hence the major version number update. You’ll need to make sure you clear all cache (looks like in WPRocket) for the banner.
Okay could you provide the URL of one of your sites so i can take a look?
Hi @farsidefarm
Please make sure you are updated to the latest version and clear your server side cache. If you still see undefined when you view your site in Incognito mode, please reach out again.
I went to your site and I am not seeing the double banner issue. I think this might be a browser cache issue. I removed the wp_body_open feature in v3.0.0 but added it back in v3.0.3. If your browser was caching a previous version and you enabled wp_body_open then it would likely show two banners until the cache was cleared. To immediately fix this you can disable wp_body_open and clear your server side cache. Browser caches usually clear pretty quickly so this issue will likely resolve itself in a hour or so with normal browser usage. You can also verify that it is a browser cache issue by viewing your site in Incognito mode. Let me know if the issue still arises then.
Hi @ryantown
I added back wp_body_open in v3.0.3. Thanks for reaching out!
- This reply was modified 6 months, 3 weeks ago by rpetersen29.
Hi @ryantown
wp_body_open was removed for a couple reasons:
- The original intention of the feature was to allow for some alternative methods of translation, which is no longer needed due to the addition of WPML support.
- wp_body_open doesn’t work well with the multi-banner support that was added in v3.0.0, and additionally doesn’t work well with features added in previous versions like Disable Page Paths.
However, CLS issues can certainly be frustrating. So i think what i’ll do is add it back and restrict its usage to Banner #1 while i try to make it work better with the other features. Thanks for reaching out. I’ll try to put that update out tonight.
- This reply was modified 6 months, 3 weeks ago by rpetersen29.
That’s great. This is the biggest update I’ve had in a while, so I appreciate everyone’s patience and help!
Thank you, thats good to know. In that case it’s likely an issue of your browser cache. To see the issue resolved immediately you can clear your browser cache, but it should also clear over the next few hours.
Hi @janverm @aaronwongxm Could you also clear your server-side cache and then view your site in an incognito window and see if that resolves the issue? Thank you.
@janverm @aaronwongxm could you post your site URLs so I can take a look? Thanks!
hi @ankurfox all issues should be fixed in v3.0.2
Great!
Thank you. The issue should be fixed in version 3.0.2 which i just published. Thanks for bringing this to my attention!
hi, ive identified the issue and a fix will be available shortly