sagescrub
Forum Replies Created
-
Wonderful!
Thank you for providing the helpful feedback. I did not consider the auto-save as a possible point of conflict. That is probably what was happening. I am marking this resolved for now. If I notice it happening again, I’ll check to make sure I don’t have other editors open before contacting you. Thank you!
Hi @giuse
Thanks for being patient with me to respond! I am evaluating this new version now.
Firstly I noticed that the plugin is no longer listed in the installed plugins (all plugins) page after installing this version. Strange, because it is running and the FDP menu is still available on the left side.
In reply to your answers:
– Make the color behind the column headers white instead of transparent. This would make it much easier to read. It is distracting to see the rows behind the column labels.
=> It’s not exactly what you suggested, but I think now it’s less distracting. Let me know if also for you it’s ok.
=> => This is definitely better. I still think having the rows and row titles completely disappear behind solid white would be better, and maybe less intensive since it could be done easily with CSS, but this is definitely an improvement ??– Ability to “Hide other rows” with a click would be nice so that I can concentrate on just one row.
=> THis feature is a little hidden, you need to know it because you have no additional button. You need to double-click on a row to see only that row.
At the moment you may need to scroll up after double-clicking. This will probably be improved in the future.
=> => Very nice. Thank you for the “hidden” feature! I will definitely be using it!– I would like to be able to copy/paste row settings even when going to another page. So that I can copy from pages to posts for example. Likewise it would also be nice to copy/paste into the individual edit post page.
=> This was already possible before, I’m surprised it doesn’t work so for you.
Do you have JavaScript errors in the console? Have you maybe deactivated the local storage in your browser?
=> => OK, I didn’t realize this is a feature already. It must have been user error last time I tried ?? I will try again and let you know if there is an issue.
Edit: If I go to edit the single page (Edit Page), I do not see copy/paste icons in the FDP section. Am I missing something? Also, when I click on “Go to Singles Settings” from this page, the hover menu does not appear (grid with isolated row), so I cannot take any row actions, including pasting.– The search by title feature does not work too well for me. I try searching by one word and I get a lot of irrelevant results.
=> The text of the button was not right, this is not really a search by title. The results include also the posts having content that contains the word you type in the searching field.
Maybe I will add a real search by title in the future, but I can’t say when.
=> => No problem ??– The zoom button does nothing for me. I see that it changes its color slightly when I click it. But nothing else happens. I am using firefox.
=> Strange that it doesn’t work for you. Do you have JavaScript errors in the console? How many plugins do you have? Do you know how large is the viewport in pixels?
=> => There are no errors in the console. I have 61 plugins on the staging site where I am testing this. I tried various viewport widths from 600px to 2500px and still no change.– It would be helpful if the row was highlighted in some way when the row controls tooltip appears, so I can be sure what row I am working with.
=> It’s so now, let me know if it’s ok for you.
=> => Yes the highlight is helpful, thank you! I think it would be more elegant if it was a more subtle color shift and if it still had the cell borders (at least left & right borders) for locked rows.– “Included in Navigation” filter button doesn’t work for me. Perhaps because my theme has multiple menus and FDP doesn’t know which one we are using as the main menu.
=> This was probably because the items belong to menus that are not located. I mean menus that are not assigned to a primary location or a secondary location.
In any case, now the plugin considers the menu items of all menus, also those ones that are not located. Let me know if it works now.
=> => This is much better! Thank you!0
Edit: I noticed that the filter does not change the number of results/pages, so I have to increase the number of items per page to several hundred before clicking the filter. It slows down the interface a bit when scrolling, even after the filter is applied. Its not a big deal, but I am mentioning it in case the feedback is useful to you.– It would be nice to have a filter for top-level pages only (exclude child pages).
=> I wrongly remembered you asked for a filter for child pages ?? I realize now while I’m answering that you were speaking about top-level pages ??
This new version has a filter for child pages, maybe the next version will have also a filter for top-level pages.
=> => LOL How funny! Nice… I will see if the child page feature is helpful, perhaps combined with another filter.Thank you so much! I really appreciate your willingness to consider and implement some of these suggestions. I hope the improvements help others as well.
- This reply was modified 3 years, 2 months ago by sagescrub.
Yes, that fixed it! Thank you!
It appears to be working well now with my initial test ?? Thank you Jose!
Yes! This fixed the issue with missing plugins in the last page. Thank you Jose!!
I think I have answered my question. After reviewing carefully and testing the global option EOS_xx_ACTIVE I realize that I had two incorrect assumptions.
1. If constant EOS_xx_ACTIVE is true, it means it is disabled. I thought that Active means NOT disabled.
2. I misunderstood how you use the word ‘global’ in the documentation. I thought Global referred to the entire site, not just the current page. I think you mean something else by global.
Also, a side note: In working through my own troubleshooting I printed out all of the ‘EOS_xx_ACTIVE’ constants. I noticed that some had the boolean value true and some had the value of string ‘true’. So I think it is ok when comparing with == true but not with === true.
Here is the code I came up with to check if a plugin is disabled on the current page. Please let me know if this is correct usage.
function freesoul_is_plugin_disabled( $plugin_filename ) { if ( ! is_plugin_active( 'freesoul-deactivate-plugins/freesoul-deactivate-plugins.php' ) ) { return false; } $constant = 'EOS_' . strtoupper( $plugin_filename ) . '_ACTIVE'; return defined( $constant ) && constant( $constant ) == true; }
Jose,
Thank you for going to the extra effort to help figure out the issue here. I followed the steps you outlined and emailed you the three log files.
1- Home Logged in – No plugins have been disabled.
2- Home Not Logged in – No plugins have been disabled.
3- About Page – Not Logged in – Plugins are disabled as expected.Thank you!
Thank you Jose! I have followed up via the contact form.
Most of those MU plugins (except 1 & 2) are installed by the WP Engine web host.
OK I upgraded the debug plugin.. Here you go! I hope it is insightful.
GENERAL INFO
PHP version 7.4.22
FDP MU PLUGIN VERSION: 1.8.8.7.4
FDP VERSION 1.8.8.7.4
REQUEST ACTION false
REQUEST EMPTY true
FDP_REMOVE_FILTERS_BEFORE_FIRST_PLUGIN false
WP_CLI false
WP_SANDBOX_SCRAPING false
DOING_AJAX false
EOS_DP_URL_APPLY_ON_SEARCH false
SERVER true
WORDPRESS VERSION 5.8
MULTISITE false
SERVER SOFTWARE Apache
MAXIMUM EXECUTION TIME 3600
MAXIMUM INPUT VARS 10000
PERMALINK STRUCTURE /%postname%/
FILESYSTEM LAST STATUS ok
Theme cookie-child
Theme Root /themesJose, Here is the info you requested with URLs omitted. Regarding the Drop-in, advanced-cache.php is 0 bytes.
GENERAL INFO
PHP version 7.4.22
FDP MU PLUGIN VERSION: 1.8.8.7.4
FDP VERSION 1.8.8.7.4
WORDPRESS VERSION 5.8
MULTISITE
SERVER SOFTWARE Apache
MAXIMUM EXECUTION TIME 3600
MAXIMUM INPUT VARS 10000
PERMALINK STRUCTURE /%postname%/
PAGE FOR POSTS ID 70285
FRONT PAGE 637
FILESYSTEM LAST STATUS ok
Theme cookie-child
Theme Root /themesMU-PLUGINS
1 eos-deactivate-plugins.php
2 learndash-multisite.php
3 mu-plugin.php
4 slt-force-strong-passwords.php
5 wpe-elasticpress-autosuggest-logger.php
6 wpe-wp-sign-on-plugin.php
7 wpengine-security-auditor.phpDROP-IN PLUGINS
1 advanced-cache.php- This reply was modified 3 years, 3 months ago by sagescrub.
One other comment: The issue is now appearing in a private window with a logged out user. So it is not only happening for the admin. I am not sure why that was the case before.
Thank you for the quick reply and more info!
Good question if it only happens on the home page, I had not yet tested other pages. I checked a few other pages. It seems at first glance that the issue is only on the homepage.
Regarding caching. We use two plugins: Autoptimize and WP Optimize. Both have been disabled. I also manually deleted the cache contents. So it should not be serving cache.
On the hosting side we use WP Engine. I have manually cleared the host cache. I also disabled object caching. I spoke with the host support and they made sure the caching is cleared.
When I click on the eye icon, the page loads with the plugins disabled as expected. In the console it shows the list of disabled plugins under “Disabled Plugins”. But under homepage ID XXX there are no disabled plugins listed.
One new thing that I learned is when I switch to a default theme, the plugins are disabled as expected. Perhaps the theme is loading the homepage in a way that is not consistent with what Freesoul is expecting? I am not sure if that is the right path since the preview and the eye icons work fine.
Thank you!