samedwards

We’re seeing the same issue, and have temporarily worked around it with this filter:

add_filter('tribe_asset_enqueue', function ($enqueue, $asset) {
    if (in_array(
        $asset->get_file(),
        ['', 'tribe-events-pro-theme-mobile.css', 'tribe-events-pro-theme.css', 'tribe-events-pro-full-mobile.css'],
        true
    )) {
        return false;
    }

    return $enqueue;
}, 10, 2);

Hi Natalie,

Thanks for looking in to this. From the SVN logs, it looks like there might sometimes be a different procedure followed for your releases. When I noticed this issue last week, 1.6.1.1 was the current version, and there is just a single SVN commit, with the message only saying “1.6.1.1”, whereas 1.6.1.2 is now the current release, and I see two commits, with the messages “Committing 1.6.1.2 to trunk” and “Tagging 1.6.1.2”, which is what I would expect.

This is the same issue I previous reported here: https://www.ads-software.com/support/topic/multisite-and-sql-syntax-errors/

I see in the changelog for 1.1.19, you’re reporting you’ve fixed this, but I believe you’ve simply caused another problem. As you’re now using add_site_option everywhere to check and set the hfcm_db_version option, there exists a possibility where only the first blog on a multisite installation would get the new schema, and any other blogs would skip it, because hfcm_db_version would have been set globally for the network, and not the individual blog.

Hello,

The issue still remains with checking the hfcm_db_version option in the current version of the plugin. Please refer to my original post for more details about how using get_site_option() is the wrong function to use.

@99robotsteam Do you have plans to fix these bugs in the plugin? I see there have been two new releases recently, but that these were not fixed. I’ve submitted a GitHub pull request with the proper fixes for these issues at https://github.com/99robots/99robots-header-footer-code-manager/pull/6

And since these issues have both been reported before without resolution, I’ve gone ahead and made some workarounds that I’ve installed in an mu-plugin if anyone else comes across this and wants and immediate fix.

add_filter('dbdelta_queries', function ($queries) {
    global $wpdb;

    if (class_exists('NNR_HFCM')) {
        $table_name = $wpdb->prefix . NNR_HFCM::$nnr_hfcm_table;
        $badsql  = "CREATE TABLE IF NOT EXISTS $table_name(";
        $goodsql = "CREATE TABLE $table_name (";

        foreach ($queries as $id => &$query) {
            if (strpos($query, $badsql) === 0) {
                $query = str_replace($badsql, $goodsql, $query);
            }
        }
    }

    return $queries;
});

add_filter('pre_site_option_hfcm_db_version', function () {
    return get_option('hfcm_db_version');
});