Scott Bressler

But Media Credit doesn’t use either img_caption_shortcode or add_shortcode(‘caption’)…

No, [caption] was definitely there in old versions (running a old version here to test). So I don’t understand — did the caption shortcode use to allow shortcodes within but it doesn’t any longer?

Thanks for committing and un-releasing.

Calling all testers: download the latest version of Media Credit below, install it (manually, sadly) and let us know how it works for you! Thanks!

https://downloads.www.ads-software.com/plugin/media-credit.zip

Ah, my bad — didn’t think of there being a difference. pputzer added now!

Doesn’t look like adding to the contributors line should be at all necessary. Are you sure you’re committing with the same e-mail address that you’re logged into this site with? I assume that’s how the auth is done.

Hi Elethu,
Yeah, we’re fixing up Media Credit for recent versions of WordPress.
Thanks for your patience!
-Scott

Peter — any updates on committing a version of your patch to trunk?

I spot checked on a site running an old version of WP where Media Credit was working fine.
With a caption, the caption should go inside the caption shortcode, no? Something like:
[caption caption="Caption here..."][media-credit]<img />[/media-credit][/caption]
Without a caption, the [caption][/caption] should not be necessary.

Did you figure this one out?

Thanks for your thoughts. I think you’ve convinced me — 3.5+ compat is just fine. Let’s get this into trunk, hopefully others on the thread can try it out, and then let’s tag. You can update the tested up to to include 3.6 ??

Added! Please keep the changelog additions, but remove the Stable Tag change. Also, can we test up to 3.6? And can we check if the changes work with older versions of WordPress? I’d like to maintain backward compatibility if it’s not difficult. Finally, is any upgrade script required or were there no database changes?

Peter, let’s expedite the process — how about I add you as a contributor on Media Credit? You can commit the latest code to trunk and I’ll try it out (and then others can do the same) and then we’ll tag it after a bit of testing. How does that sound? I want to expedite this but haven’t given it the priority it deserves.

Thanks,
Scott

Will, I doubt we’d be switching to a single tag structure as Byron’s fork does since migration would be a pain. I could only see that being necessary if WP core forces our hand, which I’d hope recent releases haven’t required.

Hi folks!

Sorry for the extraordinarily long absence. I’d love to get a new version of MC released that works for 3.5/3.6, etc. Byron and Peter, I just e-mailed you both individually, but I figured keeping the conversation in public here would be best.

Peter, did your latest patch fix all issues and maintain backward compatibility? TinyMCE integration, autocomplete, etc. Does it take into account the details in this post? I’m working to get Media Credit set up on GitHub, but until then, can you link to it somewhere?

Thanks, all!

All the best,
Scott

Fixed here. Will go out with our next release shortly. Once it goes out, you’ll be able to use the ef_story_budget_filter_terms filter as was meant to work.

I’m sorry I haven’t been able to update the plugin for quite a while.

The code that Barry copied is from the FAQ page for Media Credit, which indeed mentions putting it in your functions.php file:
https://www.ads-software.com/extend/plugins/media-credit/faq/