schleusse
Forum Replies Created
-
Forum: Plugins
In reply to: [YAK for WordPress] fix jquery-tools dependence (patch proposed)Cool, that’s great.
Maybe you didn’t see it because of different implementations of the $_SERVER variable? (I am new to PHP, I don’t know about it)
Please also add then the two null parameters to the wp_enqueue_script function. Although it seems to me that even without them the inclusion of jtools used to work at some point, it currently does not on my system, which is the behaviour predicted by the wp_enqueue_script documentation.
Will you also add support for choosing the custom post types where the YAK interface is loaded? I could help you on this if you wish.
I would also be happy to have a look at your changes before you release the new version.
Forum: Plugins
In reply to: [YAK for WordPress] fix jquery-tools dependence (patch proposed)Thanks for the quick reply. I use YAK 3.4.8.
jquery tools is loaded on many more WP admin pages than those you mention, among them the NextGEN settings pages. The reason is the check at line 1034 of yak-admin.php
$url = $_SERVER[“REQUEST_URI”];
if (yak_str_contains($_REQUEST[‘page’], ‘yak’) || yak_str_contains($url, ‘post’) || yak_str_contains($url, ‘page’))It lets through requests such as
https://mysite/wp-admin/admin.php?page=nextgen-gallery
presumably because they contain the string “page” (are the GET parameters included in the URI? )
Maybe you want to check for the string “post_type=page” instead.
If would be nice by the way to be able to specify the (custom) post types where the YAK interface is loaded.
Thanks and keep up the good work!
Forum: Plugins
In reply to: [YAK for WordPress] fix jquery-tools dependence (patch proposed)By the way, thanks for this great plugin!
Works like a charm, thanks a lot for this! Question from a WP newb: Why can’t the nggGetGallery function reside in the album-lightbox.php file? This would avoid tainting my theme (Origin in this case)..