scottsawyer

Thank you, will test asap. I appreciate you jumping on this.

I think I found it https://plugins.trac.www.ads-software.com/browser/advanced-product-fields-for-woocommerce/trunk/includes/classes/class-html.php#L186

implode(' ',array_merge(array_map('sanitize_html_class',$extra_classes,$classes))),

Should be

implode(' ',array_merge(array_map('sanitize_html_class',$extra_classes),$classes)),

@im_niloy Thank you for your offer to debug, however, this is a production site with minified CSS and JS, so there’s not much to see. It took 2 hours to dig around to find the offending line in a local dev env.

What I am requesting is that you reconsider this line of CSS, particularly the level of specificity including the !important declaration.

Thanks.

Mentioned in the video, we added padding to the slide, however, this new style rule is overriding our styles. Again, adding such a specific style rule + !important is pretty heavy handed, breaks our design, and wasn’t caught in our automated visual regression tests. I’ve updated our tests so hopefully these kinds of changes will get caught in the future. I understand that some people were having problems with their theme, and I appreciate you wanting to help alleviate people’s problems setting up the plugin, but that seems like a problem that they should resolve in their development stage, as opposed to introducing a new style that can break existing implementations.

Philosophically, I think plugin styling should be less “opinionated” in general, so themers don’t have to fight someone else’s styling choices. We’ve already spent time making the plugin look “right” on our site, but then a new styling opinion is introduced after development is complete and when the site is in a maintenance cycle, it adds to customer frustration. Luckily, I found the issue before the update was deployed, but I had to spend time (i.e. customer money) to find the problem and fix it.

Same error in my install as well.

I think I am receiving a similar message ( sorry, can only read English ).

<b>Notice</b>: register_rest_route was called <strong>incorrectly</strong>. The REST API route definition for <code>cf-api/v2/entries</code> is missing the required <code>permission_callback</code> argument. For REST API routes that are intended to be public, use <code>__return_true</code> as the permission callback. Please see <a href="https://www.ads-software.com/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 5.5.0.) in <b>/core/wp-includes/functions.php</b> on line <b>5229</b><br>

• This reply was modified 4 years ago by scottsawyer. Reason: Removed private server info

Would be super nice to know what the problem is.
Just that it hasn’t been updated in a while?
Known vulnerabilities?
Known incompatibilities?
Lack of communication from the maintainer?

FYI, what I wound up doing is downloading the Fontawesome pro icons and uploaded to my theme. Then I used Symfony\Yaml to parse the categories.yml and icons.yml to build an array of icons.

/*
 * Add font with icons to Getwid plugin.
 * Use this code in functions.php or custom plugin.
 */

// add hook
add_action( 'getwid/icons-manager/init', 'my_theme_getwid_add_custom_icons' );

function my_theme_getwid_add_custom_icons( $manager ) {

	// register new font
	$custom_icons = [
		// load icons list for visual editor from function
		'icons' => my_theme_custom_icons_list(),
		// or load icons list for visual editor from file
		//'icons' => require( get_template_directory() . '/custom-icons-list.php' ),
		'style' => 'custom-icons',
		'enqueue_callback' => 'my_theme_enqueue_custom_icons_style'
	];

	$manager->registerFont( 'fontawesome-pro', $custom_icons );
}

function my_theme_enqueue_custom_icons_style() {
	//load font css
	wp_enqueue_style( 'fontawesome-pro', get_template_directory_uri() . '/assets/vendor/fontawesome-pro/css/all.min.css' );
}

function my_theme_custom_icons_list() {
	$icons = [];
	$icon_prefix = 'fa-';
	$style_prefixes = [
		'brands' => 'fab',
		'solid' => 'fas',
		'regular' => 'far',
		'light' => 'fal',
		'doutone' => 'fad',
	];
	// This is the directory where I put the fontawesome pro yml files
	$meta_dir = get_template_directory() . '/assets/vendor/fontawesome-pro/metadata';
	// This is where I call Symfony\Yaml which parses the yml to an array.
	$categories = $this->utils->parse_yml( $meta_dir . 'categories.yml' );
	$icons_array = $this->utils->parse_yml( $meta_dir . 'icons.yml' );
	foreach ( $categories as $category ) {
		foreach ( $category['icons'] as $icon ) {
			foreach ( $icons_array[$icon['styles']] as $style ) {
				$icons[$category['label'][] = $style_prefixes[$style] . ' ' . $icon_prefix . $icon;
			}
		}
	}
	return $icons;

}

This will effectively overwrite the icon list for the free version that come with the plugin. However, you will now be loading the pro css and the free css. So I just wp_dequeue_style( ‘fontawesome-free’ ); wp_deregister_style( ‘fontawesome-free’ );

This works pretty well. Future enhancement would be to cache the icons list…

gah! Makes sense, thanks for the fast response. Closing…

FYI, the 1.0.4 update broke this as well. Fortunately, the same fix still works.

BTW, your github link on the plugin home page goes to a 404 page.

it looks like that may have been the issue, I resynced and reset the form and it worked. Strange.

The answer is you do not use a label. You use a placeholder.

<label>Name</label>
[*name your-name placeholder “Name”]

Then in your styling, set the label color to transparent.

@keraweb Yeah, I figured as much, and I agree.

Hey Guys,

Thanks for the response, sorry it’s taken so long to get back, these notifications got lost in email.

I haven’t had a chance to refactor the class names. I will post back when I get a chance ( probably 2 weeks from now ).

@gerrydesmet are you saying you want a select list like:

<select name="license">
  <option><img src="path/to/image.jpg"></option>
  <option><img src="path/to/image-2.jpg"></option>
</select>

If so, the short answer is, no, you can not include HTML in select options. To do something like this, you need some sort of JavaScript solution that looks like a select widget. ( see: https://stackoverflow.com/questions/11237807/can-i-use-html-tags-in-the-options-for-select-elements )

If this is not what you are trying to do, then I don’t understand the question.