shelleyp

Thanks for the note — I have modified my copy of the file, and I’ve been working with 1.2 in a separate site, but hadn’t ported old site over yet.

It’s the option to search a post for pingbacks that’s taking the time. Lot’s of time.
No biggie, just turn it off. Auto pinging isn’t a good idea, anyway.
Live and learn.

The upload problems were me hitting the size limit, and getting odd behavior. Looked into code and found the problem.
Other than wrapping the thumbnail with a link to the larger image, which is probably a feature request, it seems to be fine.
Sorry

I’m using PHP 4.3.4. And I tried this with WP 1.02.
I get an error message — can’t find the image.
I did check and I’ve turned on the option to print out comments, but they aren’t showing in the page.

Unfortunately, the link to this plugin is returning page not found errors.

Still trying to find out how to add in plugins, but does this provide a Preview button and comment preview page?

There’s an option in Misc options, a checkbox, that you can check to enable my-hacks.php. It’s at the bottom of the page.

Walrus, I couldn’t access the subdirectory, or access the setup or the application or the blog.php with 666. Pretty much everything. I had better luck with 755.
Also, I found that it isn’t picking up photos when you have these in your posts. And it’s not picking up comments, and I’m using 1.02.

This is a great plugin. I tried it with my 1.02 install.
I did have to play with permissions to get this to work — 666 didn’t work. Other than that, though, very easy app to install and use.

WillM, you caught my earlier message before deleting. I thought it was irritated, which is why I deleted it — something about being chastized does that to me. However, I need to add in the bits that your comment is a reply to.
I asked in it who Mark was and why he felt compelled to jump in when I was talking to Matt and WillM. I also mentioned that how to use CVS wasn’t the point of what I was trying to say, but I think I was being too subtle.

I know how to generate a diff, thanks. That wasn’t the point.
Not a problem — I’ll write whatever and people can use whatever. End of story.
WillM, you are not winning fans for WordPress.

I’ll post to my site my own version of 1.2 with the changes I want to incorporate and I’ll send you all copies. Feel free to accept or reject any of it.
Of course, without the changes being part of CVS and without coordinated effort, you can’t just replace the files because other people are also making changes to the same files, which means manual merging.
But hey! It’s code and that’s what counts.

Well, then, I guess the developers are just going to have to fix the bugs and do the documentation. After all — we’uns wouldn’t want to track dirt all through their nice clean code and documentation.

PS
The existing comment_type function echos the comment type, and I needed one that would return it as a string that I could then test and respond accordingly. That’s the only reason for the one hack.
Now, anyway I can convince you all to create a new database field for comment type, rather than embedding it into the string? I’ll help you make whatever code changes are necessary to make this move.
A new enum would be good, with values of ‘trackback’, ‘pingback’, and comment.
Or was there some reason you went this route originally?

No, I prefer the ability to be able to specify moderated on a per post basis, so I think I will continue using this implementation, and add it to my version of 1.2.
As for crapflood — rule of thumb is don’t overengineer. You don’t have to be clever with a soution; a ‘clever’ solution means you’re applying a lot of processing for ‘good comments’. I check to make sure only a certain number of comments are added per hour and it prevents a flood, and that’s all I care about. Once I have bulk comment and post management, and per post comment moderation, I’ll have all I need. It may not fit an ‘official’ WP track — but that’s the benefit of open source, isn’t it?
And your comment_type function didn’t work as I needed it, but no biggie. That one did fit a hack easily.
As for the split, I must have looked at the database wrong because you aren’t annotating the type of comment in it — I thought I saw that you were. I’m assuming this means you’re using embedded intelligence in your data field for the comment. I will probably change this — as a former DBA, I have a real reaction against this, though I imagine it works well for the WordPress.
(Hmm, may be making a lot of significant changes, which probably won’t get folded back into WP. I wonder if I’ll end up forking?)
If you’re tweaking the admin interface, than I will wait on my edits. That’s one of the areas I was interested in changing.
I’m happy with my 1.02 installation now–I’ll just wait for 1.2 stable, make my edits and then provide packages and/or instructions. I won’t post anything for the 1.02 changes since this is an obsolete implementation.